Deduplicate grounded and airborne state lifecycle logic #22

Closed
opened 2026-09-15 16:42:57 +00:00 by EIREXE · 0 comments
Owner

Severity: Architecture

Grounded collision-to-fall logic is repeated in wait.rs, walk.rs, run.rs, dash.rs, land.rs, and jump.rs. Air collision-to-landing logic is repeated in fall.rs, jump.rs, and air_dodge.rs.

Fix: extract shared grounded and airborne collision/update policies with explicit parameters such as can_walk_off and landing type. Add behavior-equivalence tests.

Severity: Architecture Grounded collision-to-fall logic is repeated in wait.rs, walk.rs, run.rs, dash.rs, land.rs, and jump.rs. Air collision-to-landing logic is repeated in fall.rs, jump.rs, and air_dodge.rs. Fix: extract shared grounded and airborne collision/update policies with explicit parameters such as can_walk_off and landing type. Add behavior-equivalence tests.
Sign in to join this conversation.
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: EIREXE/shinespark#22