Add authoritative fighter surface state

src/fighter/baked_animation/runtime.rs

@@ -88,12 +88,6 @@ impl FighterBoneMatrices {
         ]
     }
 
-    pub fn get_by_idx(&self, index: usize) -> Option<(FixedMat4, FixedMat4)> {
-        Some((
-            *self.previous_frame_matrices.get(index)?,
-            *self.matrices.get(index)?,
-        ))
-    }
     pub fn get(&self, bone: &str) -> Option<(FixedMat4, FixedMat4)> {
         let index = self.bone_names.iter().position(|name| name == bone)?;
         Some((

src/fighter/debug.rs

@@ -153,10 +153,10 @@ pub fn fighter_debug(
     Ok(())
 }
 
-pub fn animation_debug(query: Query<(&FighterTranslation, &FighterFacingDirection, &FighterBoneMatrices)>, mut gizmos: Gizmos) {
-    for (global_transform, facing_dir, matrices) in query {
-        let global_transform = global_transform.get_3d_transform(facing_dir);
-        let marker_transform = global_transform.to_mat4();
+pub fn animation_debug(query: Query<(&GlobalTransform, &FighterBoneMatrices)>, mut gizmos: Gizmos) {
+    for (global_transform, matrices) in query {
+        let (_, rotation, translation) = global_transform.to_scale_rotation_translation();
+        let marker_transform = Transform::from_translation(translation).with_rotation(rotation);
         for (_, matrix) in matrices.iter() {
             let pos = marker_transform.transform_point(Vec3::new(
                 matrix.cols[3][0].to_num(),

src/fighter/ecb.rs

@@ -1,44 +1,28 @@
 use bevy::prelude::*;
 
-use crate::{
-    fighter::{
-        FighterFacingDirection, FighterSurfaceState, FighterTranslation,
-        baked_animation::FighterBoneMatrices,
-    }, math::{int::FGi32, vec::FGVec2},
-};
+use crate::math::{int::FGi32, vec::FGVec2};
 
 /// Environment collision box: the diamond used to resolve a fighter against
 /// the stage. Purely geometry — the collision response lives in
 /// [`super::collision`].
-#[derive(Component, Debug, Clone, Copy, Hash, Default)]
+#[derive(Component, Debug, Clone, Copy, Hash)]
 #[require(FighterPreviousECB)]
 pub struct FighterECB {
-    pub top: FGVec2,
-    pub bottom: FGVec2,
-    pub left: FGVec2,
-    pub right: FGVec2,
-}
-
-#[derive(Component, Debug, Clone)]
-pub struct FighterECBBoneIndices {
-    pub indices: Vec<usize>,
+    pub vertical_half: FGi32,
+    pub horizontal_half: FGi32,
 }
 
 #[derive(Component, Debug, Clone, Copy, Default, Hash)]
 pub struct FighterPreviousECB {
-    pub top: FGVec2,
-    pub bottom: FGVec2,
-    pub left: FGVec2,
-    pub right: FGVec2,
+    pub vertical_half: FGi32,
+    pub horizontal_half: FGi32,
 }
 
 impl From<FighterECB> for FighterPreviousECB {
     fn from(ecb: FighterECB) -> Self {
         Self {
-            top: ecb.top,
-            bottom: ecb.bottom,
-            left: ecb.left,
-            right: ecb.right,
+            vertical_half: ecb.vertical_half,
+            horizontal_half: ecb.horizontal_half,
         }
     }
 }
@@ -51,92 +35,56 @@ pub fn snapshot_fighter_ecb(fighters: Query<(&FighterECB, &mut FighterPreviousEC
 
 impl FighterECB {
     pub fn to_3d_lineloop(&self, trf: Transform) -> [Vec3; 4] {
-        [self.top, self.right, self.bottom, self.left]
-            .map(|point| trf.transform_point(Vec3::new(point.x.to_num(), point.y.to_num(), 0.0)))
+        let rel_up = trf.transform_point(Vec3::new(
+            0.0,
+            (self.vertical_half + self.vertical_half).to_num(),
+            0.0,
+        ));
+        let rel_down = trf.transform_point(Vec3::new(0.0, 0.0, 0.0));
+        let rel_left = trf.transform_point(Vec3::new(
+            (-self.horizontal_half).to_num(),
+            self.vertical_half.to_num(),
+            0.0,
+        ));
+        let rel_right = trf.transform_point(Vec3::new(
+            self.horizontal_half.to_num(),
+            self.vertical_half.to_num(),
+            0.0,
+        ));
+        [rel_up, rel_right, rel_down, rel_left]
     }
 
     pub fn get_bottom_point(&self) -> FGVec2 {
-        self.bottom
+        FGVec2::new(FGi32::ZERO, FGi32::ZERO)
     }
 }
 
 impl FighterPreviousECB {
     pub fn to_3d_lineloop(&self, trf: Transform) -> [Vec3; 4] {
-        [self.top, self.right, self.bottom, self.left]
-            .map(|point| trf.transform_point(Vec3::new(point.x.to_num(), point.y.to_num(), 0.0)))
+        let rel_up = trf.transform_point(Vec3::new(
+            0.0,
+            (self.vertical_half + self.vertical_half).to_num(),
+            0.0,
+        ));
+        let rel_down = trf.transform_point(Vec3::new(0.0, 0.0, 0.0));
+        let rel_left = trf.transform_point(Vec3::new(
+            (-self.horizontal_half).to_num(),
+            self.vertical_half.to_num(),
+            0.0,
+        ));
+        let rel_right = trf.transform_point(Vec3::new(
+            self.horizontal_half.to_num(),
+            self.vertical_half.to_num(),
+            0.0,
+        ));
+        [rel_up, rel_right, rel_down, rel_left]
     }
 
     pub fn get_bottom_point(&self) -> FGVec2 {
-        self.bottom
+        FGVec2::new(FGi32::ZERO, FGi32::ZERO)
     }
 }
 
-pub fn update_ecb(
-    query: Query<(
-        &mut FighterECB,
-        &FighterSurfaceState,
-        &FighterECBBoneIndices,
-        &FighterBoneMatrices,
-        &FighterTranslation,
-        &FighterFacingDirection,
-    )>,
-    mut gizmos: Gizmos
-) {
-    for (mut ecb, surface_state, bone_indices, bone_matrices, translation, facing_dir) in query {
-        let trf = translation.get_3d_transform(facing_dir);
-
-        gizmos.cross(trf.get_translation().to_vec3(), 2.0, bevy::color::palettes::css::BLUE);
-
-        let transformed_ecb_bones = bone_indices.indices.iter().filter_map(|idx| {
-            let Some((_, bone_matrix)) = bone_matrices.get_by_idx(*idx) else {
-                return None;
-            };
-
-            let pt = trf.transform_point(bone_matrix.get_translation());
-
-            Some(FGVec2::new(pt.x, pt.y) - translation.0)
-        }).collect::<Vec<_>>();
-
-        let max_x = transformed_ecb_bones.iter().max_by(|a, b| a.x.cmp(&b.x)).map(|final_val| final_val.x).unwrap_or(FGi32::lit("0.5"));
-        let min_x = transformed_ecb_bones.iter().min_by(|a, b| a.x.cmp(&b.x)).map(|final_val| final_val.x).unwrap_or(FGi32::lit("-0.5"));
-        let max_y = transformed_ecb_bones.iter().max_by(|a, b| a.y.cmp(&b.y)).map(|final_val| final_val.y).unwrap_or(FGi32::lit("0.5"));
-        let min_y = transformed_ecb_bones.iter().min_by(|a, b| a.y.cmp(&b.y)).map(|final_val| final_val.y).unwrap_or(FGi32::lit("-0.5"));
-
-        let midpoint_height = (max_y + min_y) / FGi32::lit("2.0");
-        let top = FGVec2::new(FGi32::ZERO, max_y);
-        let bottom = FGVec2::new(FGi32::ZERO, min_y);
-        let left = FGVec2::new(min_x, midpoint_height);
-        let right = FGVec2::new(max_x, midpoint_height);
-
-        let ecb_lock_frames_remaining = if let FighterSurfaceState::Airborne { ecb_lock_frames_remaining } = *surface_state {
-            ecb_lock_frames_remaining
-        } else {
-            0
-        };
-
-        dbg!(ecb_lock_frames_remaining);
-
-        ecb.top = top;
-        
-        if ecb_lock_frames_remaining == 0 {
-            ecb.bottom = bottom;
-        }
-
-        ecb.left = left;
-        ecb.right = right;
-
-        if surface_state.is_grounded() {
-            ecb.bottom = FGVec2::ZERO;
-        }
-    }
-}
-
-pub fn decrement_ecb_lockout(surface_states: Query<&mut FighterSurfaceState>) {
-    for mut state in surface_states {
-        state.tick_ecb_lock();
-    } 
-}
-
 #[cfg(test)]
 mod tests {
     use super::*;
@@ -144,16 +92,12 @@ mod tests {
     #[test]
     fn previous_ecb_copies_current_dimensions() {
         let current = FighterECB {
-            bottom: FGVec2::lit("0.0", "-0.5"),
-            top: FGVec2::lit("0.0", "0.5"),
-            left: FGVec2::lit("-0.5", "0.0"),
-            right: FGVec2::lit("0.5", "0.0"),
+            vertical_half: FGi32::lit("0.5"),
+            horizontal_half: FGi32::lit("0.25"),
         };
         let previous = FighterPreviousECB::from(current);
 
-        assert_eq!(previous.top, current.top);
-        assert_eq!(previous.bottom, current.bottom);
-        assert_eq!(previous.left, current.left);
-        assert_eq!(previous.right, current.right);
+        assert_eq!(previous.vertical_half, current.vertical_half);
+        assert_eq!(previous.horizontal_half, current.horizontal_half);
     }
 }

src/fighter/manifest.rs

@@ -65,7 +65,6 @@ pub struct FighterManifest {
     pub animations: HashMap<AnimKind, String>,
     pub attack_scripts: HashMap<AttackKind, String>,
     pub hurtboxes: Vec<FighterHurtbox>,
-    pub ecb_bones: Vec<String>,
 }
 
 #[derive(Resource)]

src/fighter/mod.rs

@@ -34,13 +34,24 @@ pub use motion::{
 pub use surface::FighterSurfaceState;
 
 use crate::{
-    AppState, fighter::{
+    AppState,
+    fighter::{
         attack::{
             AttackKind, FighterAttackPlugin, FighterAttackScriptAssets, FighterDamage,
             FighterKnockbackVelocity, FighterPendingHitReaction, FighterSolvedHurtboxes,
             FighterStaleMoveQueue,
-        }, baked_animation::{FighterBoneIndexMap, FighterBoneMatrices}, ecb::FighterECBBoneIndices, manifest::FighterManifest, state::{FighterState, air::AirborneStateCommon, fall::FallState}, visual::FighterAnimations,
-    }, input::FighterInput, math::{int::FGi32, vec::FGVec2}, player::Player, schedule::GameplaySet, scripting::FighterAttackScript, stage::line::StageCollision,
+        },
+        baked_animation::{FighterBoneIndexMap, FighterBoneMatrices},
+        manifest::FighterManifest,
+        state::{FighterState, air::AirborneStateCommon, fall::FallState},
+        visual::FighterAnimations,
+    },
+    input::FighterInput,
+    math::{int::FGi32, vec::FGVec2},
+    player::Player,
+    schedule::GameplaySet,
+    scripting::FighterAttackScript,
+    stage::line::StageCollision,
 };
 use state::state_interrupt_system;
 
@@ -171,7 +182,7 @@ impl Plugin for FighterPlugin {
             )*/
             .add_systems(
                 GgrsSchedule,
-                (ecb::update_ecb, state::state_collision_interrupt_system, ecb::decrement_ecb_lockout).chain().in_set(GameplaySet::Collision),
+                state::state_collision_interrupt_system.in_set(GameplaySet::Collision),
             )
             .add_systems(
                 Update,
@@ -275,7 +286,6 @@ pub fn spawn_fighter(
     animations: FighterAnimations,
     attack_scripts: FighterAttackScriptAssets,
     visual_root: WorldAssetRoot,
-    ecb_bone_indices: Vec<usize>,
 ) -> Entity {
     commands
         .spawn((
@@ -286,14 +296,14 @@ pub fn spawn_fighter(
             Fighter { manifest: manifest },
             FighterFacingDirection::Right,
             FighterPreviousFacingDirection(FighterFacingDirection::Right),
-            FighterSurfaceState::default(),
+            FighterSurfaceState::Airborne,
             Transform::from_scale(Vec3::splat(model_scale.to_num())),
             (
-                FighterECB::default(),
+                FighterECB {
+                    vertical_half: FGi32::lit("5.0"),
+                    horizontal_half: FGi32::lit("2.5"),
+                },
                 FighterHitboxes::default(),
-                FighterECBBoneIndices {
-                    indices: ecb_bone_indices
-                }
             ),
             (
                 FighterVelocity::default(),

src/fighter/motion.rs

@@ -8,7 +8,7 @@ use crate::debug_tools::PresentationMotionMode;
 use crate::fighter::FighterHitstopShake;
 use crate::game_settings::GameSettings;
 use crate::{
-    fighter::{FighterFacingDirection, baked_animation::FixedMat4},
+    fighter::{FighterECB, FighterFacingDirection, baked_animation::FixedMat4},
     math::{int::FGi32, vec::FGVec2, vec3::FGVec3},
 };
 
@@ -56,6 +56,7 @@ pub fn apply_fighter_translation_to_visuals(
     query: Query<(
         &FighterTranslation,
         &FighterPreviousTranslation,
+        &FighterECB,
         &FighterHitstopShake,
         &mut Transform,
     )>,
@@ -64,16 +65,17 @@ pub fn apply_fighter_translation_to_visuals(
     game_settings: Res<GameSettings>,
 ) {
     let overstep_fraction = timing.overstep_fraction();
-    for (translation, previous_translation, hitstop_shake, mut transform) in query {
+    for (translation, previous_translation, ecb, hitstop_shake, mut transform) in query {
         let translation = sample_presentation_translation(
             *previous_translation,
             *translation,
             overstep_fraction,
             debug_settings.motion_sampling,
         );
+        let bottom = ecb.get_bottom_point();
         transform.translation = Vec3::new(
-            translation.x,
-            translation.y,
+            translation.x + bottom.x.to_num::<f32>(),
+            translation.y + bottom.y.to_num::<f32>(),
             0.0,
         );
 

src/fighter/state/air.rs

@@ -83,7 +83,9 @@ pub fn apply_air_motion(
     velocity: &FighterVelocity,
     translation: &mut FighterTranslation,
     prev_translation: &mut FighterPreviousTranslation,
+    surface: &mut FighterSurfaceState,
 ) {
+    surface.leave_ground();
     // Vertical velocity should be 0 on the ground
     prev_translation.0 = translation.0;
     translation.0 += velocity.0;
@@ -109,6 +111,7 @@ pub fn update_standard_motion(
         ctx.velocity,
         ctx.translation,
         ctx.prev_translation,
+        ctx.surface,
     );
 }
 
@@ -117,12 +120,7 @@ pub fn collision_interrupt(
     landing_type: LandingType,
 ) -> Option<FighterState> {
     let res = ctx.air_collide_with_stage()?;
-    let diff = res.hit_position - ctx.translation.0;
-    ctx.ecb.bottom -= diff;
-    ctx.ecb.top -= diff;
-    ctx.ecb.left -= diff;
-    ctx.ecb.right -= diff;
-    ctx.translation.0 = res.hit_position;
+    ctx.translation.0 = res.hit_position - ctx.ecb.get_bottom_point();
     ctx.surface.land(res.line_id);
     Some(FighterState::Land(LandingState::create(landing_type)))
 }

src/fighter/state/air_dodge.rs

@@ -38,6 +38,7 @@ impl FighterStateImpl for AirDodgeState {
             state_context.velocity,
             state_context.translation,
             state_context.prev_translation,
+            state_context.surface,
         );
     }
 
@@ -58,10 +59,6 @@ impl FighterStateImpl for AirDodgeState {
     fn is_visually_grounded<'a>(&'a self) -> bool {
         false
     }
-
-    fn surface_policy(&self) -> super::SurfacePolicy {
-        super::SurfacePolicy::Airborne(crate::fighter::surface::EcbLockPolicy::StartOnDetach)
-    }
 }
 
 pub fn check_input(state_context: &InterruptContext) -> Option<FighterState> {

src/fighter/state/fall.rs

@@ -46,8 +46,5 @@ impl FighterStateImpl for FallState {
     ) -> bool {
         false
     }
-
-    fn surface_policy(&self) -> super::SurfacePolicy {
-        super::SurfacePolicy::Airborne(crate::fighter::surface::EcbLockPolicy::StartOnDetach)
-    }
 }
+

src/fighter/state/ground.rs

@@ -178,7 +178,7 @@ pub fn collide_with_stage_grounded(
     can_walk_off: bool,
 ) -> GroundedMotionResult {
     let translation = &mut state_context.translation;
-    let ecb = &state_context.ecb;
+    let ecb = state_context.ecb;
     let stage_collision = state_context.stage_collision;
 
     let Some(current_line_id) = state_context.surface.line_id() else {
@@ -218,18 +218,12 @@ pub fn collide_with_stage_grounded(
                 GroundedMotionResult::InGround
             }
             GroundedPositionResult::InAir => {
-                state_context.surface.apply_airborne_policy(
-                    crate::fighter::surface::EcbLockPolicy::StartOnDetach,
-                    state_context.leave_ground_ecb_lock_duration,
-                );
+                state_context.surface.leave_ground();
                 GroundedMotionResult::InAir
             }
         }
     } else {
-        state_context.surface.apply_airborne_policy(
-            crate::fighter::surface::EcbLockPolicy::StartOnDetach,
-            state_context.leave_ground_ecb_lock_duration,
-        );
+        state_context.surface.leave_ground();
         GroundedMotionResult::InAir
     }
 }
@@ -369,11 +363,9 @@ mod tests {
         let mut translation = FighterTranslation(FGVec2::lit("11", "0"));
         let previous_translation = FighterPreviousTranslation(translation.0);
         let mut velocity = FighterVelocity::default();
-        let mut ecb = FighterECB {
-            bottom: FGVec2::lit("0.0", "-0.5"),
-            top: FGVec2::lit("0.0", "0.5"),
-            left: FGVec2::lit("-0.5", "0.0"),
-            right: FGVec2::lit("0.5", "0.0"),
+        let ecb = FighterECB {
+            vertical_half: FGi32::ONE,
+            horizontal_half: FGi32::ONE,
         };
         let previous_ecb = FighterPreviousECB::from(ecb);
         let mut context = CollisionContext {
@@ -381,10 +373,9 @@ mod tests {
             prev_translation: &previous_translation,
             velocity: &mut velocity,
             surface: &mut surface,
-            ecb: &mut ecb,
+            ecb: &ecb,
             prev_ecb: &previous_ecb,
             stage_collision: &stage_collision,
-            leave_ground_ecb_lock_duration: 10,
         };
 
         assert!(matches!(
@@ -420,11 +411,9 @@ mod tests {
         let mut translation = FighterTranslation(FGVec2::lit("11", "0"));
         let previous_translation = FighterPreviousTranslation(translation.0);
         let mut velocity = FighterVelocity::default();
-        let mut ecb = FighterECB {
-            bottom: FGVec2::lit("0.0", "-0.5"),
-            top: FGVec2::lit("0.0", "0.5"),
-            left: FGVec2::lit("-0.5", "0.0"),
-            right: FGVec2::lit("0.5", "0.0"),
+        let ecb = FighterECB {
+            vertical_half: FGi32::ONE,
+            horizontal_half: FGi32::ONE,
         };
         let previous_ecb = FighterPreviousECB::from(ecb);
         let mut context = CollisionContext {
@@ -432,17 +421,16 @@ mod tests {
             prev_translation: &previous_translation,
             velocity: &mut velocity,
             surface: &mut surface,
-            ecb: &mut ecb,
+            ecb: &ecb,
             prev_ecb: &previous_ecb,
             stage_collision: &stage_collision,
-            leave_ground_ecb_lock_duration: 10,
         };
 
         assert!(matches!(
             collide_with_stage_grounded(&mut context, true),
             GroundedMotionResult::InAir
         ));
-        assert!(matches!(surface, FighterSurfaceState::Airborne { .. }));
+        assert_eq!(surface, FighterSurfaceState::Airborne);
     }
 }
 

src/fighter/state/hitstun.rs

@@ -83,6 +83,7 @@ impl FighterStateImpl for HitstunState {
         match self.hitstop_kind {
             HitstopStateKind::Grounded => {}
             HitstopStateKind::Airborne => {
+                ctx.surface.leave_ground();
                 air::integrate_gravity(ctx.velocity, ctx.fighter_attributes, false);
             }
         }
@@ -125,13 +126,4 @@ impl FighterStateImpl for HitstunState {
             HitstopStateKind::Airborne => false,
         }
     }
-
-    fn surface_policy(&self) -> super::SurfacePolicy {
-        match self.hitstop_kind {
-            HitstopStateKind::Grounded => super::SurfacePolicy::Grounded,
-            HitstopStateKind::Airborne => super::SurfacePolicy::Airborne(
-                crate::fighter::surface::EcbLockPolicy::StartOnDetach,
-            ),
-        }
-    }
 }

src/fighter/state/jump.rs

@@ -186,16 +186,6 @@ impl FighterStateImpl for JumpState {
     fn is_visually_grounded<'a>(&'a self) -> bool {
         false
     }
-
-    fn surface_policy(&self) -> super::SurfacePolicy {
-        use crate::fighter::surface::EcbLockPolicy;
-        match self.jump_type {
-            JumpType::DoubleJump => super::SurfacePolicy::Airborne(EcbLockPolicy::Restart),
-            JumpType::ShortHop | JumpType::LongJump => {
-                super::SurfacePolicy::Airborne(EcbLockPolicy::StartOnDetach)
-            }
-        }
-    }
 }
 
 pub fn check_input(state_context: &InterruptContext) -> Option<FighterState> {

src/fighter/state/mod.rs

@@ -21,7 +21,6 @@ use crate::fighter::{
     FighterHitstopShake, FighterHitstopShakeKind, FighterHitstopShakeRole,
     FighterPreviousTranslation, FighterSurfaceState, FighterTranslation, FighterVelocity,
 };
-use crate::fighter::surface::EcbLockPolicy;
 use crate::game_settings::GameSettings;
 use crate::input::FighterInput;
 use crate::math::int::FGi32;
@@ -42,12 +41,6 @@ pub mod turn;
 pub mod wait;
 pub mod walk;
 
-#[derive(Clone, Copy, Debug, Hash, PartialEq, Eq)]
-pub enum SurfacePolicy {
-    Grounded,
-    Airborne(EcbLockPolicy),
-}
-
 macro_rules! fighter_states {
     ($($variant:ident => $ty:ty),* $(,)?) => {
         #[derive(Component, Clone, Debug, Hash)]
@@ -79,10 +72,6 @@ macro_rules! fighter_states {
             pub fn is_visually_grounded(&self) -> bool {
                 match self { $(Self::$variant(s) => s.is_visually_grounded()),* }
             }
-
-            pub fn surface_policy(&self) -> SurfacePolicy {
-                match self { $(Self::$variant(s) => s.surface_policy()),* }
-            }
         }
 
         $(impl From<$ty> for FighterState {
@@ -110,10 +99,6 @@ pub trait FighterStateImpl: Sized {
     }
 
     fn is_visually_grounded<'a>(&'a self) -> bool;
-
-    fn surface_policy(&self) -> SurfacePolicy {
-        SurfacePolicy::Grounded
-    }
 }
 
 pub struct AnimationStatus {
@@ -188,10 +173,9 @@ pub struct CollisionContext<'a> {
     pub prev_translation: &'a FighterPreviousTranslation,
     pub velocity: &'a mut FighterVelocity,
     pub surface: &'a mut FighterSurfaceState,
-    pub ecb: &'a mut FighterECB,
+    pub ecb: &'a FighterECB,
     pub prev_ecb: &'a FighterPreviousECB,
     pub stage_collision: &'a StageCollision,
-    pub leave_ground_ecb_lock_duration: u32,
 }
 
 impl CollisionContext<'_> {
@@ -234,7 +218,7 @@ pub struct FighterFrameQuery {
     pub surface: &'static mut FighterSurfaceState,
     pub knockback_velocity: &'static mut FighterKnockbackVelocity,
     pub stale_move_queue: &'static mut FighterStaleMoveQueue,
-    pub ecb: &'static mut FighterECB,
+    pub ecb: &'static FighterECB,
     pub prev_ecb: &'static FighterPreviousECB,
     pub facing_direction: &'static mut FighterFacingDirection,
     pub animation_frame: &'static mut FighterAnimationFrame,
@@ -326,17 +310,15 @@ impl<'w, 's> FighterFrameQueryItem<'w, 's> {
     fn collision_context<'a>(
         &'a mut self,
         stage_collision: &'a StageCollision,
-        game_settings: &'a GameSettings,
     ) -> CollisionContext<'a> {
         CollisionContext {
             translation: &mut self.translation,
             prev_translation: &self.prev_translation,
             velocity: &mut self.velocity,
             surface: &mut self.surface,
-            ecb: &mut self.ecb,
+            ecb: &self.ecb,
             prev_ecb: &self.prev_ecb,
             stage_collision,
-            leave_ground_ecb_lock_duration: game_settings.fighter_common.leave_ground_ecb_frame_lock_duration
         }
     }
 }
@@ -391,18 +373,11 @@ fn transition_state(
     frame: &mut FighterFrameQueryItem,
     attributes: &FighterAttributes,
     attack_script_assets: &FighterAttackScriptAssets,
-    game_settings: &GameSettings,
 ) {
     let old_name = current.name();
     let new_name = next.name();
 
     current.on_exit(&mut frame.exit_context());
-    if let SurfacePolicy::Airborne(lock_policy) = next.surface_policy() {
-        frame.surface.apply_airborne_policy(
-            lock_policy,
-            game_settings.fighter_common.leave_ground_ecb_frame_lock_duration,
-        );
-    }
     next.on_enter(&mut frame.enter_context(attributes, attack_script_assets));
     *current = next;
     info!("{} -> {}", old_name, new_name);
@@ -473,6 +448,10 @@ pub fn state_interrupt_system(
                 }
             }
 
+            if matches!(hitstop_kind, hitstun::HitstopStateKind::Airborne) {
+                frame.surface.leave_ground();
+            }
+
             info!("Entering hitstop kind: {:?}", hitstop_kind);
             Some(FighterState::Hitstun(HitstunState::new(
                 reaction,
@@ -496,7 +475,6 @@ pub fn state_interrupt_system(
                 &mut frame,
                 &manifest.attributes,
                 attack_script_assets,
-                &game_settings,
             );
         };
     }
@@ -506,7 +484,6 @@ pub fn state_collision_interrupt_system(
     mut query: Query<StatefulFighterQuery>,
     stage_collision: Res<StageCollision>,
     fighter_manifests: Res<Assets<FighterManifest>>,
-    game_settings: Res<GameSettings>,
 ) {
     for fighter in &mut query {
         let StatefulFighterQueryItem {
@@ -525,7 +502,7 @@ pub fn state_collision_interrupt_system(
             .get(&fighter.manifest)
             .expect("Fighter manifest should be valid");
         let new_state =
-            state.check_collision_interrupt(&mut frame.collision_context(&stage_collision, &game_settings));
+            state.check_collision_interrupt(&mut frame.collision_context(&stage_collision));
         if let Some(new_state) = new_state {
             transition_state(
                 &mut state,
@@ -533,7 +510,6 @@ pub fn state_collision_interrupt_system(
                 &mut frame,
                 &manifest.attributes,
                 &attack_script_assets,
-                &game_settings,
             );
         }
     }

src/fighter/surface.rs

@@ -1,38 +1,21 @@
 use bevy::prelude::*;
 
-use crate::{stage::line::StageLineID};
-
-#[derive(Clone, Copy, Debug, Hash, PartialEq, Eq)]
-pub enum EcbLockPolicy {
-    StartOnDetach,
-    Restart,
-    Preserve,
-    Clear,
-}
+use crate::stage::line::StageLineID;
 
 /// The stage surface currently supporting a fighter.
 ///
 /// This is physics state rather than fighter-state-machine state. Keeping it
 /// separate means grounded, landing, and hitstun states all share one source
 /// of truth for stage contact.
-#[derive(Component, Clone, Copy, Debug, Hash, PartialEq, Eq)]
+#[derive(Component, Clone, Copy, Debug, Default, Hash, PartialEq, Eq)]
 pub enum FighterSurfaceState {
-    Airborne {
-        ecb_lock_frames_remaining: u32
-    },
+    #[default]
+    Airborne,
     Grounded {
         line_id: StageLineID,
     },
 }
 
-impl Default for FighterSurfaceState {
-    fn default() -> Self {
-        Self::Airborne {
-            ecb_lock_frames_remaining: 0
-        }
-    }
-}
-
 impl FighterSurfaceState {
     pub fn is_grounded(self) -> bool {
         matches!(self, Self::Grounded { .. })
@@ -40,7 +23,7 @@ impl FighterSurfaceState {
 
     pub fn line_id(self) -> Option<StageLineID> {
         match self {
-            Self::Airborne { .. } => None,
+            Self::Airborne => None,
             Self::Grounded { line_id } => Some(line_id),
         }
     }
@@ -49,29 +32,8 @@ impl FighterSurfaceState {
         *self = Self::Grounded { line_id };
     }
 
-    pub(crate) fn apply_airborne_policy(
-        &mut self,
-        policy: EcbLockPolicy,
-        ecb_lock_duration: u32,
-    ) {
-        let current_lock = match *self {
-            Self::Airborne { ecb_lock_frames_remaining } => ecb_lock_frames_remaining,
-            Self::Grounded { .. } => 0,
-        };
-        let ecb_lock_frames_remaining = match policy {
-            EcbLockPolicy::StartOnDetach if self.is_grounded() => ecb_lock_duration,
-            EcbLockPolicy::StartOnDetach => current_lock,
-            EcbLockPolicy::Restart => ecb_lock_duration,
-            EcbLockPolicy::Preserve => current_lock,
-            EcbLockPolicy::Clear => 0,
-        };
-        *self = Self::Airborne { ecb_lock_frames_remaining };
-    }
-
-    pub(crate) fn tick_ecb_lock(&mut self) {
-        if let Self::Airborne { ecb_lock_frames_remaining } = self {
-            *ecb_lock_frames_remaining = ecb_lock_frames_remaining.saturating_sub(1);
-        }
+    pub(crate) fn leave_ground(&mut self) {
+        *self = Self::Airborne;
     }
 }
 
@@ -93,38 +55,8 @@ mod tests {
         assert!(surface.is_grounded());
         assert_eq!(surface.line_id(), Some(line_id));
 
-        surface.apply_airborne_policy(EcbLockPolicy::Clear, 0);
+        surface.leave_ground();
         assert!(!surface.is_grounded());
         assert_eq!(surface.line_id(), None);
     }
-
-    #[test]
-    fn start_on_detach_does_not_reset_an_existing_lock() {
-        let mut surface = FighterSurfaceState::default();
-        surface.apply_airborne_policy(EcbLockPolicy::Restart, 5);
-        surface.tick_ecb_lock();
-        surface.apply_airborne_policy(EcbLockPolicy::StartOnDetach, 5);
-
-        assert_eq!(
-            surface,
-            FighterSurfaceState::Airborne {
-                ecb_lock_frames_remaining: 4,
-            }
-        );
-    }
-
-    #[test]
-    fn restart_retriggers_an_existing_lock() {
-        let mut surface = FighterSurfaceState::default();
-        surface.apply_airborne_policy(EcbLockPolicy::Restart, 5);
-        surface.tick_ecb_lock();
-        surface.apply_airborne_policy(EcbLockPolicy::Restart, 5);
-
-        assert_eq!(
-            surface,
-            FighterSurfaceState::Airborne {
-                ecb_lock_frames_remaining: 5,
-            }
-        );
-    }
 }

src/game_settings.rs

@@ -39,7 +39,6 @@ pub struct FighterSettingsCommon {
     
     /// Maximum angle changed caused by directional influence
     pub di_max_angle: FGi32,
-    pub leave_ground_ecb_frame_lock_duration: u32
 }
 #[derive(Reflect, Serialize, Deserialize, Clone)]
 #[reflect(opaque)]

src/match_loading.rs

@@ -336,15 +336,6 @@ pub fn prepare_match(
             );
             return;
         }
-
-        let ecb_bone_indices = baked.bone_names.iter().enumerate().filter_map(|(idx, name)| {
-            if manifest.ecb_bones.contains(name) {
-                Some(idx)
-            } else {
-                None
-            }
-        }).collect::<Vec<_>>();
-
         if let Err(error) = manifest.attributes.validate() {
             fail_match(
                 &mut next_state,
@@ -445,7 +436,6 @@ pub fn prepare_match(
             attack_scripts,
             manifest_handle,
             manifest.model_scale,
-            ecb_bone_indices,
         ));
     }
 
@@ -487,7 +477,7 @@ pub fn prepare_match(
     );
 
     let mut fighter_roster = Vec::with_capacity(config.players.len());
-    for (index, (player, (scene, animations, attack_scripts, manifest_handle, model_scale, ecb_bone_indices))) in
+    for (index, (player, (scene, animations, attack_scripts, manifest_handle, model_scale))) in
         config.players.iter().zip(prepared).enumerate()
     {
         let spawn_x = (index as i32 * 2 + 1 - config.players.len() as i32) * 5;
@@ -500,7 +490,6 @@ pub fn prepare_match(
             animations,
             attack_scripts,
             WorldAssetRoot(scene),
-            ecb_bone_indices
         ));
     }
 

src/math/vec.rs

@@ -2,7 +2,7 @@ use bevy::math::Vec2;
 use bevy::prelude::*;
 use fixed::types::I32F32;
 use serde::{Deserialize, Serialize};
-use std::ops::{Add, AddAssign, Div, Mul, MulAssign, Sub, SubAssign};
+use std::ops::{Add, AddAssign, Div, Mul, MulAssign, Sub};
 
 use super::int::{FGWide, FGi32};
 
@@ -227,15 +227,6 @@ impl AddAssign for FGVec2 {
     }
 }
 
-impl SubAssign for FGVec2 {
-    fn sub_assign(&mut self, rhs: Self) {
-        *self = Self {
-            x: self.x - rhs.x,
-            y: self.y - rhs.y,
-        }
-    }
-}
-
 impl MulAssign for FGVec2 {
     fn mul_assign(&mut self, rhs: Self) {
         *self = Self {