Prevent shipped smash attacks from panicking #7

Open
opened 2026-09-15 16:42:52 +00:00 by EIREXE · 0 comments
Owner

Severity: Critical\n\nGroundAttackState indexes the attack script map directly at src/fighter/state/ground_attack.rs:30 and :47. The shipped fighter manifest defines no UpSmash, DownSmash, or ForwardSmash scripts (assets/fighters/test/test.fighter.ron:75-81), while input buffering can produce those attack kinds (src/input/buffer.rs:41-52). Pressing a smash input can terminate the game.\n\nFix: validate every reachable attack script during match preparation and replace direct map indexing with controlled fallible handling.

Severity: Critical\n\nGroundAttackState indexes the attack script map directly at src/fighter/state/ground_attack.rs:30 and :47. The shipped fighter manifest defines no UpSmash, DownSmash, or ForwardSmash scripts (assets/fighters/test/test.fighter.ron:75-81), while input buffering can produce those attack kinds (src/input/buffer.rs:41-52). Pressing a smash input can terminate the game.\n\nFix: validate every reachable attack script during match preparation and replace direct map indexing with controlled fallible handling.
Sign in to join this conversation.
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: EIREXE/shinespark#7