Validate all authored gameplay and animation data #28

Open
opened 2026-09-15 16:42:57 +00:00 by EIREXE · 0 comments
Owner

Severity: Reliability\n\nFighterAttributes::validate checks only positive weight (src/fighter/attributes.rs:48-54). Stage geometry is not checked for coincident points before normal calculation, and baked animation data lacks validation for parent bounds/cycles, pose lengths, and empty clips before assertions in src/fighter/baked_animation.rs:307-350. Several declared tuning fields are unused.\n\nFix: add centralized range/invariant validation before match start, make stage/animation preparation fallible, and implement or remove unused fields.

Severity: Reliability\n\nFighterAttributes::validate checks only positive weight (src/fighter/attributes.rs:48-54). Stage geometry is not checked for coincident points before normal calculation, and baked animation data lacks validation for parent bounds/cycles, pose lengths, and empty clips before assertions in src/fighter/baked_animation.rs:307-350. Several declared tuning fields are unused.\n\nFix: add centralized range/invariant validation before match start, make stage/animation preparation fallible, and implement or remove unused fields.
Sign in to join this conversation.
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: EIREXE/shinespark#28