Replace positional attack tuples with named types #27

Closed
opened 2026-09-15 16:42:57 +00:00 by EIREXE · 1 comment
Owner

Severity: Architecture

FighterReceivedAttacks stores a positional tuple of Entity, script handle, AttackKind, and hitbox index at src/fighter/attack.rs:435-443. It is destructured and transformed into another tuple during resolution at lines 592-665.

Fix: introduce named ReceivedAttack and ResolvedHit structures with validated hitbox identity and stable attacker IDs.

Severity: Architecture FighterReceivedAttacks stores a positional tuple of Entity, script handle, AttackKind, and hitbox index at src/fighter/attack.rs:435-443. It is destructured and transformed into another tuple during resolution at lines 592-665. Fix: introduce named ReceivedAttack and ResolvedHit structures with validated hitbox identity and stable attacker IDs.
Author
Owner

Fixed in 43ee6d8153

Fixed in [43ee6d8153](https://git.eirexe.moe/EIREXE/shinespark/commit/43ee6d8153aeecff3537c0ba14aa3556618852f5)
Sign in to join this conversation.
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: EIREXE/shinespark#27