Harden replay loading and preserve failed recordings #26

Open
opened 2026-09-15 16:42:57 +00:00 by EIREXE · 0 comments
Owner

Severity: Reliability\n\nReplay loading reads and deserializes an unrestricted file at src/replay.rs:105-120. Malformed large files can consume excessive memory/CPU. Save errors are logged at lines 323-325, but recording data is still marked finished and removed at lines 326-327.\n\nFix: impose file/count limits, use bounded deserialization, validate frame/checksum ordering, and retain recording state for retry after save failure.

Severity: Reliability\n\nReplay loading reads and deserializes an unrestricted file at src/replay.rs:105-120. Malformed large files can consume excessive memory/CPU. Save errors are logged at lines 323-325, but recording data is still marked finished and removed at lines 326-327.\n\nFix: impose file/count limits, use bounded deserialization, validate frame/checksum ordering, and retain recording state for retry after save failure.
Sign in to join this conversation.
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: EIREXE/shinespark#26