Separate attack data, collision, and reaction resolution #21

Closed
opened 2026-09-15 16:42:57 +00:00 by EIREXE · 0 comments
Owner

Severity: Architecture

src/fighter/attack.rs combines attack value types, hitbox activation, geometry solving, pairwise detection, damage/knockback resolution, and scheduling. calculate_received_attacks_trajectories spans lines 567-688 and mixes entity lookup, staling, damage, hitstop, and priority.

Fix: make collision emit named typed hit events and process combat reactions in a separate system/module.

Severity: Architecture src/fighter/attack.rs combines attack value types, hitbox activation, geometry solving, pairwise detection, damage/knockback resolution, and scheduling. calculate_received_attacks_trajectories spans lines 567-688 and mixes entity lookup, staling, damage, hitstop, and priority. Fix: make collision emit named typed hit events and process combat reactions in a separate system/module.
Sign in to join this conversation.
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: EIREXE/shinespark#21