Shut up warnings

.gitea/workflows/ci.yml

@@ -50,78 +50,3 @@ jobs:
 
       - name: Run unit tests
         run: cargo test --locked --lib -j 4
-
-  production-build:
-    runs-on: ubuntu-latest
-    timeout-minutes: 45
-    steps:
-      - name: Check out source
-        uses: actions/checkout@v4
-
-      - name: Install Rust toolchain
-        run: |
-          curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | \
-            sh -s -- -y --profile minimal
-          echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"
-          "$HOME/.cargo/bin/rustup" toolchain install nightly-2026-09-14 --profile minimal
-
-      - name: Cache production Rust dependencies and build artifacts
-        uses: Swatinem/rust-cache@6323deb102c322ba6fcbdcafc7e3dddab59af2b6 # v2.9.2
-        with:
-          prefix-key: v2-rust
-          shared-key: linux-nightly-production
-          cache-bin: false
-
-      - name: Install Linux dependencies
-        run: |
-          sudo apt-get update
-          sudo apt-get install --no-install-recommends -y \
-            clang \
-            libasound2-dev \
-            libudev-dev \
-            libusb-1.0-0-dev \
-            libwayland-dev \
-            libx11-dev \
-            libxkbcommon-dev \
-            libxkbcommon-x11-0 \
-            mesa-vulkan-drivers \
-            mold \
-            pkg-config
-
-      - name: Preprocess assets
-        run: cargo run --locked --bin process-assets --no-default-features --features debug_features -j 4
-
-      - name: Build production binary
-        run: cargo build --locked --profile production --no-default-features --features debug_features -j 4
-
-      - name: Verify production binary is not Bevy/Rust dynamically linked
-        run: |
-          ! readelf -d target/production/shinespark | grep -E 'libbevy_dylib|libstd-.*\.so'
-
-      - name: Package Linux Steam depot
-        if: github.event_name == 'push' && github.ref == 'refs/heads/master'
-        run: |
-          mkdir -p build/linux
-          cp target/production/shinespark build/linux/shinespark
-          cp -R assets build/linux/assets
-          cp -R imported_assets build/linux/imported_assets
-
-      - if: github.event_name == 'push' && github.ref == 'refs/heads/master'
-        uses: CyberAndrii/steam-totp@v1
-        name: Generate Steam TOTP
-        id: steam-totp
-        with:
-          shared_secret: ${{ secrets.STEAM_SHARED_SECRET }}
-
-      - name: Deploy Linux build to Steam
-        if: github.event_name == 'push' && github.ref == 'refs/heads/master'
-        uses: game-ci/steam-deploy@v3
-        with:
-          username: ${{ secrets.STEAM_USERNAME }}
-          password: ${{ secrets.STEAM_PASSWORD }}
-          totp: ${{ steps.steam-totp.outputs.code }}
-          appId: 3409670
-          buildDescription: ${{ github.sha }}
-          rootPath: build
-          depot1Path: linux
-          releaseBranch: master

Cargo.toml

@@ -6,13 +6,8 @@ authors = [""]
 
 [workspace]
 
-[features]
-default = ["development", "debug_features"]
-development = ["bevy/dynamic_linking", "bevy/file_watcher"]
-debug_features = ["bevy/free_camera"]
-
 [dependencies]
-bevy = { version = "0.19", features = ["asset_processor", "basis-universal", "bevy_settings"] }
+bevy = { version = "0.19", features = ["asset_processor", "basis-universal", "dynamic_linking", "free_camera", "file_watcher", "bevy_settings"] }
 # Loads the scenes you author in the editor (assets/*.bsn) and builds
 # physics colliders from them. An ordinary dependency; remove it if you
 # stop using authored scenes.
@@ -42,9 +37,3 @@ fixed_math = "0.4.1"
 # Enable a large amount of optimization in the dev profile for dependencies.
 [profile.dev.package."*"]
 opt-level = 3
-
-[profile.production]
-inherits = "release"
-lto = "thin"
-codegen-units = 1
-strip = "symbols"

README.md

@@ -13,21 +13,3 @@ cargo run -- --debug-match --players 2 --local-port 7000 \
 cargo run -- --debug-match --players 2 --local-port 7001 \
   --net-player 0=127.0.0.1:7000 --net-player 1=local
 ```
-
-## Production Build
-
-Production builds use the `production` Cargo profile and do not dynamically
-link Bevy or Rust. Development builds retain Bevy dynamic linking for faster
-iteration. Cargo stores the production profile under `target/production`,
-separate from development artifacts under `target/debug`.
-
-```sh
-cargo run --locked \
-  --bin process-assets --no-default-features --features debug_features
-cargo build --locked \
-  --profile production --no-default-features --features debug_features
-```
-
-The asset preprocessing command must be run from the repository root. It
-populates `imported_assets/Default`, which is then consumed by the production
-game without running the asset processor at startup.

src/bin/process-assets.rs

@@ -1,35 +0,0 @@
-use bevy::{
-    app::ScheduleRunnerPlugin,
-    asset::{AssetMode, AssetPlugin, processor::AssetProcessor, processor::ProcessorState},
-    gltf::GltfPlugin,
-    image::ImagePlugin,
-    prelude::*,
-    tasks::block_on,
-    text::TextPlugin,
-};
-use shinespark::AssetProcessingPlugin;
-use std::{process::ExitCode, time::Duration};
-
-fn main() -> ExitCode {
-    let mut app = App::new();
-    app.add_plugins(MinimalPlugins.set(ScheduleRunnerPlugin::run_loop(Duration::from_millis(50))))
-        .add_plugins(AssetPlugin {
-            mode: AssetMode::Processed,
-            use_asset_processor_override: Some(true),
-            ..default()
-        })
-        .add_plugins((ImagePlugin::default(), TextPlugin, GltfPlugin::default()))
-        .add_plugins(AssetProcessingPlugin)
-        .add_systems(Update, finish_when_processed);
-
-    app.run();
-    ExitCode::SUCCESS
-}
-
-fn finish_when_processed(processor: Option<Res<AssetProcessor>>, mut exit: MessageWriter<AppExit>) {
-    if processor
-        .is_some_and(|processor| block_on(processor.get_state()) == ProcessorState::Finished)
-    {
-        exit.write(AppExit::Success);
-    }
-}

src/fighter/baked_animation/asset_baking.rs

@@ -151,10 +151,7 @@ type FighterBakeProcessor = LoadTransformAndSave<
 >;
 
 pub struct BakedAnimationPlugin;
-
+impl Plugin for BakedAnimationPlugin {
-pub struct BakedAnimationAssetProcessingPlugin;
-
-impl Plugin for BakedAnimationAssetProcessingPlugin {
     fn build(&self, app: &mut App) {
         app.init_asset::<BakedFighterAnimations>()
             .register_asset_loader(FighterBakeSourceLoader)
@@ -163,13 +160,7 @@ impl Plugin for BakedAnimationAssetProcessingPlugin {
                 FighterBakeTransformer,
                 BakedFighterAnimationsSaver,
             ))
-            .set_default_asset_processor::<FighterBakeProcessor>("fighterbake");
+            .set_default_asset_processor::<FighterBakeProcessor>("fighterbake")
-    }
-}
-
-impl Plugin for BakedAnimationPlugin {
-    fn build(&self, app: &mut App) {
-        app.add_plugins(BakedAnimationAssetProcessingPlugin)
             .add_systems(
                 bevy_ggrs::prelude::GgrsSchedule,
                 super::runtime::update_fighter_bone_matrices

src/fighter/baked_animation/mod.rs

@@ -4,7 +4,7 @@ mod asset_baking;
 mod runtime;
 mod visual_binding;
 
-pub use asset_baking::{BakedAnimationAssetProcessingPlugin, BakedAnimationPlugin};
+pub use asset_baking::BakedAnimationPlugin;
 pub use crate::math::fixed_transform::FixedMat4;
 pub use runtime::{
     BakedAnimationClip, BakedFighterAnimations, FighterBoneIndexMap, FighterBoneMatrices,

src/lib.rs

@@ -32,13 +32,7 @@ use clap::Parser;
 use ron_asset_manager::RonAssetPlugin;
 
 use crate::{
-    camera::MatchCameraPlugin,
+    camera::MatchCameraPlugin, fighter::manifest::FighterManifest, game_settings::GameSettings, schedule::GameplaySchedulePlugin, stage::manifest::StageManifest, ui::InGameUIPlugin,
-    fighter::manifest::FighterManifest,
-    game_settings::GameSettings,
-    menus::style::FGUiStyle,
-    schedule::GameplaySchedulePlugin,
-    stage::manifest::StageManifest,
-    ui::InGameUIPlugin,
 };
 
 mod args;
@@ -86,20 +80,6 @@ pub enum AppState {
 #[derive(Default)]
 pub struct GamePlugin;
 
-/// Registers every custom asset loader used by the game and asset processor.
-pub struct GameAssetPlugin;
-
-impl Plugin for GameAssetPlugin {
-    fn build(&self, app: &mut App) {
-        app.add_plugins((
-            RonAssetPlugin::<FighterManifest>::create("fighter.ron"),
-            RonAssetPlugin::<StageManifest>::create("stage.ron"),
-            RonAssetPlugin::<GameSettings>::create("ron"),
-            RonAssetPlugin::<FGUiStyle>::create("stylesheet.ron"),
-        ));
-    }
-}
-
 impl Plugin for GamePlugin {
     fn build(&self, app: &mut App) {
         // Each module owns its own systems, rollback registrations and
@@ -119,7 +99,9 @@ impl Plugin for GamePlugin {
                 scripting::importer::FighterScriptImportPlugin,
                 stage::StagePlugin,
                 MatchCameraPlugin,
-                GameAssetPlugin,
+                RonAssetPlugin::<FighterManifest>::create("fighter.ron"),
+                RonAssetPlugin::<StageManifest>::create("stage.ron"),
+                RonAssetPlugin::<GameSettings>::create("ron"),
                 InGameUIPlugin,
             ))
             .add_plugins(menus::MenuPlugin)
@@ -173,27 +155,11 @@ impl Plugin for GamePlugin {
     }
 }
 
-/// Registers the custom asset loaders and processors used by CI and release
-/// builds. The processing binary adds this plugin without starting the game.
-pub struct AssetProcessingPlugin;
-
-impl Plugin for AssetProcessingPlugin {
-    fn build(&self, app: &mut App) {
-        app.add_plugins((
-            GameAssetPlugin,
-            scripting::importer::FighterScriptImportPlugin,
-            fighter::baked_animation::BakedAnimationAssetProcessingPlugin,
-        ));
-    }
-}
-
 fn wait_for_asset_processor(
     processor: Option<Res<AssetProcessor>>,
     mut next_state: ResMut<NextState<AppState>>,
 ) {
-    if !cfg!(feature = "development")
+    if processor.is_none_or(|processor| block_on(processor.get_state()) == ProcessorState::Finished)
-        || processor
-            .is_none_or(|processor| block_on(processor.get_state()) == ProcessorState::Finished)
     {
         next_state.set(AppState::LoadCommonAssets);
     }

src/main.rs

@@ -1,11 +1,8 @@
 use bevy::asset::AssetMode::Processed;
-#[cfg(feature = "debug_features")]
 use bevy::camera_controller::free_camera::FreeCameraPlugin;
 use bevy::image::{ImageAddressMode, ImagePlugin, ImageSamplerDescriptor};
 use bevy::prelude::*;
-#[cfg(feature = "debug_features")]
 use bevy_egui::EguiPlugin;
-#[cfg(feature = "debug_features")]
 use bevy_inspector_egui::quick::WorldInspectorPlugin;
 
 fn main() -> AppExit {
@@ -23,22 +20,16 @@ fn main() -> AppExit {
         })
         .set(AssetPlugin {
             mode: Processed,
-            use_asset_processor_override: Some(cfg!(feature = "development")),
             ..default()
         });
 
-    let mut app = App::new();
+    App::new()
-    app.add_plugins(default_plugins)
+        .add_plugins(default_plugins)
         .add_plugins(avian3d::prelude::PhysicsPlugins::default())
         .add_plugins(shinespark::GamePlugin)
-        .insert_resource(Time::<Fixed>::from_hz(60.0));
+        .add_plugins(FreeCameraPlugin)
-
+        .add_plugins(EguiPlugin::default())
-    #[cfg(feature = "debug_features")]
+        .add_plugins(WorldInspectorPlugin::default()) // adds default options and `InspectorEguiImpl`s
-    app.add_plugins((
+        .insert_resource(Time::<Fixed>::from_hz(60.0))
-        FreeCameraPlugin,
+        .run()
-        EguiPlugin::default(),
-        WorldInspectorPlugin::default(),
-    ));
-
-    app.run()
 }

src/menus/mod.rs

@@ -6,10 +6,12 @@ use bevy::{
     prelude::*,
 };
 
+use ron_asset_manager::RonAssetPlugin;
+
 use crate::{
     AppState,
     game_settings::CommonAssets,
-    menus::{character_select::CharacterSelectScreen, main_menu::MainMenu},
+    menus::{character_select::CharacterSelectScreen, main_menu::MainMenu, style::FGUiStyle},
 };
 pub mod button;
 pub mod character_select;
@@ -220,6 +222,7 @@ impl Plugin for MenuPlugin {
         //---------
         // STAGE SELECT END
         //---------
+        .add_plugins(RonAssetPlugin::<FGUiStyle>::create("stylesheet.ron"))
         .add_systems(
             Update,
             (