Compare commits

..
Author SHA1 Message Date
EIREXE 04f6f2386f LinoSpec (tm) fix
CI / build-and-test (pull_request) Successful in 1m48s
CI / production-build (pull_request) Successful in 10m22s
2026-09-26 12:02:01 +02:00
EIREXE 84e07a80aa Implement being able to drop through soft platforms
CI / production-build (pull_request) Successful in 10m16s
CI / build-and-test (pull_request) Successful in 1m31s
2026-09-26 01:27:00 +02:00
EIREXE 66a817cd05 Add mechanism to ignore platforms (#63)
CI / build-and-test (push) Successful in 1m30s
CI / production-build (push) Successful in 10m48s
Reviewed-on: #63
Co-authored-by: Álex Román Núñez <eirexe@eirteam.moe>
2026-09-25 21:43:49 +00:00
EIREXE 946bbc4cbd Implement crouching (#62)
CI / build-and-test (push) Successful in 1m29s
CI / production-build (push) Successful in 10m48s
Reviewed-on: #62
Co-authored-by: Álex Román Núñez <eirexe@eirteam.moe>
2026-09-25 18:14:09 +00:00
EIREXE b56b7b0421 Merge pull request 'Add shifting ECB based on bone positions (melee-like)' (#61) from ecb into master
CI / build-and-test (push) Successful in 1m32s
CI / production-build (push) Successful in 11m4s
Reviewed-on: #61
2026-09-25 14:42:54 +00:00
EIREXE 84e731fbc8 Fix various runtime shenanigans
CI / build-and-test (pull_request) Successful in 1m32s
CI / production-build (pull_request) Successful in 10m22s
2026-09-25 16:29:11 +02:00
EIREXE 65727ed04f Remove gizmo shenanigans 2026-09-25 16:00:21 +02:00
EIREXE 0cb81ec2e9 Add shifting ECB based on bone positions (melee-like)
CI / build-and-test (pull_request) Successful in 1m33s
CI / production-build (pull_request) Successful in 10m48s
2026-09-25 15:45:55 +02:00
EIREXE d521461625 Add authoritative fighter surface state (#60)
CI / build-and-test (push) Successful in 1m28s
CI / production-build (push) Successful in 11m59s
## Summary
- add a rollback-tracked `FighterSurfaceState` as the single source of truth for stage contact
- move active stage line ownership out of individual grounded fighter states
- update landing, airborne motion, ledge departure, hit reactions, and debug save states to maintain surface contact
- add tests for contact lifecycle, connected-segment traversal, and ledge departure

Reviewed-on: #60
Co-authored-by: Álex Román Núñez <eirexe@eirteam.moe>
2026-09-25 10:45:27 +00:00
EIREXE 3daf8f2e21 Fix GameCube poll thread shutdown and error backoff (#55)
CI / build-and-test (push) Successful in 1m42s
CI / production-build (push) Successful in 10m57s
## Summary
- signal GameCube poll thread shutdown unconditionally when the snapshot is dropped
- retain and join the poll thread during resource cleanup
- add bounded, shutdown-aware backoff for recoverable parse and short-read errors
- add unit coverage for backoff capping and shutdown-aware waits

Fixes #25

Reviewed-on: #55
Co-authored-by: Álex Román Núñez <eirexe@eirteam.moe>
2026-09-25 08:04:35 +00:00
EIREXE aea1cf35ff Merge pull request 'Fix debug UI not working at all' (#59) from ui_fix into master
CI / build-and-test (push) Successful in 1m37s
CI / production-build (push) Successful in 10m55s
Reviewed-on: #59
2026-09-24 20:56:45 +00:00
EIREXE 2e06cbb4b7 Fix debug UI not working at all
CI / build-and-test (pull_request) Successful in 1m30s
CI / production-build (pull_request) Successful in 10m51s
2026-09-24 22:29:34 +02:00
EIREXE 9a3a1383ff Pin Blender for CI asset processing (#58)
CI / production-build (push) Successful in 13m8s
CI / build-and-test (push) Successful in 1m31s
Reviewed-on: #58
Co-authored-by: Álex Román Núñez <eirexe@eirteam.moe>
2026-09-24 14:45:37 +00:00
EIREXE 1ba29b817b Implement .blend asset processor (#56)
CI / build-and-test (push) Successful in 1m51s
CI / production-build (push) Successful in 12m11s
Reviewed-on: #56
Co-authored-by: Álex Román Núñez <eirexe@eirteam.moe>
2026-09-24 10:47:19 +00:00
EIREXE 2874d496ee Integrate lore CI (#57)
CI / build-and-test (push) Canceled after 0s
CI / production-build (push) Canceled after 0s
Reviewed-on: #57
Co-authored-by: Álex Román Núñez <eirexe@eirteam.moe>
2026-09-24 10:30:02 +00:00
EIREXE f7bb8cc345 Remove UI multi cam setup (#54)
CI / build-and-test (push) Successful in 1m19s
CI / production-build (push) Successful in 9m38s
Reviewed-on: #54
Co-authored-by: Álex Román Núñez <eirexe@eirteam.moe>
2026-09-20 17:34:11 +00:00
EIREXE 85236c4e0f Optimize rollback hot paths (#53)
CI / build-and-test (push) Successful in 1m16s
CI / production-build (push) Successful in 9m36s
## Summary

Fixes #20.

- Reuse fighter animation scratch and output buffers across rollback frames.
- Select air-collision hits in one pass without candidate allocations or sorting.
- Index contiguous replay input frames directly and binary-search checksums.
- Add regression tests for buffer reuse and replay lookup/validation.

Reviewed-on: #53
Co-authored-by: Álex Román Núñez <eirexe@eirteam.moe>
2026-09-20 12:41:13 +00:00
EIREXE bcf1e114ef Add script to debug fixed point numbers in lldb
CI / build-and-test (push) Successful in 1m33s
CI / production-build (push) Successful in 9m46s
2026-09-20 13:35:43 +02:00
EIREXE 15f07edaaf Add stocks UI (#52)
CI / build-and-test (push) Successful in 1m16s
CI / production-build (push) Successful in 9m38s
Reviewed-on: #52
Co-authored-by: Álex Román Núñez <eirexe@eirteam.moe>
2026-09-20 11:34:45 +00:00
EIREXE 1276562890 Rename pending match to match config and add match state (#51)
CI / build-and-test (push) Successful in 1m17s
CI / production-build (push) Successful in 9m37s
Reviewed-on: #51
Co-authored-by: Álex Román Núñez <eirexe@eirteam.moe>
2026-09-20 11:13:15 +00:00
EIREXE 769d82573a Build Windows executable in shared Steam depot (#50)
CI / build-and-test (push) Successful in 1m20s
CI / production-build (push) Successful in 9m36s
## Summary
- install the nightly Windows MSVC target and cargo-xwin in CI
- build the production Windows executable alongside Linux
- package both executables and only imported_assets in one Steam depot

Reviewed-on: #50
Co-authored-by: Álex Román Núñez <eirexe@eirteam.moe>
2026-09-19 21:40:15 +00:00
EIREXE 9ba8697d57 Include missing battlefield icon
CI / build-and-test (push) Successful in 1m10s
CI / production-build (push) Successful in 5m5s
2026-09-19 21:54:33 +02:00
EIREXE 7d9b6aeafc Fix headless asset preprocessing hang (#49)
CI / build-and-test (push) Successful in 1m9s
CI / production-build (push) Successful in 5m23s
## Summary
- register Bevy's image loader explicitly in the headless asset processor
- use no GPU-compressed image formats because the processor has no render device
- allow PNG processing tasks to complete so `ProcessorState` reaches `Finished`

Co-authored-by: Álex Román Núñez <eirexe@eirteam.moe>
2026-09-19 19:07:39 +00:00
79 changed files with 2849 additions and 82958 deletions
+97 -6
View File
@@ -15,6 +15,27 @@ jobs:
- name: Check out source - name: Check out source
uses: actions/checkout@v4 uses: actions/checkout@v4
- name: Install Lore CLI
run: |
scripts/install-lore.sh "$RUNNER_TEMP/lore-bin"
echo "$RUNNER_TEMP/lore-bin" >> "$GITHUB_PATH"
- name: Select Lore asset branch
run: |
branch=main
if [[ "$GITHUB_EVENT_NAME" == pull_request ]]; then
branch="$(python3 -c 'import json, os; e=json.load(open(os.environ["GITHUB_EVENT_PATH"], encoding="utf-8")); p=e["pull_request"]; print(p["head"]["ref"] if p["head"]["repo"]["full_name"] == os.environ["GITHUB_REPOSITORY"] else "main")')"
fi
echo "LORE_BRANCH=$branch" >> "$GITHUB_ENV"
echo "Using Lore branch: $branch"
- name: Fetch assets from Lore
env:
LORE_CI_USERNAME: ${{ secrets.LORE_CI_USERNAME }}
LORE_CI_PASSWORD: ${{ secrets.LORE_CI_PASSWORD }}
LORE_AUTH_URL: https://auth.eirexe.moe
run: scripts/update-assets.sh "$LORE_BRANCH"
- name: Install Rust toolchain - name: Install Rust toolchain
run: | run: |
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | \ curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | \
@@ -58,6 +79,27 @@ jobs:
- name: Check out source - name: Check out source
uses: actions/checkout@v4 uses: actions/checkout@v4
- name: Install Lore CLI
run: |
scripts/install-lore.sh "$RUNNER_TEMP/lore-bin"
echo "$RUNNER_TEMP/lore-bin" >> "$GITHUB_PATH"
- name: Select Lore asset branch
run: |
branch=main
if [[ "$GITHUB_EVENT_NAME" == pull_request ]]; then
branch="$(python3 -c 'import json, os; e=json.load(open(os.environ["GITHUB_EVENT_PATH"], encoding="utf-8")); p=e["pull_request"]; print(p["head"]["ref"] if p["head"]["repo"]["full_name"] == os.environ["GITHUB_REPOSITORY"] else "main")')"
fi
echo "LORE_BRANCH=$branch" >> "$GITHUB_ENV"
echo "Using Lore branch: $branch"
- name: Fetch assets from Lore
env:
LORE_CI_USERNAME: ${{ secrets.LORE_CI_USERNAME }}
LORE_CI_PASSWORD: ${{ secrets.LORE_CI_PASSWORD }}
LORE_AUTH_URL: https://auth.eirexe.moe
run: scripts/update-assets.sh "$LORE_BRANCH"
- name: Install Rust toolchain - name: Install Rust toolchain
run: | run: |
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | \ curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | \
@@ -65,6 +107,11 @@ jobs:
echo "$HOME/.cargo/bin" >> "$GITHUB_PATH" echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"
"$HOME/.cargo/bin/rustup" toolchain install nightly-2026-09-14 --profile minimal "$HOME/.cargo/bin/rustup" toolchain install nightly-2026-09-14 --profile minimal
- name: Install Windows build tooling
run: |
"$HOME/.cargo/bin/rustup" target add x86_64-pc-windows-msvc --toolchain nightly-2026-09-14
"$HOME/.cargo/bin/cargo" install cargo-xwin --locked
- name: Cache production Rust dependencies and build artifacts - name: Cache production Rust dependencies and build artifacts
uses: Swatinem/rust-cache@6323deb102c322ba6fcbdcafc7e3dddab59af2b6 # v2.9.2 uses: Swatinem/rust-cache@6323deb102c322ba6fcbdcafc7e3dddab59af2b6 # v2.9.2
with: with:
@@ -76,24 +123,68 @@ jobs:
run: | run: |
sudo apt-get update sudo apt-get update
sudo apt-get install --no-install-recommends -y \ sudo apt-get install --no-install-recommends -y \
clang \ clang-19 \
libasound2-dev \ libasound2-dev \
libudev-dev \ libudev-dev \
libusb-1.0-0-dev \ libusb-1.0-0-dev \
libwayland-dev \ libwayland-dev \
libx11-dev \ libx11-dev \
libxfixes3 \
libxi6 \
libxkbcommon-dev \ libxkbcommon-dev \
libxkbcommon-x11-0 \ libxkbcommon-x11-0 \
blender \
lld-19 \
llvm-19 \
mesa-vulkan-drivers \ mesa-vulkan-drivers \
mold \ mold \
pkg-config pkg-config
sudo update-alternatives --install /usr/bin/clang clang /usr/bin/clang-19 100
sudo update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-19 100
echo "/usr/lib/llvm-19/bin" >> "$GITHUB_PATH"
rm -f "$HOME/.cache/cargo-xwin/clang-cl"
- name: Install pinned Blender
run: |
scripts/install-blender.sh "$RUNNER_TEMP/blender"
echo "BLENDER=$RUNNER_TEMP/blender/blender" >> "$GITHUB_ENV"
- name: Preprocess assets - name: Preprocess assets
run: cargo run --locked --bin process-assets --no-default-features --features debug_features -j 4 run: cargo run --locked --bin process-assets --no-default-features --features debug_features -j 4
- name: Verify processed battlefield asset
run: |
python3 - <<'PY'
import json
import struct
path = "imported_assets/Default/stages/battlefield/bf2.blend"
with open(path, "rb") as asset:
header = asset.read(12)
if len(header) != 12:
raise SystemExit(f"processed asset is truncated: {path}")
magic, version, length = struct.unpack("<4sII", header)
if magic != b"glTF" or version != 2 or length != asset.seek(0, 2):
raise SystemExit(f"processed asset is not a valid GLB: {path}")
asset.seek(12)
json_length, chunk_type = struct.unpack("<II", asset.read(8))
if chunk_type != 0x4E4F534A:
raise SystemExit(f"processed asset has no JSON chunk: {path}")
document = json.loads(asset.read(json_length))
meshes = document.get("meshes", [])
if not meshes:
raise SystemExit(f"processed asset contains no meshes: {path}")
print(f"{path}: {len(meshes)} meshes, {length} bytes")
PY
- name: Build production binary - name: Build production binary
run: cargo build --locked --profile production --no-default-features --features debug_features -j 4 run: cargo build --locked --profile production --no-default-features --features debug_features -j 4
- name: Build Windows production binary
run: |
clang --version
cargo xwin build --locked --target x86_64-pc-windows-msvc --profile production --no-default-features --features debug_features -j 4 --bin shinespark
- name: Verify production binary is not Bevy/Rust dynamically linked - name: Verify production binary is not Bevy/Rust dynamically linked
run: | run: |
! readelf -d target/production/shinespark | grep -E 'libbevy_dylib|libstd-.*\.so' ! readelf -d target/production/shinespark | grep -E 'libbevy_dylib|libstd-.*\.so'
@@ -101,10 +192,10 @@ jobs:
- name: Package Linux Steam depot - name: Package Linux Steam depot
if: github.event_name == 'push' && github.ref == 'refs/heads/master' if: github.event_name == 'push' && github.ref == 'refs/heads/master'
run: | run: |
mkdir -p build/linux mkdir -p build/game
cp target/production/shinespark build/linux/shinespark cp target/production/shinespark build/game/shinespark
cp -R assets build/linux/assets cp target/x86_64-pc-windows-msvc/production/shinespark.exe build/game/shinespark.exe
cp -R imported_assets build/linux/imported_assets cp -R imported_assets build/game/imported_assets
- if: github.event_name == 'push' && github.ref == 'refs/heads/master' - if: github.event_name == 'push' && github.ref == 'refs/heads/master'
uses: CyberAndrii/steam-totp@v1 uses: CyberAndrii/steam-totp@v1
@@ -123,5 +214,5 @@ jobs:
appId: 3409670 appId: 3409670
buildDescription: ${{ github.sha }} buildDescription: ${{ github.sha }}
rootPath: build rootPath: build
depot1Path: linux depot1Path: game
releaseBranch: master releaseBranch: master
+5
View File
@@ -1,6 +1,7 @@
/target /target
/.jackdaw /.jackdaw
imported_assets imported_assets
/assets/
# Local editor configuration # Local editor configuration
**/.vscode/ **/.vscode/
@@ -10,3 +11,7 @@ imported_assets
*_old.glb *_old.glb
/replay.json /replay.json
*.replay.tmp *.replay.tmp
# Python debugger formatter tests
__pycache__/
*.pyc
Generated
+7 -71
View File
@@ -94,12 +94,6 @@ version = "2.0.1"
source = "registry+https://github.com/rust-lang/crates.io-index" source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "320119579fcad9c21884f5c4861d16174d0e06250625266f50fe6898340abefa" checksum = "320119579fcad9c21884f5c4861d16174d0e06250625266f50fe6898340abefa"
[[package]]
name = "adler32"
version = "1.2.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "aae1277d39aeec15cb388266ecc24b11c80469deae6067e17a1a7aa9e5c1f234"
[[package]] [[package]]
name = "ahash" name = "ahash"
version = "0.8.12" version = "0.8.12"
@@ -3208,16 +3202,6 @@ dependencies = [
"windows-sys 0.60.2", "windows-sys 0.60.2",
] ]
[[package]]
name = "filetime"
version = "0.2.29"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "5c287a33c7f0a620c38e641e7f60827713987b3c0f26e8ddc9462cc69cf75759"
dependencies = [
"cfg-if",
"libc",
]
[[package]] [[package]]
name = "find-msvc-tools" name = "find-msvc-tools"
version = "0.1.9" version = "0.1.9"
@@ -3434,9 +3418,9 @@ dependencies = [
[[package]] [[package]]
name = "gc-adapter-neo" name = "gc-adapter-neo"
version = "1.1.0" version = "1.1.1"
source = "registry+https://github.com/rust-lang/crates.io-index" source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "120a5b3858ae854c4674ae41a38173e8ea04b814fb3212fd3bdd1b04d414a9d7" checksum = "a8d3e10c6c4b928cb559f641765ebaa40f5f099bf51bc0227af7431859f8bd84"
dependencies = [ dependencies = [
"binread", "binread",
"modular-bitfield", "modular-bitfield",
@@ -4266,26 +4250,6 @@ version = "0.2.189"
source = "registry+https://github.com/rust-lang/crates.io-index" source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "3eaf3ede3fee6db1a4c2ee091bf8a8b4dccdc6d17f656fb07896ee72867612f2" checksum = "3eaf3ede3fee6db1a4c2ee091bf8a8b4dccdc6d17f656fb07896ee72867612f2"
[[package]]
name = "libflate"
version = "1.4.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "5ff4ae71b685bbad2f2f391fe74f6b7659a34871c08b210fdc039e43bee07d18"
dependencies = [
"adler32",
"crc32fast",
"libflate_lz77",
]
[[package]]
name = "libflate_lz77"
version = "1.2.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "a52d3a8bfc85f250440e4424db7d857e241a3aebbbe301f3eb606ab15c39acbf"
dependencies = [
"rle-decode-fast",
]
[[package]] [[package]]
name = "libloading" name = "libloading"
version = "0.8.9" version = "0.8.9"
@@ -4326,15 +4290,13 @@ dependencies = [
[[package]] [[package]]
name = "libusb1-sys" name = "libusb1-sys"
version = "0.4.4" version = "0.7.0"
source = "registry+https://github.com/rust-lang/crates.io-index" source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "be241693102a24766d0b8526c8988771edac2842630d7e730f8e9fbc014f3703" checksum = "da050ade7ac4ff1ba5379af847a10a10a8e284181e060105bf8d86960ce9ce0f"
dependencies = [ dependencies = [
"cc", "cc",
"libc", "libc",
"libflate",
"pkg-config", "pkg-config",
"tar",
"vcpkg", "vcpkg",
] ]
@@ -5840,12 +5802,6 @@ dependencies = [
"syn 2.0.119", "syn 2.0.119",
] ]
[[package]]
name = "rle-decode-fast"
version = "1.0.3"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "3582f63211428f83597b51b2ddb88e2a91a9d52d12831f9d08f5e624e8977422"
[[package]] [[package]]
name = "robust" name = "robust"
version = "1.2.0" version = "1.2.0"
@@ -5916,9 +5872,9 @@ dependencies = [
[[package]] [[package]]
name = "rusb" name = "rusb"
version = "0.6.5" version = "0.9.4"
source = "registry+https://github.com/rust-lang/crates.io-index" source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "f6f32cd45962594f9f8cd4547b5757132715600e2c8840aa9ccd3d1a9ed6fdc6" checksum = "ab9f9ff05b63a786553a4c02943b74b34a988448671001e9a27e2f0565cc05a4"
dependencies = [ dependencies = [
"libc", "libc",
"libusb1-sys", "libusb1-sys",
@@ -6126,6 +6082,7 @@ dependencies = [
"bevy_egui", "bevy_egui",
"bevy_ggrs", "bevy_ggrs",
"bincode", "bincode",
"blake3",
"clap", "clap",
"enum_cycling", "enum_cycling",
"enum_cycling_derive", "enum_cycling_derive",
@@ -6495,17 +6452,6 @@ dependencies = [
"slotmap", "slotmap",
] ]
[[package]]
name = "tar"
version = "0.4.46"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "3f6221d9a6003c78398e3b239969f352578258df48c8eb051caadae0015bc840"
dependencies = [
"filetime",
"libc",
"xattr",
]
[[package]] [[package]]
name = "termcolor" name = "termcolor"
version = "1.4.1" version = "1.4.1"
@@ -7911,16 +7857,6 @@ version = "0.13.2"
source = "registry+https://github.com/rust-lang/crates.io-index" source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "ea6fc2961e4ef194dcbfe56bb845534d0dc8098940c7e5c012a258bfec6701bd" checksum = "ea6fc2961e4ef194dcbfe56bb845534d0dc8098940c7e5c012a258bfec6701bd"
[[package]]
name = "xattr"
version = "1.6.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "32e45ad4206f6d2479085147f02bc2ef834ac85886624a23575ae137c8aa8156"
dependencies = [
"libc",
"rustix 1.1.4",
]
[[package]] [[package]]
name = "xcursor" name = "xcursor"
version = "0.3.11" version = "0.3.11"
+3 -2
View File
@@ -12,10 +12,11 @@ development = ["bevy/dynamic_linking", "bevy/file_watcher"]
debug_features = ["bevy/free_camera"] debug_features = ["bevy/free_camera"]
[dependencies] [dependencies]
bevy = { version = "0.19", features = ["asset_processor", "basis-universal", "bevy_settings"] } bevy = { version = "0.19", features = ["asset_processor", "basis-universal", "compressed_image_saver", "bevy_settings"] }
# Loads the scenes you author in the editor (assets/*.bsn) and builds # Loads the scenes you author in the editor (assets/*.bsn) and builds
# physics colliders from them. An ordinary dependency; remove it if you # physics colliders from them. An ordinary dependency; remove it if you
# stop using authored scenes. # stop using authored scenes.
blake3 = { version = "1.8.5", features = [ "pure" ] }
thiserror = "2" thiserror = "2"
avian3d = "0.7" avian3d = "0.7"
arrayvec = "0.7.8" arrayvec = "0.7.8"
@@ -33,7 +34,7 @@ strum = "0.28.0"
strum_macros = "0.28.0" strum_macros = "0.28.0"
bevy_asset_loader = "0.27.0" bevy_asset_loader = "0.27.0"
ron_asset_manager = "0.9.0" ron_asset_manager = "0.9.0"
gc-adapter-neo = { version = "1.1.0", features = ["libusb"] } gc-adapter-neo = { version = "1.1.1", features = ["libusb"] }
rhai = "1.26.0" rhai = "1.26.0"
enum_cycling = "0.2.1" enum_cycling = "0.2.1"
enum_cycling_derive = "0.2.1" enum_cycling_derive = "0.2.1"
+25 -8
View File
@@ -2,6 +2,15 @@
Fancy heavily advanced platform fighting game Fancy heavily advanced platform fighting game
## Debugging fixed-point values with lldb
If using CodeLLDB:
```json
"preRunCommands": [
"command script import ${workspaceFolder}/tools/lldb_fixed.py"
]
```
## Direct P2P Debugging ## Direct P2P Debugging
```text ```text
@@ -16,11 +25,6 @@ cargo run -- --debug-match --players 2 --local-port 7001 \
## Production Build ## Production Build
Production builds use the `production` Cargo profile and do not dynamically
link Bevy or Rust. Development builds retain Bevy dynamic linking for faster
iteration. Cargo stores the production profile under `target/production`,
separate from development artifacts under `target/debug`.
```sh ```sh
cargo run --locked \ cargo run --locked \
--bin process-assets --no-default-features --features debug_features --bin process-assets --no-default-features --features debug_features
@@ -28,6 +32,19 @@ cargo build --locked \
--profile production --no-default-features --features debug_features --profile production --no-default-features --features debug_features
``` ```
The asset preprocessing command must be run from the repository root. It ## Assets
populates `imported_assets/Default`, which is then consumed by the production
game without running the asset processor at startup. Game assets are managed in Lore rather than Git. Install the Lore CLI, then
bootstrap or update the local checkout with:
```sh
scripts/install-lore.sh
scripts/update-assets.sh
```
The default Lore branch is `main`; pass another branch explicitly when testing
coordinated code and asset changes:
```sh
scripts/update-assets.sh my-feature-branch
```
Binary file not shown.

Before

Width:  |  Height:  |  Size: 31 KiB

@@ -1,12 +0,0 @@
frame(4);
hitbox(0,
"hand_l",
damage("5.0"),
vec3("0.0", "0.0", "0.0"),
fg32("5.0"),
angle_sakurai(),
knockback_normal(),
knockback("10.0"),
fg32("1.0")
);
frame(8);
@@ -1,12 +0,0 @@
frame(3);
hitbox(0,
"hand_l",
damage("5.0"),
vec3("0.0", "0.0", "0.0"),
fg32("5.0"),
angle(fg32("45.0")),
knockback_normal(),
knockback("18.0"),
fg32("140.0")
);
frame(8);
@@ -1,13 +0,0 @@
frame(9);
hitbox(0,
"hand_l",
damage("5.0"),
vec3("1.0", "0.0", "0.0"),
fg32("7.0"),
angle_sakurai(),
knockback_normal(),
knockback("10.0"),
fg32("1.0")
);
frame(15);
-219
View File
@@ -1,219 +0,0 @@
(
id: TestFighter,
model_path: "fighters/test/test_fighter.gltf",
model_scale: "10.0",
baked_animation_path: "fighters/test/test.fighterbake",
icon: (
path: "fighters/test/icon.png",
),
attributes: (
base_walk_accel: "0.1",
stick_walk_accel: "0.16",
max_walk_vel: "1.0",
ground_friction: "0.1",
dash_acceleration_duration: 13,
dash_duration: 24,
base_dash_accel: "0.1",
stick_dash_accel: "0.05",
max_dash_vel: "2.0",
short_hop_vertical_velocity: "1.45",
full_jump_vertical_velocity: "2.0",
jump_horizontal_velocity: "0.6",
air_jump_horizontal_velocity: "0.96",
air_jump_multiplier: "1.0",
dash_initial_velocity: "1.4",
terminal_velocity: "3.0",
fast_fall_speed: "3.5",
gravity: "0.084",
weight: "100.0",
jumpsquat_duration: 5,
landing_iasa: 4,
landing_duration: 30,
max_air_horizontal_velocity: "2.5",
air_drift_max: "1.0",
air_acceleration_base: "0.03",
air_acceleration_stick: "0.01",
air_friction: "0.01",
air_dodge_duration: 49,
air_dodge_velocity: "2.790",
air_dodge_decay: "0.9",
ecb_vertical_midpoint_offset: "0.0"
),
camera: (
vertical_origin_offset: "8.0",
forward_extent: "25.5",
backward_extent: "8.5",
upward_extent: "15.0",
downward_extent: "5.0",
visibility_radius: "5.0",
),
animations: {
Wait: "Idle_Loop_Game",
Walk: "Walk_Loop_IK_Game",
Run: "Run_Game",
Dash: "Dash_Game",
JumpSquat: "Jump_Squat_Game",
JumpForward: "Jump_Start_IK_Game",
JumpBack: "JumpB_Game",
LandingSpecial: "SpecialLand_Game",
Landing: "Jump_Land_Game",
AirDodge: "Idle_Loop_Game",
DoubleJumpForward: "Jump_Start_IK_Game",
DoubleJumpBack: "JumpB_Game",
Fall: "Fall_Loop_Game",
Turn: "Turn_Game",
FlinchGround: "Air_Hit_Game",
FlinchAir: "Air_Hit_Game",
AttackJab1: "Punch_Jab_Game",
AttackUpTilt: "Idle_Loop_Game",
AttackForwardTilt: "Idle_Loop_Game",
AttackDownTilt: "Idle_Loop_Game"
},
attack_scripts: {
NeutralAir: "fighters/test/scripts/fair.attack.rhai",
Jab: "fighters/test/scripts/jab.attack.rhai",
UpTilt: "fighters/test/scripts/uptilt.attack.rhai",
ForwardTilt: "fighters/test/scripts/uptilt.attack.rhai",
DownTilt: "fighters/test/scripts/uptilt.attack.rhai",
},
hurtboxes: [
// center one
(
bone: "spine_01",
offset: (x: "0.0", y: "0.0", z: "0.0"),
rotation: FGVec3(x: "0.0", y: "0.0", z: "0.0"),
half_length: "0.05",
radius: "0.15"
),
(
bone: "spine_03",
offset: (x: "0.0", y: "0.0", z: "0.0"),
rotation: FGVec3(x: "0.0", y: "0.0", z: "0.0"),
half_length: "0.05",
radius: "0.15"
),
(
bone: "Head",
offset: (x: "0.0", y: "0.125", z: "0.0"),
rotation: FGVec3(x: "0.0", y: "0.0", z: "0.0"),
half_length: "0.05",
radius: "0.1"
),
(
bone: "thigh_r",
offset: (x: "0.0", y: "0.15", z: "-0.01"),
rotation: FGVec3(x: "0.0", y: "0.0", z: "0.0"),
half_length: "0.2",
radius: "0.07"
),
(
bone: "thigh_l",
offset: (x: "0.0", y: "0.15", z: "-0.01"),
rotation: FGVec3(x: "0.0", y: "0.0", z: "0.0"),
half_length: "0.2",
radius: "0.07"
),
(
bone: "calf_l",
offset: (x: "0.0", y: "0.15", z: "-0.0"),
rotation: FGVec3(x: "0.0", y: "0.0", z: "0.0"),
half_length: "0.2",
radius: "0.05"
),
(
bone: "calf_r",
offset: (x: "0.0", y: "0.15", z: "-0.0"),
rotation: FGVec3(x: "0.0", y: "0.0", z: "0.0"),
half_length: "0.2",
radius: "0.05"
),
(
bone: "foot_r",
offset: (x: "0.0", y: "0.1", z: "0.01"),
rotation: FGVec3(x: "-25.0", y: "0.0", z: "0.0"),
half_length: "0.1",
radius: "0.04"
),
(
bone: "foot_l",
offset: (x: "0.0", y: "0.1", z: "0.01"),
rotation: FGVec3(x: "-25.0", y: "0.0", z: "0.0"),
half_length: "0.1",
radius: "0.04"
),
(
bone: "upperarm_l",
offset: (x: "0.0", y: "0.09", z: "-0.0"),
rotation: FGVec3(x: "0.0", y: "0.0", z: "0.0"),
half_length: "0.125",
radius: "0.05"
),
(
bone: "lowerarm_l",
offset: (x: "0.0", y: "0.12", z: "-0.0"),
rotation: FGVec3(x: "0.0", y: "0.0", z: "0.0"),
half_length: "0.115",
radius: "0.04"
),
(
bone: "hand_l",
offset: (x: "0.0", y: "0.05", z: "-0.0"),
rotation: FGVec3(x: "0.0", y: "0.0", z: "0.0"),
half_length: "0.01",
radius: "0.04"
),
(
bone: "upperarm_r",
offset: (x: "0.0", y: "0.09", z: "-0.0"),
rotation: FGVec3(x: "0.0", y: "0.0", z: "0.0"),
half_length: "0.125",
radius: "0.05"
),
(
bone: "lowerarm_r",
offset: (x: "0.0", y: "0.12", z: "-0.0"),
rotation: FGVec3(x: "0.0", y: "0.0", z: "0.0"),
half_length: "0.115",
radius: "0.04"
),
(
bone: "hand_r",
offset: (x: "0.0", y: "0.05", z: "-0.0"),
rotation: FGVec3(x: "0.0", y: "0.0", z: "0.0"),
half_length: "0.01",
radius: "0.04"
),
/*(
bone: "RFootJA",
offset: (x: "0.0", y: "0.5", z: "0.0"),
rotation: FGVec3(x: "0.0", y: "0.0", z: "90.0"),
half_length: "0.5",
radius: "1.0"
),
(
bone: "JOBJ_47",
offset: (x: "0.0", y: "0.0", z: "0.0"),
rotation: FGVec3(x: "0.0", y: "0.0", z: "90.0"),
half_length: "0.5",
radius: "1.0"
),
(
bone: "LFootJA",
offset: (x: "0.0", y: "0.5", z: "0.0"),
rotation: FGVec3(x: "0.0", y: "0.0", z: "90.0"),
half_length: "0.5",
radius: "1.0"
),
(
bone: "JOBJ_41",
offset: (x: "0.0", y: "0.0", z: "0.0"),
rotation: FGVec3(x: "0.0", y: "0.0", z: "90.0"),
half_length: "0.5",
radius: "1.0"
),*/
]
)
-3
View File
@@ -1,3 +0,0 @@
(
manifest_path: "fighters/test/test.fighter.ron",
)
Binary file not shown.
File diff suppressed because it is too large Load Diff
Binary file not shown.
-128
View File
@@ -1,128 +0,0 @@
(
cursor: (
path: "ui/textures/cursor.png",
sampling: Nearest
),
css_token: (
path: "ui/textures/fighter_select_token.png",
sampling: Linear
),
player_colors: [
Srgba((red: 0.780, green: 0.420, blue: 0.933, alpha: 1.000)),
Srgba((red: 0.843, green: 0.227, blue: 0.204, alpha: 1.000)),
Srgba((red: 0.333, green: 0.804, blue: 0.078, alpha: 1.000)),
Srgba((red: 0.075, green: 0.376, blue: 0.416, alpha: 1.000)),
Srgba((red: 0.682, green: 0.878, blue: 0.914, alpha: 1.000))
],
button_styles: {
MainMenu: (
focus_outline_width_px: 4,
focus_outline_offset_px: 2,
focus_outline_color: Srgba((red: 1.0, green: 1.0, blue: 0.0, alpha: 1.0)),
normal: (
background_color: Srgba((red: 1.0, green: 0.0, blue: 0.0, alpha: 1.0)),
border_color: Srgba((red: 1.0, green: 0.0, blue: 0.0, alpha: 1.0)),
text_color: Srgba((red: 1.0, green: 0.0, blue: 0.0, alpha: 1.0)),
box_shadow: (),
),
press: (
background_color: Srgba((red: 1.0, green: 0.0, blue: 0.0, alpha: 1.0)),
border_color: Srgba((red: 1.0, green: 0.0, blue: 0.0, alpha: 1.0)),
text_color: Srgba((red: 1.0, green: 0.0, blue: 0.0, alpha: 1.0)),
box_shadow: (),
),
hover: (
background_color: Srgba((red: 0.0, green: 1.0, blue: 0.0, alpha: 1.0)),
border_color: Srgba((red: 1.0, green: 0.0, blue: 0.0, alpha: 1.0)),
text_color: Srgba((red: 1.0, green: 0.0, blue: 0.0, alpha: 1.0)),
box_shadow: (),
)
),
CharacterSelectCharacter: (
focus_outline_width_px: 10,
focus_outline_offset_px: 5,
focus_outline_color: Srgba((red: 1.0, green: 1.0, blue: 0.0, alpha: 1.0)),
normal: (
background_color: Srgba((red: 1.0, green: 0.0, blue: 0.0, alpha: 1.0)),
text_color: Srgba((red: 1.0, green: 0.0, blue: 0.0, alpha: 1.0)),
box_shadow: (),
border_size: 10,
),
press: (
background_color: Srgba((red: 1.0, green: 0.0, blue: 0.0, alpha: 1.0)),
text_color: Srgba((red: 1.0, green: 0.0, blue: 0.0, alpha: 1.0)),
box_shadow: (),
),
hover: (
background_color: Srgba((red: 0.0, green: 1.0, blue: 0.0, alpha: 1.0)),
text_color: Srgba((red: 1.0, green: 0.0, blue: 0.0, alpha: 1.0)),
box_shadow: (),
)
),
CharacterSelectStartBanner: (
focus_outline_width_px: 10,
focus_outline_offset_px: 5,
focus_outline_color: Srgba((red: 1.0, green: 1.0, blue: 0.0, alpha: 1.0)),
normal: (
background_color: Srgba((red: 1.0, green: 0.0, blue: 0.0, alpha: 1.0)),
text_color: Srgba((red: 1.0, green: 0.0, blue: 0.0, alpha: 1.0)),
box_shadow: (),
),
press: (
background_color: Srgba((red: 1.0, green: 0.0, blue: 0.0, alpha: 1.0)),
text_color: Srgba((red: 1.0, green: 0.0, blue: 0.0, alpha: 1.0)),
box_shadow: (),
),
hover: (
background_color: Srgba((red: 0.0, green: 1.0, blue: 0.0, alpha: 1.0)),
text_color: Srgba((red: 1.0, green: 0.0, blue: 0.0, alpha: 1.0)),
box_shadow: (),
)
),
StageSelectIcon: (
focus_outline_width_px: 4,
focus_outline_offset_px: 2,
focus_outline_color: Srgba((red: 1.0, green: 1.0, blue: 0.0, alpha: 1.0)),
normal: (
border_color: Srgba((red: 1.0, green: 1.0, blue: 0.0, alpha: 1.0)),
background_color: Srgba((red: 1.0, green: 0.0, blue: 0.0, alpha: 0.0)),
text_color: Srgba((red: 1.0, green: 0.0, blue: 0.0, alpha: 1.0)),
border_size: 10,
border_radius: 40.0,
box_shadow: (
spread_radius: 5.0,
blur_radius: 5.0,
offset_px_y: 10,
offset_px_x: 10,
color: Srgba((red: 1.0, green: 1.0, blue: 1.0, alpha: 1.0))
),
),
press: (
background_color: Srgba((red: 1.0, green: 0.0, blue: 0.0, alpha: 1.0)),
border_color: Srgba((red: 1.0, green: 0.0, blue: 0.0, alpha: 1.0)),
text_color: Srgba((red: 1.0, green: 0.0, blue: 0.0, alpha: 1.0)),
border_radius: 40.0,
border_size: 10,
box_shadow: (
spread_radius: 5.0,
offset_px_y: 10,
offset_px_x: 10,
color: Srgba((red: 1.0, green: 1.0, blue: 1.0, alpha: 1.0))
),
),
hover: (
background_color: Srgba((red: 0.0, green: 1.0, blue: 0.0, alpha: 1.0)),
border_color: Srgba((red: 1.0, green: 0.0, blue: 0.0, alpha: 1.0)),
border_radius: 40.0,
border_size: 10,
text_color: Srgba((red: 1.0, green: 0.0, blue: 0.0, alpha: 1.0)),
box_shadow: (
spread_radius: 5.0,
offset_px_y: 10,
offset_px_x: 10,
color: Srgba((red: 1.0, green: 1.0, blue: 1.0, alpha: 1.0))
),
)
),
}
)
-36
View File
@@ -1,36 +0,0 @@
(
input_common: (
stick_deadzone: "0.275",
trigger_deadzone: "0.3",
smash_input_reset_axis_threshold: "0.25",
smash_input_axis_threshold: "0.8",
run_stick_threshold: "0.625",
smash_input_frame_threshold: 3,
input_buffer_size: 3,
turn_into_dashback_window: 2,
),
fighter_common: (
walk_speed_ease: "0.5",
ground_max_horizontal_velocity: "3.0",
ground_friction_over_walk_speed_multiplier: "2.0",
knockback_stacking_window: 2,
knockback_decay_per_frame: "0.051",
knockback_launch_velocity_multiplier: "0.03",
hitstun_frames_per_unit_knockback: "0.4",
tumble_bounce_hitstop_threshold: 32,
attack_ground_to_airborne_transition_vertical_angle_threshold: "90.0",
meteor_angle_threshold: "10.0",
visual_shake_frames_per_hitstop_frame: "1.2",
visual_shake_table: [
-3.0, -1.5, 1.5, 3.0
],
attacker_visual_shake_multiplier: 0.4,
di_max_angle: "18.0"
),
stage_manifest_paths: [
"stages/battlefield/test.stage.ron"
],
fighter_manifest_paths: [
"fighters/test/test.fighter.ron"
]
)
Binary file not shown.
Binary file not shown.
-139
View File
@@ -1,139 +0,0 @@
(
id: TestStage,
model_path: "stages/battlefield/battlefield.glb#Scene0",
icon: (
path: "stages/battlefield/icon.png"
),
// Battlefield
/*camera: (
left: -200.0,
right: 200.0,
bottom: -59.0,
top: 170.0,
origin: (0.0, 44.0),
vertical_fov_degrees: 30.0,
min_depth: 83.0,
max_depth: 1000.0,
subject_scale: 1.5,
fighter_forward_extent_scale: 1.5,
tracking_smoothness: 1.8,
vertical_pan_degrees: -10.0,
horizontal_pan_degrees_per_unit: 0.1,
vertical_pan_degrees_per_unit: 0.1,
max_horizontal_pan_degrees: 17.5,
max_upward_pan_degrees: 5.0,
max_downward_pan_degrees: 7.0,
),*/
// Yoshi's story
/*camera: (
left: -180.0,
right: 179.0,
bottom: -71.0,
top: 169.0,
origin: (0.0, 44.0),
vertical_fov_degrees: 20.0,
min_depth: 100.0,
max_depth: 1000.0,
subject_scale: 1.0,
fighter_forward_extent_scale: 1.0,
tracking_smoothness: 1.0,
vertical_pan_degrees: -10.0,
horizontal_pan_degrees_per_unit: 0.05,
vertical_pan_degrees_per_unit: 0.15,
max_horizontal_pan_degrees: 17.5,
max_upward_pan_degrees: 5.0,
max_downward_pan_degrees: 7.0,
),*/
camera: (
left: -180.0,
right: 179.0,
bottom: -71.0,
top: 169.0,
origin: (0.0, 44.0),
vertical_fov_degrees: 20.0,
min_depth: 100.0,
max_depth: 1000.0,
subject_scale: 1.5,
fighter_forward_extent_scale: 1.0,
tracking_smoothness: 1.0,
vertical_pan_degrees: -10.0,
horizontal_pan_degrees_per_unit: 0.05,
vertical_pan_degrees_per_unit: 0.15,
max_horizontal_pan_degrees: 17.5,
max_upward_pan_degrees: 5.0,
max_downward_pan_degrees: 7.0,
),
polygons: [
(
poly_type: Platform,
lines: [
(
(x: "-20.0", y: "47.0"),
Floor
),
(
(x: "20.0", y: "47.0"),
Floor
)
]
),
(
poly_type: Platform,
lines: [
(
(x: "-65.0", y: "24.0"),
Floor
),
(
(x: "-25.0", y: "24.0"),
Floor
)
]
),
(
poly_type: Platform,
lines: [
(
(x: "25.0", y: "24.0"),
Floor
),
(
(x: "65.0", y: "24.0"),
Floor
)
]
),
(
poly_type: Closed,
lines: [
(
(x: "-68.0", y: "-3.0"),
Wall
),
(
(x: "-68.0", y: "0.0"),
Floor,
),
(
(x: "0.0", y: "0.0"),
Floor
),
(
(x: "68", y: "0.0"),
Wall
),
(
(x: "68.0", y: "-3.0"),
Ceiling
),
(
(x: "0.0", y: "-15.0"),
Ceiling
),
]
)
]
)
Binary file not shown.

Before

Width:  |  Height:  |  Size: 871 B

Binary file not shown.

Before

Width:  |  Height:  |  Size: 5.8 KiB

@@ -1,77 +0,0 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg
width="128"
height="128"
viewBox="0 0 33.866666 33.866666"
version="1.1"
id="svg1"
inkscape:version="1.4.4 (dcaf3e7d9e, 2026-05-05)"
sodipodi:docname="cursor.svg"
xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"
xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"
xmlns:xlink="http://www.w3.org/1999/xlink"
xmlns="http://www.w3.org/2000/svg"
xmlns:svg="http://www.w3.org/2000/svg">
<sodipodi:namedview
id="namedview1"
pagecolor="#000000"
bordercolor="#000000"
borderopacity="0.25"
inkscape:showpageshadow="2"
inkscape:pageopacity="0.0"
inkscape:pagecheckerboard="0"
inkscape:deskcolor="#d1d1d1"
inkscape:document-units="mm"
inkscape:zoom="5.6568542"
inkscape:cx="8.6620581"
inkscape:cy="67.086756"
inkscape:window-width="2560"
inkscape:window-height="1006"
inkscape:window-x="0"
inkscape:window-y="0"
inkscape:window-maximized="1"
inkscape:current-layer="layer1" />
<defs
id="defs1">
<linearGradient
id="linearGradient1"
inkscape:collect="always">
<stop
style="stop-color:#949494;stop-opacity:1;"
offset="0"
id="stop1" />
<stop
style="stop-color:#6c6c6c;stop-opacity:1;"
offset="0.77473962"
id="stop3" />
<stop
style="stop-color:#9f9f9f;stop-opacity:1;"
offset="1"
id="stop2" />
</linearGradient>
<radialGradient
inkscape:collect="always"
xlink:href="#linearGradient1"
id="radialGradient2"
cx="16.933332"
cy="16.933332"
fx="16.933332"
fy="16.933332"
r="12.733072"
gradientUnits="userSpaceOnUse"
gradientTransform="matrix(1.2093771,0,0,1.2093771,-3.5454518,-3.5454518)" />
</defs>
<g
inkscape:label="Capa 1"
inkscape:groupmode="layer"
id="layer1">
<circle
style="fill:url(#radialGradient2);stroke-width:0.319981"
id="path1"
cx="16.933332"
cy="16.933332"
r="15.399086" />
</g>
</svg>

Before

Width:  |  Height:  |  Size: 2.2 KiB

+30
View File
@@ -0,0 +1,30 @@
#!/usr/bin/env bash
set -euo pipefail
version="5.2.2"
sha256="84098912789dc450e95697c4184fb8a90acbe5111c2ba4aede3fecb57806a168"
install_dir="${1:-${BLENDER_INSTALL_DIR:-${HOME}/.local/blender-${version}}}"
if [[ "$(uname -s)" != Linux || "$(uname -m)" != x86_64 ]]; then
echo "error: this installer currently supports Linux x86_64 only" >&2
exit 1
fi
if [[ -x "$install_dir/blender" ]]; then
"$install_dir/blender" --version | head -n 1
exit 0
fi
mkdir -p "$(dirname "$install_dir")"
tmp_dir="$(mktemp -d)"
trap 'rm -rf "$tmp_dir"' EXIT
archive="blender-${version}-linux-x64.tar.xz"
url="https://download.blender.org/release/Blender5.2/${archive}"
curl --fail --location --silent --show-error --output "$tmp_dir/$archive" "$url"
printf '%s %s\n' "$sha256" "$tmp_dir/$archive" | sha256sum --check --status
tar --extract --xz --file "$tmp_dir/$archive" --directory "$tmp_dir"
mv "$tmp_dir/blender-${version}-linux-x64" "$install_dir"
"$install_dir/blender" --version | head -n 1
+31
View File
@@ -0,0 +1,31 @@
#!/usr/bin/env bash
set -euo pipefail
version="v0.10.0"
sha256="0d1633b71e44081c6a3ca57ad5be3df7a9563698827638838939c3c832e87351"
install_dir="${1:-${LORE_INSTALL_DIR:-${HOME}/.local/bin}}"
if [[ "$(uname -s)" != Linux || "$(uname -m)" != x86_64 ]]; then
echo "error: this installer currently supports Linux x86_64 only" >&2
exit 1
fi
mkdir -p "$install_dir"
tmp_dir="$(mktemp -d)"
trap 'rm -rf "$tmp_dir"' EXIT
archive="lore-${version}-x86_64-unknown-linux-gnu.tar.gz"
url="https://github.com/EpicGames/lore/releases/download/${version}/${archive}"
curl --fail --location --silent --show-error --output "$tmp_dir/$archive" "$url"
printf '%s %s\n' "$sha256" "$tmp_dir/$archive" | sha256sum --check --status
tar --extract --gzip --file "$tmp_dir/$archive" --directory "$tmp_dir"
binary="$(find "$tmp_dir" -type f -name lore -print -quit)"
if [[ -z "$binary" ]]; then
echo "error: Lore archive did not contain a lore binary" >&2
exit 1
fi
install -m 0755 "$binary" "$install_dir/lore"
"$install_dir/lore" --version
+111
View File
@@ -0,0 +1,111 @@
#!/usr/bin/env bash
set -euo pipefail
readonly lore_url="${LORE_REPOSITORY_URL:-lore://lore.eirexe.moe/shinespark}"
readonly default_branch="${LORE_DEFAULT_BRANCH:-main}"
readonly assets_dir="${LORE_ASSETS_DIR:-assets}"
branch="${1:-${LORE_BRANCH:-$default_branch}}"
case "$branch" in
""|*[!A-Za-z0-9._/-]*)
echo "error: invalid Lore branch name: $branch" >&2
exit 2
;;
esac
if [[ -n "${LORE_IDENTITY_TOKEN:-}" ]]; then
lore_args=(--identity-token "$LORE_IDENTITY_TOKEN")
elif [[ -n "${LORE_CI_USERNAME:-}" || -n "${LORE_CI_PASSWORD:-}" ]]; then
if [[ -z "${LORE_CI_USERNAME:-}" || -z "${LORE_CI_PASSWORD:-}" ]]; then
echo "error: LORE_CI_USERNAME and LORE_CI_PASSWORD must be provided together" >&2
exit 2
fi
: "${LORE_AUTH_URL:=https://auth.eirexe.moe}"
export LORE_AUTH_URL
token="$(python3 - <<'PY'
import json
import os
import sys
import urllib.error
import urllib.request
request = urllib.request.Request(
os.environ["LORE_AUTH_URL"].rstrip("/") + "/auth/login",
data=json.dumps({
"username": os.environ["LORE_CI_USERNAME"],
"password": os.environ["LORE_CI_PASSWORD"],
}).encode(),
headers={"Content-Type": "application/json"},
method="POST",
)
try:
with urllib.request.urlopen(request) as response:
payload = json.load(response)
except urllib.error.HTTPError as error:
print(f"Lore authentication failed with HTTP {error.code}", file=sys.stderr)
sys.exit(1)
token = payload.get("token")
if not isinstance(token, str) or not token:
print("Lore authentication response did not contain a token", file=sys.stderr)
sys.exit(1)
print(token)
PY
)"
if [[ -n "${GITHUB_ENV:-}" ]]; then
echo "::add-mask::$token"
fi
lore_args=(--identity-token "$token")
else
lore_args=()
fi
if [[ -e "$assets_dir" && ! -d "$assets_dir" ]]; then
echo "error: $assets_dir exists but is not a directory" >&2
exit 1
fi
if [[ -d "$assets_dir/.lore" ]]; then
if ! lore "${lore_args[@]}" --repository "$assets_dir" repository info >/dev/null; then
echo "error: $assets_dir is not a usable Lore checkout" >&2
exit 1
fi
if ! lore "${lore_args[@]}" --repository "$assets_dir" branch list --no-pager \
| grep -Fqx " $branch"; then
if [[ "$branch" != "$default_branch" ]]; then
echo "warning: Lore branch does not exist: $branch; using $default_branch" >&2
branch="$default_branch"
else
echo "error: Lore branch does not exist: $branch" >&2
exit 1
fi
fi
lore "${lore_args[@]}" --repository "$assets_dir" sync "$branch@LATEST"
exit 0
fi
if [[ -d "$assets_dir" && -n "$(find "$assets_dir" -mindepth 1 -maxdepth 1 -print -quit)" ]]; then
echo "error: refusing to overwrite non-Lore directory: $assets_dir" >&2
exit 1
fi
metadata_dir="$(mktemp -d)"
trap 'rm -rf "$metadata_dir"' EXIT
lore "${lore_args[@]}" --non-interactive clone --bare "$lore_url" "$metadata_dir"
if ! lore "${lore_args[@]}" --repository "$metadata_dir" branch list --no-pager \
| grep -Fqx " $branch"; then
if [[ "$branch" != "$default_branch" ]]; then
echo "warning: Lore branch does not exist: $branch; using $default_branch" >&2
branch="$default_branch"
else
echo "error: Lore branch does not exist: $branch" >&2
echo "available branches:" >&2
lore "${lore_args[@]}" --repository "$metadata_dir" branch list --no-pager >&2
exit 1
fi
fi
rm -rf "$assets_dir"
lore "${lore_args[@]}" --non-interactive clone --branch "$branch" "$lore_url" "$assets_dir"
lore "${lore_args[@]}" --repository "$assets_dir" status --revision-only --no-pager
+394
View File
@@ -0,0 +1,394 @@
//! Blender `.blend` source processing.
//!
//! Blender is used as an offline importer. The processed result is a normal
//! GLB, so the runtime continues to use Bevy's built-in glTF loader.
use bevy::{
asset::{
AssetLoader, AssetPath, AsyncWriteExt, LoadContext,
io::{Reader, Writer},
processor::LoadTransformAndSave,
saver::{AssetSaver, SavedAsset},
transformer::{AssetTransformer, TransformedAsset},
},
gltf::GltfLoader,
prelude::*,
reflect::TypePath,
};
use serde::Deserialize;
use std::{
collections::HashMap,
fs, io,
path::{Path, PathBuf},
process::Command,
time::{SystemTime, UNIX_EPOCH},
};
use crate::fighter::animation::AnimKind;
const EXPORT_SCRIPT: &str = include_str!("blend_asset/export.py");
#[derive(Asset, TypePath)]
struct BlendSource {
glb: Vec<u8>,
}
#[derive(Default, TypePath)]
struct BlendSourceLoader;
#[derive(Debug, Deserialize)]
struct ExportManifest {
dependencies: Vec<String>,
}
#[derive(Debug, Deserialize)]
struct AnimationManifest {
animations: HashMap<AnimKind, String>,
}
impl AssetLoader for BlendSourceLoader {
type Asset = BlendSource;
type Settings = ();
type Error = io::Error;
async fn load(
&self,
reader: &mut dyn Reader,
_: &Self::Settings,
load_context: &mut LoadContext<'_>,
) -> Result<Self::Asset, Self::Error> {
let mut source_bytes = Vec::new();
reader.read_to_end(&mut source_bytes).await?;
let temp = TempDir::new()?;
let source_path = locate_source(load_context.path().path());
let blend_path = if let Some(path) = source_path.as_deref() {
path.to_path_buf()
} else {
let path = temp.path().join("source.blend");
fs::write(&path, source_bytes)?;
path
};
let output = temp.path().join("export.gltf");
let script = temp.path().join("export.py");
let actions = referenced_actions(load_context, &asset_root()).await?;
let actions_path = temp.path().join("actions.json");
fs::write(
&actions_path,
serde_json::to_vec(&actions).map_err(io::Error::other)?,
)?;
fs::write(&script, EXPORT_SCRIPT)?;
let result = Command::new(std::env::var_os("BLENDER").unwrap_or_else(|| "blender".into()))
.arg("--background")
.arg(&blend_path)
.arg("--python")
.arg(&script)
.arg("--")
.arg(&output)
.arg(&actions_path)
.arg(&blend_path)
.output()
.map_err(|error| io::Error::other(format!("failed to start Blender: {error}")))?;
if !result.status.success() {
return Err(io::Error::other(format!(
"Blender export failed with {}:\n{}\n{}",
result.status,
String::from_utf8_lossy(&result.stdout),
String::from_utf8_lossy(&result.stderr)
)));
}
let manifest: ExportManifest =
serde_json::from_slice(&fs::read(temp.path().join("export-manifest.json"))?)
.map_err(|error| io::Error::new(io::ErrorKind::InvalidData, error))?;
let asset_root = asset_root();
let mut dependencies = manifest.dependencies;
let document: serde_json::Value = serde_json::from_slice(&fs::read(&output)?)
.map_err(|error| io::Error::new(io::ErrorKind::InvalidData, error))?;
validate_export(&document, &output)?;
if let Some(images) = document.get("images").and_then(serde_json::Value::as_array) {
for image in images {
if let Some(uri) = image.get("uri").and_then(serde_json::Value::as_str) {
let path = temp.path().join(uri);
dependencies.push(path.to_string_lossy().into_owned());
}
}
}
let mut seen = std::collections::HashSet::new();
for dependency in dependencies {
let physical = PathBuf::from(&dependency);
let Some(asset_path) = physical_to_asset_path(&physical, &asset_root) else {
continue;
};
if seen.insert(asset_path.clone()) {
// This read is intentionally discarded: it registers the file and
// its processed hash as a processor dependency.
load_context
.read_asset_bytes(asset_path)
.await
.map_err(|error| {
io::Error::other(format!("failed to read blend dependency: {error}"))
})?;
}
}
let glb = make_glb(&output, &temp, load_context.path().path(), &asset_root)?;
Ok(BlendSource { glb })
}
fn extensions(&self) -> &[&str] {
&["blend"]
}
}
fn validate_export(document: &serde_json::Value, output: &Path) -> io::Result<()> {
for key in ["scenes", "nodes", "meshes"] {
let count = document
.get(key)
.and_then(serde_json::Value::as_array)
.map_or(0, Vec::len);
if count == 0 {
return Err(io::Error::new(
io::ErrorKind::InvalidData,
format!("Blender export {} contains no {key}", output.display()),
));
}
}
Ok(())
}
async fn referenced_actions(
load_context: &mut LoadContext<'_>,
root: &Path,
) -> io::Result<Vec<String>> {
let model_path = load_context.path().path();
let Some(stem) = model_path.file_stem().and_then(|stem| stem.to_str()) else {
return Ok(Vec::new());
};
let manifest_path = model_path
.parent()
.unwrap_or_else(|| Path::new(""))
.join(format!("{stem}.fighter.ron"));
if !root.join(&manifest_path).is_file() {
return Ok(Vec::new());
}
let bytes = load_context
.read_asset_bytes(manifest_path)
.await
.map_err(|error| io::Error::other(error.to_string()))?;
let manifest: AnimationManifest = ron::de::from_bytes(&bytes)
.map_err(|error| io::Error::new(io::ErrorKind::InvalidData, error))?;
Ok(manifest.animations.into_values().collect())
}
#[derive(Asset, TypePath)]
struct ProcessedBlend {
bytes: Vec<u8>,
}
#[derive(Default, TypePath)]
struct BlendTransformer;
impl AssetTransformer for BlendTransformer {
type AssetInput = BlendSource;
type AssetOutput = ProcessedBlend;
type Settings = ();
type Error = io::Error;
async fn transform<'a>(
&'a self,
source: TransformedAsset<Self::AssetInput>,
_: &'a Self::Settings,
) -> Result<TransformedAsset<Self::AssetOutput>, Self::Error> {
let bytes = source.glb.clone();
Ok(source.replace_asset(ProcessedBlend { bytes }))
}
}
#[derive(Default, TypePath)]
struct BlendSaver;
impl AssetSaver for BlendSaver {
type Asset = ProcessedBlend;
type Settings = ();
type OutputLoader = GltfLoader;
type Error = io::Error;
async fn save(
&self,
writer: &mut Writer,
asset: SavedAsset<'_, '_, Self::Asset>,
_: &Self::Settings,
_: AssetPath<'_>,
) -> Result<<Self::OutputLoader as AssetLoader>::Settings, Self::Error> {
writer.write_all(&asset.bytes).await?;
Ok(default())
}
}
type BlendProcessor = LoadTransformAndSave<BlendSourceLoader, BlendTransformer, BlendSaver>;
pub struct BlendAssetProcessingPlugin;
impl Plugin for BlendAssetProcessingPlugin {
fn build(&self, app: &mut App) {
app.init_asset::<BlendSource>()
.init_asset::<ProcessedBlend>()
.register_asset_loader(BlendSourceLoader)
.register_asset_processor(BlendProcessor::new(BlendTransformer, BlendSaver))
.set_default_asset_processor::<BlendProcessor>("blend");
}
}
struct TempDir(PathBuf);
impl TempDir {
fn new() -> io::Result<Self> {
let stamp = SystemTime::now()
.duration_since(UNIX_EPOCH)
.unwrap_or_default()
.as_nanos();
let path =
std::env::temp_dir().join(format!("shinespark-blend-{}-{stamp}", std::process::id()));
fs::create_dir_all(&path)?;
Ok(Self(path))
}
fn path(&self) -> &Path {
&self.0
}
}
impl Drop for TempDir {
fn drop(&mut self) {
let _ = fs::remove_dir_all(&self.0);
}
}
fn asset_root() -> PathBuf {
std::env::var_os("BEVY_ASSET_ROOT")
.map(PathBuf::from)
.unwrap_or_else(|| std::env::current_dir().unwrap_or_default().join("assets"))
}
fn locate_source(path: &Path) -> Option<PathBuf> {
let root = asset_root();
[root.join(path), PathBuf::from(path)]
.into_iter()
.find(|candidate| candidate.is_file())
}
fn physical_to_asset_path(path: &Path, root: &Path) -> Option<String> {
let canonical = fs::canonicalize(path).ok()?;
let root = fs::canonicalize(root).ok()?;
let relative = canonical.strip_prefix(root).ok()?;
Some(relative.to_string_lossy().replace('\\', "/"))
}
fn make_glb(
gltf_path: &Path,
temp: &TempDir,
model_asset_path: &Path,
asset_root: &Path,
) -> io::Result<Vec<u8>> {
let mut json: serde_json::Value = serde_json::from_slice(&fs::read(gltf_path)?)
.map_err(|error| io::Error::new(io::ErrorKind::InvalidData, error))?;
let bin_name = json["buffers"][0]["uri"].as_str().ok_or_else(|| {
io::Error::new(io::ErrorKind::InvalidData, "glTF has no binary buffer URI")
})?;
let mut bin = fs::read(temp.path().join(bin_name))?;
let model_parent = model_asset_path.parent().unwrap_or_else(|| Path::new(""));
let image_count = json["images"].as_array().map_or(0, Vec::len);
if image_count > 0 && !json["bufferViews"].is_array() {
return Err(io::Error::new(
io::ErrorKind::InvalidData,
"glTF bufferViews are not an array",
));
}
for index in 0..image_count {
let uri = json["images"][index]
.get("uri")
.and_then(serde_json::Value::as_str)
.map(str::to_owned);
let Some(uri) = uri else { continue };
if uri.starts_with("data:") {
continue;
}
let uri_path = temp.path().join(uri);
if let Some(asset_path) = physical_to_asset_path(&uri_path, asset_root) {
json["images"][index]["uri"] =
serde_json::Value::String(relative_uri(model_parent, Path::new(&asset_path)));
} else {
let bytes = fs::read(&uri_path)?;
while bin.len() % 4 != 0 {
bin.push(0);
}
let offset = bin.len();
bin.extend_from_slice(&bytes);
let mime = mime_type(&uri_path);
let view = json["bufferViews"].as_array().unwrap().len();
json["bufferViews"]
.as_array_mut()
.unwrap()
.push(serde_json::json!({
"buffer": 0,
"byteOffset": offset,
"byteLength": bytes.len(),
}));
json["images"][index].as_object_mut().unwrap().remove("uri");
json["images"][index]["bufferView"] = serde_json::Value::from(view);
json["images"][index]["mimeType"] = serde_json::Value::String(mime.to_owned());
}
}
json["buffers"][0]["byteLength"] = serde_json::Value::from(bin.len());
json["buffers"][0].as_object_mut().unwrap().remove("uri");
let mut json_bytes = serde_json::to_vec(&json).map_err(io::Error::other)?;
while json_bytes.len() % 4 != 0 {
json_bytes.push(b' ');
}
while bin.len() % 4 != 0 {
bin.push(0);
}
let length = 12 + 8 + json_bytes.len() + 8 + bin.len();
let mut glb = Vec::with_capacity(length);
glb.extend_from_slice(b"glTF");
glb.extend_from_slice(&2u32.to_le_bytes());
glb.extend_from_slice(&(length as u32).to_le_bytes());
glb.extend_from_slice(&(json_bytes.len() as u32).to_le_bytes());
glb.extend_from_slice(b"JSON");
glb.extend_from_slice(&json_bytes);
glb.extend_from_slice(&(bin.len() as u32).to_le_bytes());
glb.extend_from_slice(b"BIN\0");
glb.extend_from_slice(&bin);
Ok(glb)
}
fn relative_uri(from: &Path, to: &Path) -> String {
let from: Vec<_> = from.components().collect();
let to: Vec<_> = to.components().collect();
let common = from.iter().zip(&to).take_while(|(a, b)| a == b).count();
let mut result = PathBuf::new();
for _ in common..from.len() {
result.push("..");
}
for component in &to[common..] {
result.push(component.as_os_str());
}
result.to_string_lossy().replace('\\', "/")
}
fn mime_type(path: &Path) -> &'static str {
match path
.extension()
.and_then(|e| e.to_str())
.unwrap_or_default()
.to_ascii_lowercase()
.as_str()
{
"jpg" | "jpeg" => "image/jpeg",
"webp" => "image/webp",
_ => "image/png",
}
}
+80
View File
@@ -0,0 +1,80 @@
import bpy
import json
import os
import sys
def main():
output = sys.argv[sys.argv.index("--") + 1]
actions_path = sys.argv[sys.argv.index("--") + 2]
source_path = sys.argv[sys.argv.index("--") + 3]
loaded_path = os.path.realpath(bpy.data.filepath)
expected_path = os.path.realpath(source_path)
if loaded_path != expected_path:
raise RuntimeError(
f"Blender loaded {loaded_path!r} instead of {expected_path!r}"
)
if not bpy.data.objects or not bpy.data.meshes:
raise RuntimeError("Blender loaded an empty scene")
with open(actions_path) as file:
actions_to_keep = set(json.load(file))
for obj in bpy.data.objects:
if not obj.animation_data:
continue
for track in list(obj.animation_data.nla_tracks):
if track.name.startswith("[Action Stash]"):
obj.animation_data.nla_tracks.remove(track)
nla_tracks = [
track
for obj in bpy.data.objects
if obj.animation_data
for track in obj.animation_data.nla_tracks
]
use_nla_tracks = bool(nla_tracks)
# For blends without NLA tracks, use the actions referenced by the fighter
# manifest instead of sampling every source action.
if not use_nla_tracks and actions_to_keep:
from io_scene_gltf2 import GLTF2_filter_action
if not hasattr(bpy.types.Scene, "gltf_action_filter"):
bpy.types.Scene.gltf_action_filter = bpy.props.CollectionProperty(
type=GLTF2_filter_action
)
scene = bpy.context.scene
scene.gltf_action_filter.clear()
for action in bpy.data.actions:
item = scene.gltf_action_filter.add()
item.action = action
item.keep = action.name in actions_to_keep
bpy.ops.export_scene.gltf(
filepath=output,
export_format="GLTF_SEPARATE",
export_keep_originals=True,
export_extras=True,
export_animations=True,
export_skins=True,
export_morph=True,
export_yup=True,
export_def_bones=True,
export_action_filter=False,
export_animation_mode="NLA_TRACKS" if use_nla_tracks else "ACTIONS",
)
dependencies = []
for image in bpy.data.images:
if image.source not in {"FILE", "TILED"}:
continue
path = image.filepath_raw or image.filepath
if path and not image.packed_file:
dependencies.append(bpy.path.abspath(path))
with open(os.path.join(os.path.dirname(output), "export-manifest.json"), "w") as file:
json.dump({"dependencies": sorted(set(dependencies))}, file)
if __name__ == "__main__":
main()
+23 -4
View File
@@ -3,11 +3,9 @@
use std::{collections::HashMap, time::Duration}; use std::{collections::HashMap, time::Duration};
use bevy::{ use bevy::{
input::InputSystems, camera::{CameraOutputMode, visibility::RenderLayers}, input::InputSystems, prelude::*, render::render_resource::BlendState, settings::{ReflectSettingsGroup, SaveSettingsDeferred, SettingsGroup},
prelude::*,
settings::{ReflectSettingsGroup, SaveSettingsDeferred, SettingsGroup},
}; };
use bevy_egui::{EguiContexts, EguiPrimaryContextPass, egui}; use bevy_egui::{EguiContexts, EguiGlobalSettings, EguiPrimaryContextPass, PrimaryEguiContext, egui};
use bevy_ggrs::{RollbackFrameRate, RunGgrsSystems}; use bevy_ggrs::{RollbackFrameRate, RunGgrsSystems};
use enum_cycling::EnumCycle; use enum_cycling::EnumCycle;
use enum_cycling_derive::EnumCycle; use enum_cycling_derive::EnumCycle;
@@ -397,6 +395,7 @@ impl Plugin for DebugToolsPlugin {
.before(RunGgrsSystems) .before(RunGgrsSystems)
.run_if(in_state(AppState::InMatch)), .run_if(in_state(AppState::InMatch)),
) )
.add_systems(Startup, spawn_egui_camera)
.add_systems(PreUpdate, restore_frame_step_time.after(RunGgrsSystems)) .add_systems(PreUpdate, restore_frame_step_time.after(RunGgrsSystems))
.add_systems( .add_systems(
Update, Update,
@@ -408,6 +407,26 @@ impl Plugin for DebugToolsPlugin {
} }
} }
pub fn spawn_egui_camera(mut commands: Commands, mut egui_global_settings: ResMut<EguiGlobalSettings>,) {
egui_global_settings.auto_create_primary_context = false;
commands.spawn((
// The `PrimaryEguiContext` component requires everything needed to render a primary context.
PrimaryEguiContext,
Camera2d,
// Setting RenderLayers to none makes sure we won't render anything apart from the UI.
RenderLayers::none(),
Camera {
order: 2,
output_mode: CameraOutputMode::Write {
blend_state: Some(BlendState::ALPHA_BLENDING),
clear_color: ClearColorConfig::None,
},
clear_color: ClearColorConfig::Custom(Color::NONE),
..default()
},
));
}
fn player_handles(players: &Query<&Player>) -> Vec<usize> { fn player_handles(players: &Query<&Player>) -> Vec<usize> {
let mut handles = players let mut handles = players
.iter() .iter()
+17 -11
View File
@@ -1,12 +1,22 @@
use bevy::prelude::*; use bevy::prelude::*;
use crate::{ use crate::{
camera::MatchCamera, fighter::{ camera::MatchCamera,
FighterECB, FighterFacingDirection, FighterHitboxes, FighterHitstop, FighterHitstopShake, FighterPreviousFacingDirection, FighterPreviousTranslation, FighterTranslation, FighterVelocity, Grounded, animation::FighterAnimationFrame, attack::{ fighter::{
FighterECB, FighterFacingDirection, FighterHitboxes, FighterHitstop, FighterHitstopShake,
FighterPreviousFacingDirection, FighterPreviousTranslation, FighterSurfaceState,
FighterTranslation, FighterVelocity,
animation::FighterAnimationFrame,
attack::{
FighterDamage, FighterKnockbackVelocity, FighterPendingHitReaction, FighterPendingHits, FighterDamage, FighterKnockbackVelocity, FighterPendingHitReaction, FighterPendingHits,
FighterSolvedHurtboxes, FighterStaleMoveQueue, FighterSolvedHurtboxes, FighterStaleMoveQueue,
}, baked_animation::FighterBoneMatrices, state::FighterState, },
}, input::FighterInput, player::Player, stage::line::StageCollision, baked_animation::FighterBoneMatrices,
state::FighterState,
},
input::FighterInput,
player::Player,
stage::line::StageCollision,
}; };
#[derive(Resource, Default)] #[derive(Resource, Default)]
@@ -44,7 +54,7 @@ struct FighterCheckpoint {
hitboxes: FighterHitboxes, hitboxes: FighterHitboxes,
solved_hurtboxes: FighterSolvedHurtboxes, solved_hurtboxes: FighterSolvedHurtboxes,
bone_matrices: FighterBoneMatrices, bone_matrices: FighterBoneMatrices,
grounded: bool, surface: FighterSurfaceState,
} }
pub(super) fn save_or_restore(world: &mut World) { pub(super) fn save_or_restore(world: &mut World) {
@@ -143,11 +153,7 @@ pub(super) fn save_or_restore(world: &mut World) {
entity.insert(saved.hitboxes.clone()); entity.insert(saved.hitboxes.clone());
entity.insert(saved.solved_hurtboxes.clone()); entity.insert(saved.solved_hurtboxes.clone());
entity.insert(saved.bone_matrices.clone()); entity.insert(saved.bone_matrices.clone());
if saved.grounded { entity.insert(saved.surface.clone());
entity.insert(Grounded);
} else {
entity.remove::<Grounded>();
}
} }
world.insert_resource(checkpoint.pending_hits.clone()); world.insert_resource(checkpoint.pending_hits.clone());
world.insert_resource(checkpoint.stage_collision); world.insert_resource(checkpoint.stage_collision);
@@ -181,7 +187,7 @@ fn capture_fighter(world: &World, entity: Entity) -> Option<FighterCheckpoint> {
hitboxes: fighter.get::<FighterHitboxes>()?.clone(), hitboxes: fighter.get::<FighterHitboxes>()?.clone(),
solved_hurtboxes: fighter.get::<FighterSolvedHurtboxes>()?.clone(), solved_hurtboxes: fighter.get::<FighterSolvedHurtboxes>()?.clone(),
bone_matrices: fighter.get::<FighterBoneMatrices>()?.clone(), bone_matrices: fighter.get::<FighterBoneMatrices>()?.clone(),
grounded: fighter.contains::<Grounded>(), surface: fighter.get::<FighterSurfaceState>()?.clone(),
}) })
} }
+5
View File
@@ -84,6 +84,11 @@ pub enum AnimKind {
AirDodge, AirDodge,
Fall, Fall,
Turn, Turn,
CrouchEnter,
CrouchIdle,
CrouchExit,
PlatformPass,
FlinchGround, FlinchGround,
FlinchAir, FlinchAir,
-1
View File
@@ -605,7 +605,6 @@ impl Plugin for FighterAttackPlugin {
intersect_attacks_with_hurtboxes, intersect_attacks_with_hurtboxes,
) )
.chain() .chain()
.after(crate::fighter::baked_animation::update_fighter_bone_matrices)
.in_set(GameplaySet::Attacks), .in_set(GameplaySet::Attacks),
); );
} }
+4 -1
View File
@@ -2,8 +2,8 @@ use super::{
BAKED_ANIMATION_FPS, BAKED_ANIMATION_FPS,
runtime::{BakedAnimationClip, BakedFighterAnimations}, runtime::{BakedAnimationClip, BakedFighterAnimations},
}; };
use crate::math::fixed_transform::FixedMat4;
use crate::fighter::{animation::AnimKind, manifest::FighterManifest}; use crate::fighter::{animation::AnimKind, manifest::FighterManifest};
use crate::math::fixed_transform::FixedMat4;
use bevy::{ use bevy::{
asset::{ asset::{
AssetLoader, AssetPath, AsyncWriteExt, LoadContext, AssetLoader, AssetPath, AsyncWriteExt, LoadContext,
@@ -51,6 +51,9 @@ impl AssetLoader for FighterBakeSourceLoader {
.map_err(|error| io::Error::other(error.to_string()))?; .map_err(|error| io::Error::other(error.to_string()))?;
let manifest: FighterManifest = ron::de::from_bytes(&manifest_bytes) let manifest: FighterManifest = ron::de::from_bytes(&manifest_bytes)
.map_err(|error| io::Error::new(io::ErrorKind::InvalidData, error))?; .map_err(|error| io::Error::new(io::ErrorKind::InvalidData, error))?;
// `read_asset_bytes` uses the processor's processed asset source. This
// deliberately allows `model_path` to point at a `.blend`: the blend
// processor has already converted it to a hybrid GLB by this point.
let model_bytes = load_context let model_bytes = load_context
.read_asset_bytes(&manifest.model_path) .read_asset_bytes(&manifest.model_path)
.await .await
+118 -6
View File
@@ -4,8 +4,8 @@ mod asset_baking;
mod runtime; mod runtime;
mod visual_binding; mod visual_binding;
pub use asset_baking::{BakedAnimationAssetProcessingPlugin, BakedAnimationPlugin};
pub use crate::math::fixed_transform::FixedMat4; pub use crate::math::fixed_transform::FixedMat4;
pub use asset_baking::{BakedAnimationAssetProcessingPlugin, BakedAnimationPlugin};
pub use runtime::{ pub use runtime::{
BakedAnimationClip, BakedFighterAnimations, FighterBoneIndexMap, FighterBoneMatrices, BakedAnimationClip, BakedFighterAnimations, FighterBoneIndexMap, FighterBoneMatrices,
update_fighter_bone_matrices, update_fighter_bone_matrices,
@@ -21,6 +21,7 @@ mod tests {
use asset_baking::{ use asset_baking::{
Channel, ChannelValues, bake_gltf_document, baked_frame_count, sample_vec3, Channel, ChannelValues, bake_gltf_document, baked_frame_count, sample_vec3,
}; };
use serde_json::json;
use std::collections::HashMap; use std::collections::HashMap;
#[test] #[test]
@@ -29,11 +30,7 @@ mod tests {
"../../../assets/fighters/test/test.fighter.ron" "../../../assets/fighters/test/test.fighter.ron"
)) ))
.unwrap(); .unwrap();
let (document, buffers, _) = gltf::import(concat!( let (document, buffers) = test_gltf(&manifest.animations);
env!("CARGO_MANIFEST_DIR"),
"/assets/fighters/test/test_fighter.gltf"
))
.unwrap();
let baked = bake_gltf_document(document, buffers, &manifest.animations).unwrap(); let baked = bake_gltf_document(document, buffers, &manifest.animations).unwrap();
assert_eq!(baked.frame_rate, BAKED_ANIMATION_FPS); assert_eq!(baked.frame_rate, BAKED_ANIMATION_FPS);
@@ -51,6 +48,104 @@ mod tests {
assert_eq!(baked.parents.len(), baked.bone_names.len()); assert_eq!(baked.parents.len(), baked.bone_names.len());
} }
/// Builds the smallest glTF document that still exercises the complete
/// animation-baking path. Keeping this fixture in memory avoids making
/// unit tests depend on the production Blender asset or Blender itself.
fn test_gltf(
animations: &HashMap<AnimKind, String>,
) -> (gltf::Document, Vec<gltf::buffer::Data>) {
let mut names: Vec<_> = animations.values().cloned().collect();
names.sort();
names.dedup();
let mut data = Vec::new();
let mut buffer_views = Vec::new();
let mut accessors = Vec::new();
let mut gltf_animations = Vec::new();
for name in names {
let duration: f32 = match name.as_str() {
"Idle_Loop_Game" => 2.0,
"Walk_Loop_IK_Game" | "Run_Game" => 0.533333361,
"Dash_Game" => 0.333333343,
"Jump_Land_Game" => 0.133333340,
"JumpB_Game" => 56.0 / 60.0,
_ => 0.0,
};
let input_offset = data.len();
data.extend_from_slice(&0.0_f32.to_le_bytes());
data.extend_from_slice(&duration.to_le_bytes());
let output_offset = data.len();
data.extend_from_slice(
&[0.0_f32, 0.0, 0.0]
.into_iter()
.flat_map(f32::to_le_bytes)
.collect::<Vec<_>>(),
);
data.extend_from_slice(
&[1.0_f32, 0.0, 0.0]
.into_iter()
.flat_map(f32::to_le_bytes)
.collect::<Vec<_>>(),
);
let input_view = buffer_views.len();
buffer_views.push(json!({
"buffer": 0,
"byteOffset": input_offset,
"byteLength": 8
}));
let output_view = buffer_views.len();
buffer_views.push(json!({
"buffer": 0,
"byteOffset": output_offset,
"byteLength": 24
}));
let input_accessor = accessors.len();
accessors.push(json!({
"bufferView": input_view,
"componentType": 5126,
"count": 2,
"type": "SCALAR",
"min": [0.0],
"max": [duration]
}));
let output_accessor = accessors.len();
accessors.push(json!({
"bufferView": output_view,
"componentType": 5126,
"count": 2,
"type": "VEC3"
}));
gltf_animations.push(json!({
"name": name,
"samplers": [{
"input": input_accessor,
"output": output_accessor,
"interpolation": "LINEAR"
}],
"channels": [{
"sampler": 0,
"target": { "node": 0, "path": "translation" }
}]
}));
}
let document = json!({
"asset": { "version": "2.0" },
"scene": 0,
"scenes": [{ "nodes": [0] }],
"nodes": [{ "name": "root", "children": [1] }, { "name": "hand" }],
"buffers": [{ "byteLength": data.len() }],
"bufferViews": buffer_views,
"accessors": accessors,
"animations": gltf_animations
});
let bytes = serde_json::to_vec(&document).unwrap();
let gltf = gltf::Gltf::from_slice(&bytes).unwrap();
(gltf.document, vec![gltf::buffer::Data(data)])
}
#[test] #[test]
fn pose_sampling_wraps_repeating_frames_and_clamps_finished_frames() { fn pose_sampling_wraps_repeating_frames_and_clamps_finished_frames() {
let first = FixedMat4::IDENTITY; let first = FixedMat4::IDENTITY;
@@ -124,6 +219,7 @@ mod tests {
second.translate(FGVec3::lit("0", "3", "0")); second.translate(FGVec3::lit("0", "3", "0"));
let mut matrices = FighterBoneMatrices::default(); let mut matrices = FighterBoneMatrices::default();
matrices.set_pose( matrices.set_pose(
AnimKind::Wait,
&["root".into(), "hand".into()], &["root".into(), "hand".into()],
&[None, Some(0)], &[None, Some(0)],
&[first, second], &[first, second],
@@ -144,6 +240,7 @@ mod tests {
hand.translate(FGVec3::lit("0", "3", "0")); hand.translate(FGVec3::lit("0", "3", "0"));
let mut matrices = FighterBoneMatrices::default(); let mut matrices = FighterBoneMatrices::default();
matrices.set_pose( matrices.set_pose(
AnimKind::Wait,
&["root".into(), "hand".into()], &["root".into(), "hand".into()],
&[None, Some(0)], &[None, Some(0)],
&[root, hand], &[root, hand],
@@ -164,6 +261,20 @@ mod tests {
); );
} }
#[test]
fn repeated_pose_updates_reuse_scratch_and_output_buffers() {
let mut matrices = FighterBoneMatrices::default();
let names = ["root".into(), "hand".into()];
let parents = [None, Some(0)];
let pose = [FixedMat4::IDENTITY, FixedMat4::IDENTITY];
matrices.set_pose(AnimKind::Wait, &names, &parents, &pose, FGi32::ONE);
let capacities = matrices.buffer_capacities();
matrices.set_pose(AnimKind::Wait, &names, &parents, &pose, FGi32::ONE);
assert_eq!(capacities, matrices.buffer_capacities());
}
#[test] #[test]
fn model_scale_affects_gameplay_bones_without_changing_visual_locals() { fn model_scale_affects_gameplay_bones_without_changing_visual_locals() {
let mut root = FixedMat4::IDENTITY; let mut root = FixedMat4::IDENTITY;
@@ -172,6 +283,7 @@ mod tests {
hand.translate(FGVec3::lit("0", "2", "0")); hand.translate(FGVec3::lit("0", "2", "0"));
let mut matrices = FighterBoneMatrices::default(); let mut matrices = FighterBoneMatrices::default();
matrices.set_pose( matrices.set_pose(
AnimKind::Wait,
&["root".into(), "hand".into()], &["root".into(), "hand".into()],
&[None, Some(0)], &[None, Some(0)],
&[root, hand], &[root, hand],
+46 -8
View File
@@ -3,7 +3,7 @@ use std::collections::HashMap;
use bevy::prelude::*; use bevy::prelude::*;
use serde::{Deserialize, Serialize}; use serde::{Deserialize, Serialize};
use super::{BAKED_ANIMATION_FPS}; use super::BAKED_ANIMATION_FPS;
use crate::{ use crate::{
fighter::{ fighter::{
@@ -12,8 +12,8 @@ use crate::{
manifest::FighterManifest, manifest::FighterManifest,
visual::FighterAnimations, visual::FighterAnimations,
}, },
math::fixed_transform::FixedMat4,
math::int::FGi32, math::int::FGi32,
math::fixed_transform::FixedMat4
}; };
#[derive(Clone, Debug, Serialize, Deserialize)] #[derive(Clone, Debug, Serialize, Deserialize)]
@@ -70,12 +70,31 @@ pub struct FighterBoneMatrices {
previous_frame_matrices: Vec<FixedMat4>, previous_frame_matrices: Vec<FixedMat4>,
local_matrices: Vec<FixedMat4>, local_matrices: Vec<FixedMat4>,
previous_local_matrices: Vec<FixedMat4>, previous_local_matrices: Vec<FixedMat4>,
model_matrices: Vec<Option<FixedMat4>>,
presentation_kind: Option<AnimKind>,
} }
#[derive(Component, Clone, Debug, Default)] #[derive(Component, Clone, Debug, Default)]
pub struct FighterBoneIndexMap(pub HashMap<String, usize>); pub struct FighterBoneIndexMap(pub HashMap<String, usize>);
impl FighterBoneMatrices { impl FighterBoneMatrices {
#[cfg(test)]
pub(super) fn buffer_capacities(&self) -> [usize; 5] {
[
self.matrices.capacity(),
self.local_matrices.capacity(),
self.previous_frame_matrices.capacity(),
self.previous_local_matrices.capacity(),
self.model_matrices.capacity(),
]
}
pub fn get_by_idx(&self, index: usize) -> Option<(FixedMat4, FixedMat4)> {
Some((
*self.previous_frame_matrices.get(index)?,
*self.matrices.get(index)?,
))
}
pub fn get(&self, bone: &str) -> Option<(FixedMat4, FixedMat4)> { pub fn get(&self, bone: &str) -> Option<(FixedMat4, FixedMat4)> {
let index = self.bone_names.iter().position(|name| name == bone)?; let index = self.bone_names.iter().position(|name| name == bone)?;
Some(( Some((
@@ -120,6 +139,7 @@ impl FighterBoneMatrices {
} }
pub(super) fn set_pose( pub(super) fn set_pose(
&mut self, &mut self,
kind: AnimKind,
bone_names: &[String], bone_names: &[String],
parents: &[Option<usize>], parents: &[Option<usize>],
local: &[FixedMat4], local: &[FixedMat4],
@@ -142,13 +162,20 @@ impl FighterBoneMatrices {
assert_eq!(self.bone_names, bone_names, "baked bone names changed"); assert_eq!(self.bone_names, bone_names, "baked bone names changed");
assert_eq!(self.parents, parents, "baked bone parents changed"); assert_eq!(self.parents, parents, "baked bone parents changed");
} }
self.matrices.reserve(local.len());
self.previous_frame_matrices.reserve(local.len());
self.local_matrices.reserve(local.len());
self.previous_local_matrices.reserve(local.len());
self.model_matrices.reserve(local.len());
std::mem::swap(&mut self.matrices, &mut self.previous_frame_matrices); std::mem::swap(&mut self.matrices, &mut self.previous_frame_matrices);
let animation_changed = self.presentation_kind != Some(kind);
std::mem::swap(&mut self.local_matrices, &mut self.previous_local_matrices); std::mem::swap(&mut self.local_matrices, &mut self.previous_local_matrices);
self.local_matrices.clear(); self.local_matrices.clear();
self.local_matrices.extend_from_slice(local); self.local_matrices.extend_from_slice(local);
let mut model = vec![None; local.len()]; self.model_matrices.resize(local.len(), None);
self.model_matrices.fill(None);
for index in 0..local.len() { for index in 0..local.len() {
resolve_model_transform(index, parents, local, &mut model) resolve_model_transform(index, parents, local, &mut self.model_matrices)
.expect("baked bone hierarchy should be valid"); .expect("baked bone hierarchy should be valid");
} }
let model_scale = FixedMat4 { let model_scale = FixedMat4 {
@@ -159,10 +186,20 @@ impl FighterBoneMatrices {
[FGi32::ZERO, FGi32::ZERO, FGi32::ZERO, FGi32::ONE], [FGi32::ZERO, FGi32::ZERO, FGi32::ZERO, FGi32::ONE],
], ],
}; };
self.matrices = model self.matrices.clear();
.into_iter() self.matrices.extend(
.map(|matrix| model_scale.mul(matrix.expect("baked bone hierarchy should be valid"))) self.model_matrices.iter().map(|matrix| {
.collect(); model_scale.mul(matrix.expect("baked bone hierarchy should be valid"))
}),
);
// A state transition is a discontinuity, not an animation frame to
// interpolate from the previous clip. Keep the presentation pose at
// the new clip's first/current frame immediately.
if animation_changed {
self.previous_local_matrices
.clone_from(&self.local_matrices);
}
self.presentation_kind = Some(kind);
} }
} }
@@ -192,6 +229,7 @@ pub fn update_fighter_bone_matrices(
.get(&fighter.manifest) .get(&fighter.manifest)
.expect("fighter manifest should be loaded before the match starts"); .expect("fighter manifest should be loaded before the match starts");
matrices.set_pose( matrices.set_pose(
frame.kind,
&baked.bone_names, &baked.bone_names,
&baked.parents, &baked.parents,
pose, pose,
+77 -26
View File
@@ -44,37 +44,88 @@ pub fn air_collide_with_stage(
prev_ecb: &FighterPreviousECB, prev_ecb: &FighterPreviousECB,
ecb: &FighterECB, ecb: &FighterECB,
stage_collision: &StageCollision, stage_collision: &StageCollision,
ignored_polys: &[usize],
) -> Option<AirCollisionWithStageResult> { ) -> Option<AirCollisionWithStageResult> {
let ray_segment = FGSegment2d::new( let ray_segment = FGSegment2d::new(
prev_translation.0 + prev_ecb.get_bottom_point(), prev_translation.0 + prev_ecb.get_bottom_point(),
translation.0 + ecb.get_bottom_point(), translation.0 + ecb.get_bottom_point(),
); );
let mut intersect_results = vec![]; stage_collision
.stage_polys
for (poly_idx, poly) in stage_collision.stage_polys.iter().enumerate() {
if let Some(intersect_result) = poly.intersect_ray(ray_segment) {
intersect_results.push((
AirCollisionWithStageResult {
line_id: {
StageLineID {
polygon: poly_idx,
segment: intersect_result.segment_idx,
}
},
hit_position: intersect_result.position,
hit_normal: intersect_result.normal,
},
intersect_result
.position
.distance_squared(ray_segment.point2()),
));
}
}
intersect_results.sort_by(|(_, a), (_, b)| a.cmp(b));
intersect_results
.iter() .iter()
.last() .enumerate()
.map(|(val, _)| val.to_owned().clone()) .filter(|(poly_idx, _)| !ignored_polys.contains(poly_idx))
.filter_map(|(poly_idx, poly)| {
poly.intersect_ray(ray_segment).map(|intersect_result| {
(
AirCollisionWithStageResult {
line_id: {
StageLineID {
polygon: poly_idx,
segment: intersect_result.segment_idx,
}
},
hit_position: intersect_result.position,
hit_normal: intersect_result.normal,
},
intersect_result
.position
.distance_squared(ray_segment.point2()),
)
})
})
.max_by(|(_, a), (_, b)| a.cmp(b))
.map(|(result, _)| result)
}
#[cfg(test)]
mod tests {
use super::*;
use crate::fighter::ecb::{FighterECB, FighterPreviousECB};
use crate::stage::line::{StagePoly, StagePolyLineSegmentType, StagePolyType};
fn horizontal_platform(y: &str) -> StagePoly {
StagePoly::build(
StagePolyType::Platform,
&[
(FGVec2::lit("-2", y), StagePolyLineSegmentType::Floor),
(FGVec2::lit("2", y), StagePolyLineSegmentType::Floor),
],
)
}
#[test]
fn airborne_collision_skips_ignored_polygons() {
let stage_collision = StageCollision {
stage_polys: vec![horizontal_platform("0"), horizontal_platform("1")],
};
let previous_translation = FighterPreviousTranslation(FGVec2::lit("0", "2"));
let translation = FighterTranslation(FGVec2::lit("0", "-1"));
let previous_ecb = FighterPreviousECB {
bottom: FGVec2::ZERO,
top: FGVec2::ZERO,
left: FGVec2::ZERO,
right: FGVec2::ZERO,
};
let ecb = FighterECB {
bottom: FGVec2::ZERO,
top: FGVec2::ZERO,
left: FGVec2::ZERO,
right: FGVec2::ZERO,
};
let collision = air_collide_with_stage(
&previous_translation,
&translation,
&previous_ecb,
&ecb,
&stage_collision,
&[1],
)
.expect("the non-ignored platform should still be collidable");
assert_eq!(collision.line_id.polygon, 0);
assert_eq!(collision.hit_position, FGVec2::lit("0", "0"));
}
} }
+18 -4
View File
@@ -27,6 +27,7 @@ use crate::game_settings::GameSettings;
use crate::input::FighterInput; use crate::input::FighterInput;
use crate::math::int::FGi32; use crate::math::int::FGi32;
use crate::math::vec::FGVec2; use crate::math::vec::FGVec2;
use crate::math::vec3::FGVec3;
use crate::player::Player; use crate::player::Player;
pub fn debug_draw_ecb( pub fn debug_draw_ecb(
@@ -39,6 +40,12 @@ pub fn debug_draw_ecb(
mut gizmos: Gizmos, mut gizmos: Gizmos,
) { ) {
for (ecb, trf, ecb_prev, trf_prev) in ecbs { for (ecb, trf, ecb_prev, trf_prev) in ecbs {
gizmos.cross(
FGVec3::new(trf.0.x, trf.0.y, FGi32::ZERO).to_vec3(),
2.0,
bevy::color::palettes::css::BLUE,
);
let transformed = let transformed =
ecb.to_3d_lineloop(Transform::from_xyz(trf.x.to_num(), trf.y.to_num(), 0.0)); ecb.to_3d_lineloop(Transform::from_xyz(trf.x.to_num(), trf.y.to_num(), 0.0));
gizmos.lineloop(transformed, YELLOW); gizmos.lineloop(transformed, YELLOW);
@@ -153,10 +160,17 @@ pub fn fighter_debug(
Ok(()) Ok(())
} }
pub fn animation_debug(query: Query<(&GlobalTransform, &FighterBoneMatrices)>, mut gizmos: Gizmos) { pub fn animation_debug(
for (global_transform, matrices) in query { query: Query<(
let (_, rotation, translation) = global_transform.to_scale_rotation_translation(); &FighterTranslation,
let marker_transform = Transform::from_translation(translation).with_rotation(rotation); &FighterFacingDirection,
&FighterBoneMatrices,
)>,
mut gizmos: Gizmos,
) {
for (global_transform, facing_dir, matrices) in query {
let global_transform = global_transform.get_3d_transform(facing_dir);
let marker_transform = global_transform.to_mat4();
for (_, matrix) in matrices.iter() { for (_, matrix) in matrices.iter() {
let pos = marker_transform.transform_point(Vec3::new( let pos = marker_transform.transform_point(Vec3::new(
matrix.cols[3][0].to_num(), matrix.cols[3][0].to_num(),
+100 -48
View File
@@ -1,28 +1,44 @@
use bevy::prelude::*; use bevy::prelude::*;
use crate::math::{int::FGi32, vec::FGVec2}; use crate::{
fighter::{
FighterFacingDirection, FighterSurfaceState, FighterTranslation,
baked_animation::FighterBoneMatrices,
}, math::{int::FGi32, vec::FGVec2},
};
/// Environment collision box: the diamond used to resolve a fighter against /// Environment collision box: the diamond used to resolve a fighter against
/// the stage. Purely geometry — the collision response lives in /// the stage. Purely geometry — the collision response lives in
/// [`super::collision`]. /// [`super::collision`].
#[derive(Component, Debug, Clone, Copy, Hash)] #[derive(Component, Debug, Clone, Copy, Hash, Default)]
#[require(FighterPreviousECB)] #[require(FighterPreviousECB)]
pub struct FighterECB { pub struct FighterECB {
pub vertical_half: FGi32, pub top: FGVec2,
pub horizontal_half: FGi32, pub bottom: FGVec2,
pub left: FGVec2,
pub right: FGVec2,
}
#[derive(Component, Debug, Clone)]
pub struct FighterECBBoneIndices {
pub indices: Vec<usize>,
} }
#[derive(Component, Debug, Clone, Copy, Default, Hash)] #[derive(Component, Debug, Clone, Copy, Default, Hash)]
pub struct FighterPreviousECB { pub struct FighterPreviousECB {
pub vertical_half: FGi32, pub top: FGVec2,
pub horizontal_half: FGi32, pub bottom: FGVec2,
pub left: FGVec2,
pub right: FGVec2,
} }
impl From<FighterECB> for FighterPreviousECB { impl From<FighterECB> for FighterPreviousECB {
fn from(ecb: FighterECB) -> Self { fn from(ecb: FighterECB) -> Self {
Self { Self {
vertical_half: ecb.vertical_half, top: ecb.top,
horizontal_half: ecb.horizontal_half, bottom: ecb.bottom,
left: ecb.left,
right: ecb.right,
} }
} }
} }
@@ -35,53 +51,85 @@ pub fn snapshot_fighter_ecb(fighters: Query<(&FighterECB, &mut FighterPreviousEC
impl FighterECB { impl FighterECB {
pub fn to_3d_lineloop(&self, trf: Transform) -> [Vec3; 4] { pub fn to_3d_lineloop(&self, trf: Transform) -> [Vec3; 4] {
let rel_up = trf.transform_point(Vec3::new( [self.top, self.right, self.bottom, self.left]
0.0, .map(|point| trf.transform_point(Vec3::new(point.x.to_num(), point.y.to_num(), 0.0)))
(self.vertical_half + self.vertical_half).to_num(),
0.0,
));
let rel_down = trf.transform_point(Vec3::new(0.0, 0.0, 0.0));
let rel_left = trf.transform_point(Vec3::new(
(-self.horizontal_half).to_num(),
self.vertical_half.to_num(),
0.0,
));
let rel_right = trf.transform_point(Vec3::new(
self.horizontal_half.to_num(),
self.vertical_half.to_num(),
0.0,
));
[rel_up, rel_right, rel_down, rel_left]
} }
pub fn get_bottom_point(&self) -> FGVec2 { pub fn get_bottom_point(&self) -> FGVec2 {
FGVec2::new(FGi32::ZERO, FGi32::ZERO) self.bottom
} }
} }
impl FighterPreviousECB { impl FighterPreviousECB {
pub fn to_3d_lineloop(&self, trf: Transform) -> [Vec3; 4] { pub fn to_3d_lineloop(&self, trf: Transform) -> [Vec3; 4] {
let rel_up = trf.transform_point(Vec3::new( [self.top, self.right, self.bottom, self.left]
0.0, .map(|point| trf.transform_point(Vec3::new(point.x.to_num(), point.y.to_num(), 0.0)))
(self.vertical_half + self.vertical_half).to_num(),
0.0,
));
let rel_down = trf.transform_point(Vec3::new(0.0, 0.0, 0.0));
let rel_left = trf.transform_point(Vec3::new(
(-self.horizontal_half).to_num(),
self.vertical_half.to_num(),
0.0,
));
let rel_right = trf.transform_point(Vec3::new(
self.horizontal_half.to_num(),
self.vertical_half.to_num(),
0.0,
));
[rel_up, rel_right, rel_down, rel_left]
} }
pub fn get_bottom_point(&self) -> FGVec2 { pub fn get_bottom_point(&self) -> FGVec2 {
FGVec2::new(FGi32::ZERO, FGi32::ZERO) self.bottom
}
}
pub fn update_ecb(
query: Query<(
&mut FighterECB,
&FighterSurfaceState,
&FighterECBBoneIndices,
&FighterBoneMatrices,
&FighterTranslation,
&FighterFacingDirection,
)>,
) {
for (mut ecb, surface_state, bone_indices, bone_matrices, translation, facing_dir) in query {
let trf = translation.get_3d_transform(facing_dir);
let transformed_ecb_bones = bone_indices.indices.iter().filter_map(|idx| {
let Some((_, bone_matrix)) = bone_matrices.get_by_idx(*idx) else {
return None;
};
let pt = trf.transform_point(bone_matrix.get_translation());
Some(FGVec2::new(pt.x, pt.y) - translation.0)
}).collect::<Vec<_>>();
let max_x = transformed_ecb_bones.iter().max_by(|a, b| a.x.cmp(&b.x)).map(|final_val| final_val.x).unwrap_or(FGi32::lit("0.5"));
let min_x = transformed_ecb_bones.iter().min_by(|a, b| a.x.cmp(&b.x)).map(|final_val| final_val.x).unwrap_or(FGi32::lit("-0.5"));
let max_y = transformed_ecb_bones.iter().max_by(|a, b| a.y.cmp(&b.y)).map(|final_val| final_val.y).unwrap_or(FGi32::lit("0.5"));
let min_y = transformed_ecb_bones.iter().min_by(|a, b| a.y.cmp(&b.y)).map(|final_val| final_val.y).unwrap_or(FGi32::lit("-0.5"));
let midpoint_height = (max_y + min_y) / FGi32::lit("2.0");
let top = FGVec2::new(FGi32::ZERO, max_y);
let bottom = FGVec2::new(FGi32::ZERO, min_y);
let left = FGVec2::new(min_x, midpoint_height);
let right = FGVec2::new(max_x, midpoint_height);
let ecb_lock_frames_remaining = if let FighterSurfaceState::Airborne { ecb_lock_frames_remaining, .. } = surface_state {
*ecb_lock_frames_remaining
} else {
0
};
ecb.top = top;
if ecb_lock_frames_remaining == 0 {
ecb.bottom = bottom;
}
ecb.left = left;
ecb.right = right;
if surface_state.is_grounded() {
ecb.bottom = FGVec2::ZERO;
}
}
}
pub fn decrement_ecb_lockout(surface_states: Query<&mut FighterSurfaceState>) {
for mut state in surface_states {
state.tick_ecb_lock();
state.tick_ignored_polygons();
} }
} }
@@ -92,12 +140,16 @@ mod tests {
#[test] #[test]
fn previous_ecb_copies_current_dimensions() { fn previous_ecb_copies_current_dimensions() {
let current = FighterECB { let current = FighterECB {
vertical_half: FGi32::lit("0.5"), bottom: FGVec2::lit("0.0", "-0.5"),
horizontal_half: FGi32::lit("0.25"), top: FGVec2::lit("0.0", "0.5"),
left: FGVec2::lit("-0.5", "0.0"),
right: FGVec2::lit("0.5", "0.0"),
}; };
let previous = FighterPreviousECB::from(current); let previous = FighterPreviousECB::from(current);
assert_eq!(previous.vertical_half, current.vertical_half); assert_eq!(previous.top, current.top);
assert_eq!(previous.horizontal_half, current.horizontal_half); assert_eq!(previous.bottom, current.bottom);
assert_eq!(previous.left, current.left);
assert_eq!(previous.right, current.right);
} }
} }
+1
View File
@@ -65,6 +65,7 @@ pub struct FighterManifest {
pub animations: HashMap<AnimKind, String>, pub animations: HashMap<AnimKind, String>,
pub attack_scripts: HashMap<AttackKind, String>, pub attack_scripts: HashMap<AttackKind, String>,
pub hurtboxes: Vec<FighterHurtbox>, pub hurtboxes: Vec<FighterHurtbox>,
pub ecb_bones: Vec<String>,
} }
#[derive(Resource)] #[derive(Resource)]
+24 -16
View File
@@ -18,6 +18,7 @@ pub mod hurtbox;
pub mod manifest; pub mod manifest;
pub mod motion; pub mod motion;
pub mod state; pub mod state;
pub mod surface;
pub mod visual; pub mod visual;
// The fighter components are re-exported so the rest of the crate can say // The fighter components are re-exported so the rest of the crate can say
@@ -28,9 +29,9 @@ pub use attributes::FighterAttributes;
pub use ecb::FighterECB; pub use ecb::FighterECB;
pub use manifest::FighterId; pub use manifest::FighterId;
pub use motion::{ pub use motion::{
FighterPreviousFacingDirection, FighterPreviousTranslation, FighterTranslation, FighterPreviousFacingDirection, FighterPreviousTranslation, FighterTranslation, FighterVelocity,
FighterVelocity, Grounded,
}; };
pub use surface::FighterSurfaceState;
use crate::{ use crate::{
AppState, fighter::{ AppState, fighter::{
@@ -38,7 +39,7 @@ use crate::{
AttackKind, FighterAttackPlugin, FighterAttackScriptAssets, FighterDamage, AttackKind, FighterAttackPlugin, FighterAttackScriptAssets, FighterDamage,
FighterKnockbackVelocity, FighterPendingHitReaction, FighterSolvedHurtboxes, FighterKnockbackVelocity, FighterPendingHitReaction, FighterSolvedHurtboxes,
FighterStaleMoveQueue, FighterStaleMoveQueue,
}, baked_animation::{FighterBoneIndexMap, FighterBoneMatrices}, manifest::FighterManifest, state::{FighterState, air::AirborneStateCommon, fall::FallState}, visual::FighterAnimations, }, baked_animation::{FighterBoneIndexMap, FighterBoneMatrices}, ecb::FighterECBBoneIndices, manifest::FighterManifest, state::{FighterState, air::AirborneStateCommon, fall::FallState}, visual::FighterAnimations,
}, input::FighterInput, math::{int::FGi32, vec::FGVec2}, player::Player, schedule::GameplaySet, scripting::FighterAttackScript, stage::line::StageCollision, }, input::FighterInput, math::{int::FGi32, vec::FGVec2}, player::Player, schedule::GameplaySet, scripting::FighterAttackScript, stage::line::StageCollision,
}; };
use state::state_interrupt_system; use state::state_interrupt_system;
@@ -58,14 +59,14 @@ pub enum FighterFacingDirection {
pub enum FighterHitstopShakeKind { pub enum FighterHitstopShakeKind {
#[default] #[default]
Horizontal, Horizontal,
Vertical Vertical,
} }
#[derive(Component, Copy, Clone, Hash, Debug, PartialEq, Reflect, Default)] #[derive(Component, Copy, Clone, Hash, Debug, PartialEq, Reflect, Default)]
pub enum FighterHitstopShakeRole { pub enum FighterHitstopShakeRole {
#[default] #[default]
Attacker, Attacker,
Receiver Receiver,
} }
#[derive(Component, Default, Copy, Clone, Hash)] #[derive(Component, Default, Copy, Clone, Hash)]
@@ -73,7 +74,7 @@ pub struct FighterHitstopShake {
pub remaining_frames: u32, pub remaining_frames: u32,
pub total_frames: u32, pub total_frames: u32,
pub kind: FighterHitstopShakeKind, pub kind: FighterHitstopShakeKind,
pub role: FighterHitstopShakeRole pub role: FighterHitstopShakeRole,
} }
#[derive(Component, Default, Copy, Clone, Hash)] #[derive(Component, Default, Copy, Clone, Hash)]
@@ -133,7 +134,7 @@ pub struct FighterVisual;
FighterPendingHitReaction, FighterPendingHitReaction,
FighterHitstop, FighterHitstop,
FighterKnockbackVelocity, FighterKnockbackVelocity,
FighterTranslation, FighterTranslation
)] )]
pub struct Fighter { pub struct Fighter {
pub manifest: Handle<FighterManifest>, pub manifest: Handle<FighterManifest>,
@@ -170,10 +171,15 @@ impl Plugin for FighterPlugin {
)*/ )*/
.add_systems( .add_systems(
GgrsSchedule, GgrsSchedule,
state::state_collision_interrupt_system.in_set(GameplaySet::Collision), (
(ecb::update_ecb, ecb::decrement_ecb_lockout, state::state_collision_interrupt_system).chain(),
baked_animation::update_fighter_bone_matrices,
)
.chain()
.in_set(GameplaySet::Collision),
) )
.add_systems( .add_systems(
Update, PostUpdate,
( (
motion::apply_fighter_translation_to_visuals, motion::apply_fighter_translation_to_visuals,
animation::apply_animation, animation::apply_animation,
@@ -200,8 +206,8 @@ impl Plugin for FighterPlugin {
.checksum_component_with_hash::<FighterPreviousFacingDirection>() .checksum_component_with_hash::<FighterPreviousFacingDirection>()
.rollback_component_with_copy::<animation::FighterAnimationFrame>() .rollback_component_with_copy::<animation::FighterAnimationFrame>()
.checksum_component_with_hash::<animation::FighterAnimationFrame>() .checksum_component_with_hash::<animation::FighterAnimationFrame>()
.rollback_component_with_copy::<Grounded>() .rollback_component_with_clone::<FighterSurfaceState>()
.checksum_component_with_hash::<Grounded>() .checksum_component_with_hash::<FighterSurfaceState>()
.rollback_component_with_copy::<FighterFacingDirection>() .rollback_component_with_copy::<FighterFacingDirection>()
.rollback_component_with_copy::<FighterDamage>() .rollback_component_with_copy::<FighterDamage>()
.checksum_component_with_hash::<FighterDamage>() .checksum_component_with_hash::<FighterDamage>()
@@ -259,7 +265,7 @@ pub struct FighterActiveAttack {
pub active_hitboxes: Vec<usize>, pub active_hitboxes: Vec<usize>,
pub solved_hitboxes: Vec<attack::FighterSolvedHitbox>, pub solved_hitboxes: Vec<attack::FighterSolvedHitbox>,
pub hit_fighters: Vec<Entity>, pub hit_fighters: Vec<Entity>,
pub stalled: bool pub stalled: bool,
} }
#[derive(Component, Clone, Debug, Default, Hash)] #[derive(Component, Clone, Debug, Default, Hash)]
@@ -274,6 +280,7 @@ pub fn spawn_fighter(
animations: FighterAnimations, animations: FighterAnimations,
attack_scripts: FighterAttackScriptAssets, attack_scripts: FighterAttackScriptAssets,
visual_root: WorldAssetRoot, visual_root: WorldAssetRoot,
ecb_bone_indices: Vec<usize>,
) -> Entity { ) -> Entity {
commands commands
.spawn(( .spawn((
@@ -284,13 +291,14 @@ pub fn spawn_fighter(
Fighter { manifest: manifest }, Fighter { manifest: manifest },
FighterFacingDirection::Right, FighterFacingDirection::Right,
FighterPreviousFacingDirection(FighterFacingDirection::Right), FighterPreviousFacingDirection(FighterFacingDirection::Right),
FighterSurfaceState::default(),
Transform::from_scale(Vec3::splat(model_scale.to_num())), Transform::from_scale(Vec3::splat(model_scale.to_num())),
( (
FighterECB { FighterECB::default(),
vertical_half: FGi32::lit("5.0"),
horizontal_half: FGi32::lit("2.5"),
},
FighterHitboxes::default(), FighterHitboxes::default(),
FighterECBBoneIndices {
indices: ecb_bone_indices
}
), ),
( (
FighterVelocity::default(), FighterVelocity::default(),
+21 -16
View File
@@ -5,19 +5,16 @@ use bevy::prelude::*;
use bevy_ggrs::GgrsFrameTiming; use bevy_ggrs::GgrsFrameTiming;
use crate::debug_tools::PresentationMotionMode; use crate::debug_tools::PresentationMotionMode;
use crate::fighter::{FighterHitstopShake}; use crate::fighter::FighterHitstopShake;
use crate::game_settings::GameSettings; use crate::game_settings::GameSettings;
use crate::{ use crate::{
fighter::{FighterECB, FighterFacingDirection, baked_animation::FixedMat4}, fighter::{FighterFacingDirection, baked_animation::FixedMat4},
math::{int::FGi32, vec::FGVec2, vec3::FGVec3}, math::{int::FGi32, vec::FGVec2, vec3::FGVec3},
}; };
#[derive(Component, Clone, Copy, Hash)] #[derive(Component, Clone, Copy, Hash)]
pub struct FighterPreviousFacingDirection(pub FighterFacingDirection); pub struct FighterPreviousFacingDirection(pub FighterFacingDirection);
#[derive(Component, Clone, Copy, Hash)]
pub struct Grounded;
#[derive(Component, Deref, DerefMut, Default, Debug, Clone, Copy, Hash)] #[derive(Component, Deref, DerefMut, Default, Debug, Clone, Copy, Hash)]
pub struct FighterVelocity(pub FGVec2); pub struct FighterVelocity(pub FGVec2);
@@ -59,7 +56,6 @@ pub fn apply_fighter_translation_to_visuals(
query: Query<( query: Query<(
&FighterTranslation, &FighterTranslation,
&FighterPreviousTranslation, &FighterPreviousTranslation,
&FighterECB,
&FighterHitstopShake, &FighterHitstopShake,
&mut Transform, &mut Transform,
)>, )>,
@@ -68,33 +64,42 @@ pub fn apply_fighter_translation_to_visuals(
game_settings: Res<GameSettings>, game_settings: Res<GameSettings>,
) { ) {
let overstep_fraction = timing.overstep_fraction(); let overstep_fraction = timing.overstep_fraction();
for (translation, previous_translation, ecb, hitstop_shake, mut transform) in query { for (translation, previous_translation, hitstop_shake, mut transform) in query {
let translation = sample_presentation_translation( let translation = sample_presentation_translation(
*previous_translation, *previous_translation,
*translation, *translation,
overstep_fraction, overstep_fraction,
debug_settings.motion_sampling, debug_settings.motion_sampling,
); );
let bottom = ecb.get_bottom_point();
transform.translation = Vec3::new( transform.translation = Vec3::new(
translation.x + bottom.x.to_num::<f32>(), translation.x,
translation.y + bottom.y.to_num::<f32>(), translation.y,
0.0, 0.0,
); );
if hitstop_shake.remaining_frames > 0 && hitstop_shake.total_frames > 0 && !game_settings.fighter_common.visual_shake_table.is_empty() { if hitstop_shake.remaining_frames > 0
&& hitstop_shake.total_frames > 0
&& !game_settings.fighter_common.visual_shake_table.is_empty()
{
let total = hitstop_shake.total_frames as f32; let total = hitstop_shake.total_frames as f32;
let curr = hitstop_shake.remaining_frames as f32; let curr = hitstop_shake.remaining_frames as f32;
let elapsed = 1.0 - curr / total; let elapsed = 1.0 - curr / total;
let access_index = (hitstop_shake.remaining_frames as usize)
let access_index = (hitstop_shake.remaining_frames as usize) % game_settings.fighter_common.visual_shake_table.len(); % game_settings.fighter_common.visual_shake_table.len();
let shake_multiplier = match hitstop_shake.role { let shake_multiplier = match hitstop_shake.role {
super::FighterHitstopShakeRole::Attacker => game_settings.fighter_common.attacker_visual_shake_multiplier, super::FighterHitstopShakeRole::Attacker => {
game_settings
.fighter_common
.attacker_visual_shake_multiplier
}
super::FighterHitstopShakeRole::Receiver => 1.0, super::FighterHitstopShakeRole::Receiver => 1.0,
}; };
let shake_amount: f32 = 1.0 - EaseFunction::QuinticIn.sample(elapsed).unwrap_or_default(); let shake_amount: f32 =
let shake_amount = game_settings.fighter_common.visual_shake_table[access_index] * shake_amount * shake_multiplier; 1.0 - EaseFunction::QuinticIn.sample(elapsed).unwrap_or_default();
let shake_amount = game_settings.fighter_common.visual_shake_table[access_index]
* shake_amount
* shake_multiplier;
let shake_offset = match hitstop_shake.kind { let shake_offset = match hitstop_shake.kind {
super::FighterHitstopShakeKind::Horizontal => Vec3::new(shake_amount, 0.0, 0.0), super::FighterHitstopShakeKind::Horizontal => Vec3::new(shake_amount, 0.0, 0.0),
+25 -13
View File
@@ -1,4 +1,3 @@
use crate::fighter::state::ground::GroundedStateCommon;
use crate::fighter::state::land::{LandingState, LandingType}; use crate::fighter::state::land::{LandingState, LandingType};
use crate::fighter::state::{CollisionContext, FighterState}; use crate::fighter::state::{CollisionContext, FighterState};
use crate::fighter::*; use crate::fighter::*;
@@ -30,7 +29,7 @@ pub fn process_fast_fall(
pub fn integrate_gravity( pub fn integrate_gravity(
velocity: &mut FighterVelocity, velocity: &mut FighterVelocity,
attributes: &FighterAttributes, attributes: &FighterAttributes,
fast_fall: bool fast_fall: bool,
) { ) {
velocity.y -= attributes.gravity; velocity.y -= attributes.gravity;
@@ -94,10 +93,23 @@ pub fn update_standard_motion(
ctx: &mut crate::fighter::state::UpdateContext, ctx: &mut crate::fighter::state::UpdateContext,
airborne_common: &mut AirborneStateCommon, airborne_common: &mut AirborneStateCommon,
) { ) {
process_fast_fall(airborne_common, ctx.input, &mut ctx.velocity, ctx.fighter_attributes); process_fast_fall(
integrate_gravity(ctx.velocity, ctx.fighter_attributes, airborne_common.is_fast_falling); airborne_common,
ctx.input,
&mut ctx.velocity,
ctx.fighter_attributes,
);
integrate_gravity(
ctx.velocity,
ctx.fighter_attributes,
airborne_common.is_fast_falling,
);
apply_air_drift(ctx.velocity, ctx.fighter_attributes, ctx.input); apply_air_drift(ctx.velocity, ctx.fighter_attributes, ctx.input);
apply_air_motion(ctx.velocity, ctx.translation, ctx.prev_translation); apply_air_motion(
ctx.velocity,
ctx.translation,
ctx.prev_translation,
);
} }
pub fn collision_interrupt( pub fn collision_interrupt(
@@ -105,14 +117,14 @@ pub fn collision_interrupt(
landing_type: LandingType, landing_type: LandingType,
) -> Option<FighterState> { ) -> Option<FighterState> {
let res = ctx.air_collide_with_stage()?; let res = ctx.air_collide_with_stage()?;
ctx.translation.0 = res.hit_position - ctx.ecb.get_bottom_point(); let diff = res.hit_position - ctx.translation.0;
let grounded_common = GroundedStateCommon { ctx.ecb.bottom -= diff;
current_line_id: res.line_id, ctx.ecb.top -= diff;
}; ctx.ecb.left -= diff;
Some(FighterState::Land(LandingState::create( ctx.ecb.right -= diff;
grounded_common, ctx.translation.0 = res.hit_position;
landing_type, ctx.surface.land(res.line_id);
))) Some(FighterState::Land(LandingState::create(landing_type)))
} }
#[cfg(test)] #[cfg(test)]
+18 -7
View File
@@ -1,9 +1,16 @@
use crate::{ use crate::{
fighter::{ fighter::{
animation::AnimKind, state::{ animation::AnimKind,
CollisionContext, EnterContext, FighterState, FighterStateImpl, InterruptContext, UpdateContext, air::{self, AirborneStateCommon}, fall::FallState, land::LandingType, state::{
CollisionContext, EnterContext, FighterState, FighterStateImpl, InterruptContext,
UpdateContext,
air::{self, AirborneStateCommon},
fall::FallState,
land::LandingType,
}, },
}, input, math::vec::FGVec2, },
input,
math::vec::FGVec2,
}; };
#[derive(Debug, Clone, Hash)] #[derive(Debug, Clone, Hash)]
@@ -16,7 +23,9 @@ impl FighterStateImpl for AirDodgeState {
fn check_interrupt(&self, state_context: &mut InterruptContext) -> Option<FighterState> { fn check_interrupt(&self, state_context: &mut InterruptContext) -> Option<FighterState> {
if state_context.is_current_animation_finished() { if state_context.is_current_animation_finished() {
Some(FighterState::Fall(FallState::new(AirborneStateCommon::default()))) Some(FighterState::Fall(FallState::new(
AirborneStateCommon::default(),
)))
} else { } else {
None None
} }
@@ -46,11 +55,13 @@ impl FighterStateImpl for AirDodgeState {
self.direction * state_context.fighter_attributes.air_dodge_velocity; self.direction * state_context.fighter_attributes.air_dodge_velocity;
} }
fn is_visually_grounded<'a>( fn is_visually_grounded<'a>(&'a self) -> bool {
&'a self,
) -> bool {
false false
} }
fn surface_policy(&self) -> super::SurfacePolicy {
super::SurfacePolicy::Airborne(crate::fighter::surface::EcbLockPolicy::StartOnDetach)
}
} }
pub fn check_input(state_context: &InterruptContext) -> Option<FighterState> { pub fn check_input(state_context: &InterruptContext) -> Option<FighterState> {
+160
View File
@@ -0,0 +1,160 @@
use super::{
CollisionContext, EnterContext, FighterStateImpl, InterruptContext, UpdateContext, ground,
};
use crate::fighter::FighterSurfaceState;
use crate::fighter::animation::AnimKind;
use crate::fighter::state::air::AirborneStateCommon;
use crate::fighter::state::ground::{
grounded_movement_common_interrupts, grounded_movement_standstill_common_interrupts,
};
use crate::fighter::state::platform_pass::PlatformPassState;
use crate::fighter::state::{FighterState, dash, ground_attack, turn, walk};
use crate::input::FighterCommands;
use crate::stage::line::StagePolyType;
#[derive(Debug, Clone, Hash)]
pub enum CrouchSubState {
Entering { pass_queued: bool },
Idle,
Exiting,
}
#[derive(Debug, Clone, Hash)]
pub struct CrouchState {
sub_state: CrouchSubState,
}
pub fn crouch_idle_interrupts(state_context: &InterruptContext) -> Option<FighterState> {
if let Some(state) = ground_attack::check_interrupt(state_context) {
Some(state)
} else if let Some(state) = dash::check_input(state_context) {
Some(state)
} else if let Some(state) = turn::check_input(state_context) {
Some(state)
} else if let Some(state) = walk::check_input(state_context) {
Some(state)
} else {
None
}
}
pub fn crouch_entering_interrupts(state_context: &InterruptContext) -> Option<FighterState> {
if let Some(state) = ground_attack::check_interrupt(state_context) {
Some(state)
} else {
None
}
}
impl FighterStateImpl for CrouchState {
const NAME: &'static str = "Crouch";
fn check_interrupt(&self, state_context: &mut InterruptContext) -> Option<FighterState> {
if let Some(state) = grounded_movement_common_interrupts(state_context) {
return Some(state);
}
match self.sub_state {
CrouchSubState::Entering { pass_queued } => {
// pass
if let FighterSurfaceState::Grounded { line_id } = state_context.surface {
if let Some(stage_poly) = state_context
.stage_collision
.stage_polys
.get(line_id.polygon)
{
let is_inputting_crouch = -state_context.game_settings.input_common.run_stick_threshold > state_context.input.get_last_frame().movement.y;
let is_on_a_soft_platform = matches!(stage_poly.poly_type, StagePolyType::Platform);
if pass_queued && is_inputting_crouch && is_on_a_soft_platform
{
return Some(FighterState::PlatformPass(PlatformPassState::new(
AirborneStateCommon::default(),
line_id.polygon,
)));
}
}
}
// While entering the crouch animation we do not allow movement inputs, but we do allow attacks and jumps
if state_context.is_current_animation_finished() {
return Some(FighterState::Crouch(CrouchState {
sub_state: CrouchSubState::Idle,
}));
} else {
return crouch_entering_interrupts(state_context);
}
}
CrouchSubState::Idle => {
if state_context.input.get_last_frame().movement.y
> -state_context.game_settings.input_common.run_stick_threshold
{
return Some(FighterState::Crouch(CrouchState {
sub_state: CrouchSubState::Exiting,
}));
} else {
return crouch_idle_interrupts(state_context);
}
}
CrouchSubState::Exiting => {
if state_context.is_current_animation_finished() {
return grounded_movement_standstill_common_interrupts(state_context);
} else {
return crouch_idle_interrupts(state_context);
}
}
}
}
fn on_enter(&mut self, state_context: &mut EnterContext) {
match self.sub_state {
CrouchSubState::Entering { .. } => {
state_context.play_animation(AnimKind::CrouchEnter, false);
}
CrouchSubState::Idle => {
state_context.play_animation(AnimKind::CrouchIdle, true);
}
CrouchSubState::Exiting => {
state_context.play_animation(AnimKind::CrouchExit, false);
}
}
}
fn update(&mut self, state_context: &mut UpdateContext) {
if let CrouchSubState::Entering {
pass_queued,
} = &mut self.sub_state
{
if state_context
.input
.has_command(FighterCommands::SmashMoveDown)
{
state_context
.input
.clear_command(FighterCommands::SmashMoveDown);
*pass_queued = true;
}
}
ground::update_friction_motion(state_context);
}
fn check_collision_interrupt(
&mut self,
state_context: &mut CollisionContext,
) -> Option<FighterState> {
ground::collision_interrupt(state_context, false)
}
fn is_visually_grounded<'a>(&'a self) -> bool {
true
}
}
pub fn check_input(state_context: &InterruptContext) -> Option<FighterState> {
let input_frame = state_context.input.get_last_frame();
if input_frame.movement.y <= -state_context.game_settings.input_common.run_stick_threshold {
return Some(FighterState::Crouch(CrouchState {
sub_state: CrouchSubState::Entering { pass_queued: false },
}));
}
None
}
+12 -27
View File
@@ -5,52 +5,43 @@ use super::{
use crate::fighter::FighterFacingDirection; use crate::fighter::FighterFacingDirection;
use crate::fighter::animation::AnimKind; use crate::fighter::animation::AnimKind;
use crate::fighter::state::FighterState; use crate::fighter::state::FighterState;
use crate::fighter::state::ground::GroundedStateCommon;
use crate::input::FighterCommands::{SmashMoveLeft, SmashMoveRight}; use crate::input::FighterCommands::{SmashMoveLeft, SmashMoveRight};
#[derive(Debug, Clone, Hash)] #[derive(Debug, Clone, Hash)]
pub struct DashState { pub struct DashState {
direction: FighterFacingDirection, direction: FighterFacingDirection,
pub ground_common: GroundedStateCommon,
} }
impl DashState { impl DashState {
pub fn new(direction: FighterFacingDirection, ground_common: GroundedStateCommon) -> Self { pub fn new(direction: FighterFacingDirection) -> Self {
Self { Self { direction }
direction,
ground_common,
}
} }
} }
impl FighterStateImpl for DashState { impl FighterStateImpl for DashState {
const NAME: &'static str = "Dash"; const NAME: &'static str = "Dash";
fn check_interrupt(&self, ctx: &mut InterruptContext) -> Option<FighterState> { fn check_interrupt(&self, ctx: &mut InterruptContext) -> Option<FighterState> {
let ground = &self.ground_common;
let attributes = ctx.fighter_attributes; let attributes = ctx.fighter_attributes;
// A reverse dash can interrupt before IASA // A reverse dash can interrupt before IASA
if let Some(direction) = if let Some(direction) =
check_smash_input_with_dir(ctx).filter(|direction| *direction != self.direction) check_smash_input_with_dir(ctx).filter(|direction| *direction != self.direction)
{ {
return Some(FighterState::Dash(DashState::new( return Some(FighterState::Dash(DashState::new(direction)));
direction,
ground.clone(),
)));
} }
if let Some(state) = ground::grounded_movement_common_interrupts(ctx, ground) { if let Some(state) = ground::grounded_movement_common_interrupts(ctx) {
return Some(state); return Some(state);
} }
if ctx.is_current_animation_finished() { if ctx.is_current_animation_finished() {
return run::check_input(ctx, ground) return run::check_input(ctx)
.or_else(|| walk::check_input(ctx, ground)) .or_else(|| walk::check_input(ctx))
.or_else(|| wait::check_input(ctx, ground)); .or_else(|| wait::check_input(ctx));
} }
if ctx.get_current_animation_frame() > attributes.dash_acceleration_duration { if ctx.get_current_animation_frame() > attributes.dash_acceleration_duration {
return run::check_input(ctx, ground); return run::check_input(ctx);
} }
None None
@@ -106,12 +97,10 @@ impl FighterStateImpl for DashState {
&mut self, &mut self,
state_context: &mut CollisionContext, state_context: &mut CollisionContext,
) -> Option<FighterState> { ) -> Option<FighterState> {
ground::collision_interrupt(state_context, &mut self.ground_common, true) ground::collision_interrupt(state_context, true)
} }
fn is_visually_grounded<'a>( fn is_visually_grounded<'a>(&'a self) -> bool {
&'a self,
) -> bool {
true true
} }
} }
@@ -126,10 +115,6 @@ fn check_smash_input_with_dir(state_context: &InterruptContext) -> Option<Fighte
} }
} }
pub fn check_input( pub fn check_input(state_context: &InterruptContext) -> Option<FighterState> {
state_context: &InterruptContext, check_smash_input_with_dir(state_context).map(|dir| FighterState::Dash(DashState::new(dir)))
ground_common: &GroundedStateCommon,
) -> Option<FighterState> {
check_smash_input_with_dir(state_context)
.map(|dir| FighterState::Dash(DashState::new(dir, ground_common.clone())))
} }
+4 -1
View File
@@ -46,5 +46,8 @@ impl FighterStateImpl for FallState {
) -> bool { ) -> bool {
false false
} }
}
fn surface_policy(&self) -> super::SurfacePolicy {
super::SurfacePolicy::Airborne(crate::fighter::surface::EcbLockPolicy::StartOnDetach)
}
}
+128 -31
View File
@@ -3,7 +3,7 @@
//! bit-for-bit deterministic for rollback. //! bit-for-bit deterministic for rollback.
use crate::fighter::state::{ use crate::fighter::state::{
CollisionContext, FighterState, InterruptContext, air, dash, fall, ground_attack, turn, wait, walk, CollisionContext, FighterState, InterruptContext, air, crouch, dash, fall, ground_attack, turn, wait, walk,
}; };
use crate::fighter::{ use crate::fighter::{
FighterAttributes, FighterPreviousTranslation, FighterTranslation, FighterVelocity, FighterAttributes, FighterPreviousTranslation, FighterTranslation, FighterVelocity,
@@ -13,13 +13,6 @@ use crate::math::int::{FGWide, FGi32};
use crate::math::vec::FGVec2; use crate::math::vec::FGVec2;
use crate::stage::line::{StageLineID, StagePoly, StagePolyLineSegment, StagePolyLineSegmentType}; use crate::stage::line::{StageLineID, StagePoly, StagePolyLineSegment, StagePolyLineSegmentType};
use bevy::prelude::*;
#[derive(Reflect, Hash, Clone, Debug)]
pub struct GroundedStateCommon {
pub current_line_id: StageLineID,
}
pub fn apply_grounded_friction(friction: FGi32, ground_vel: FGi32) -> FGi32 { pub fn apply_grounded_friction(friction: FGi32, ground_vel: FGi32) -> FGi32 {
if friction.abs() > ground_vel.abs() { if friction.abs() > ground_vel.abs() {
-ground_vel -ground_vel
@@ -181,22 +174,23 @@ pub fn update_friction_motion(ctx: &mut crate::fighter::state::UpdateContext) {
pub fn collide_with_stage_grounded( pub fn collide_with_stage_grounded(
state_context: &mut CollisionContext, state_context: &mut CollisionContext,
ground_common: &mut GroundedStateCommon,
can_walk_off: bool, can_walk_off: bool,
) -> GroundedMotionResult { ) -> GroundedMotionResult {
let translation = &mut state_context.translation; let translation = &mut state_context.translation;
let ecb = state_context.ecb; let ecb = &state_context.ecb;
let stage_collision = state_context.stage_collision; let stage_collision = state_context.stage_collision;
let stage_poly = stage_collision let Some(current_line_id) = state_context.surface.line_id() else {
.stage_polys return GroundedMotionResult::InAir;
.get(ground_common.current_line_id.polygon); };
let stage_poly = stage_collision.stage_polys.get(current_line_id.polygon);
if let Some(stage_poly) = stage_poly { if let Some(stage_poly) = stage_poly {
let ecb_bottom_pos = translation.0 + ecb.get_bottom_point(); let ecb_bottom_pos = translation.0 + ecb.get_bottom_point();
match resolve_grounded_position( match resolve_grounded_position(
stage_poly, stage_poly,
ground_common.current_line_id.segment, current_line_id.segment,
ecb_bottom_pos, ecb_bottom_pos,
can_walk_off, can_walk_off,
) { ) {
@@ -216,30 +210,43 @@ pub fn collide_with_stage_grounded(
.0 .0
.project_onto_normalized(current_segment.normal) .project_onto_normalized(current_segment.normal)
}; };
ground_common.current_line_id.segment = segment_idx; state_context.surface.land(StageLineID {
polygon: current_line_id.polygon,
segment: segment_idx,
});
GroundedMotionResult::InGround GroundedMotionResult::InGround
} }
GroundedPositionResult::InAir => GroundedMotionResult::InAir, GroundedPositionResult::InAir => {
state_context.surface.apply_airborne_policy(
crate::fighter::surface::EcbLockPolicy::StartOnDetach,
state_context.leave_ground_ecb_lock_duration,
);
GroundedMotionResult::InAir
}
} }
} else { } else {
state_context.surface.apply_airborne_policy(
crate::fighter::surface::EcbLockPolicy::StartOnDetach,
state_context.leave_ground_ecb_lock_duration,
);
GroundedMotionResult::InAir GroundedMotionResult::InAir
} }
} }
pub fn collision_interrupt( pub fn collision_interrupt(ctx: &mut CollisionContext, can_walk_off: bool) -> Option<FighterState> {
ctx: &mut CollisionContext, match collide_with_stage_grounded(ctx, can_walk_off) {
common: &mut GroundedStateCommon,
can_walk_off: bool,
) -> Option<FighterState> {
match collide_with_stage_grounded(ctx, common, can_walk_off) {
GroundedMotionResult::InGround => None, GroundedMotionResult::InGround => None,
GroundedMotionResult::InAir => Some(FighterState::Fall(fall::FallState::new(air::AirborneStateCommon::default()))), GroundedMotionResult::InAir => Some(FighterState::Fall(fall::FallState::new(
air::AirborneStateCommon::default(),
))),
} }
} }
#[cfg(test)] #[cfg(test)]
mod tests { mod tests {
use super::*; use super::*;
use crate::fighter::ecb::FighterPreviousECB;
use crate::fighter::{FighterECB, FighterSurfaceState};
use crate::stage::line::StagePolyType; use crate::stage::line::StagePolyType;
fn two_segment_floor() -> StagePoly { fn two_segment_floor() -> StagePoly {
@@ -346,28 +353,118 @@ mod tests {
GroundedPositionResult::InAir GroundedPositionResult::InAir
)); ));
} }
#[test]
fn grounded_collision_updates_surface_segment() {
let stage_collision = crate::stage::line::StageCollision {
stage_polys: vec![two_segment_floor()],
};
let mut surface = FighterSurfaceState::Grounded {
line_id: StageLineID {
polygon: 0,
segment: 0,
},
};
let mut translation = FighterTranslation(FGVec2::lit("11", "0"));
let previous_translation = FighterPreviousTranslation(translation.0);
let mut velocity = FighterVelocity::default();
let mut ecb = FighterECB {
bottom: FGVec2::lit("0.0", "-0.5"),
top: FGVec2::lit("0.0", "0.5"),
left: FGVec2::lit("-0.5", "0.0"),
right: FGVec2::lit("0.5", "0.0"),
};
let previous_ecb = FighterPreviousECB::from(ecb);
let mut context = CollisionContext {
translation: &mut translation,
prev_translation: &previous_translation,
velocity: &mut velocity,
surface: &mut surface,
ecb: &mut ecb,
prev_ecb: &previous_ecb,
stage_collision: &stage_collision,
leave_ground_ecb_lock_duration: 10,
};
assert!(matches!(
collide_with_stage_grounded(&mut context, true),
GroundedMotionResult::InGround
));
assert_eq!(
surface.line_id(),
Some(StageLineID {
polygon: 0,
segment: 1,
})
);
}
#[test]
fn walking_off_edge_clears_surface_contact() {
let stage_collision = crate::stage::line::StageCollision {
stage_polys: vec![StagePoly::build(
StagePolyType::Platform,
&[
(FGVec2::lit("0", "0"), StagePolyLineSegmentType::Floor),
(FGVec2::lit("10", "0"), StagePolyLineSegmentType::Floor),
],
)],
};
let mut surface = FighterSurfaceState::Grounded {
line_id: StageLineID {
polygon: 0,
segment: 0,
},
};
let mut translation = FighterTranslation(FGVec2::lit("11", "0"));
let previous_translation = FighterPreviousTranslation(translation.0);
let mut velocity = FighterVelocity::default();
let mut ecb = FighterECB {
bottom: FGVec2::lit("0.0", "-0.5"),
top: FGVec2::lit("0.0", "0.5"),
left: FGVec2::lit("-0.5", "0.0"),
right: FGVec2::lit("0.5", "0.0"),
};
let previous_ecb = FighterPreviousECB::from(ecb);
let mut context = CollisionContext {
translation: &mut translation,
prev_translation: &previous_translation,
velocity: &mut velocity,
surface: &mut surface,
ecb: &mut ecb,
prev_ecb: &previous_ecb,
stage_collision: &stage_collision,
leave_ground_ecb_lock_duration: 10,
};
assert!(matches!(
collide_with_stage_grounded(&mut context, true),
GroundedMotionResult::InAir
));
assert!(matches!(surface, FighterSurfaceState::Airborne { .. }));
}
} }
pub fn grounded_movement_common_interrupts( pub fn grounded_movement_common_interrupts(
state_context: &InterruptContext, state_context: &InterruptContext,
ground_common: &GroundedStateCommon,
) -> Option<FighterState> { ) -> Option<FighterState> {
super::jump::check_input(state_context, ground_common) super::jump::check_input(state_context)
} }
pub fn grounded_movement_standstill_common_interrupts( pub fn grounded_movement_standstill_common_interrupts(
state_context: &InterruptContext, state_context: &InterruptContext,
ground_common: &GroundedStateCommon,
) -> Option<FighterState> { ) -> Option<FighterState> {
if let Some(state) = ground_attack::check_interrupt(state_context, &ground_common) { if let Some(state) = ground_attack::check_interrupt(state_context) {
Some(state) Some(state)
} else if let Some(state) = dash::check_input(state_context, &ground_common) { } else if let Some(state) = dash::check_input(state_context) {
Some(state) Some(state)
} else if let Some(state) = turn::check_input(state_context, &ground_common) { } else if let Some(state) = turn::check_input(state_context) {
Some(state) Some(state)
} else if let Some(state) = walk::check_input(state_context, &ground_common) { } else if let Some(state) = crouch::check_input(state_context) {
Some(state) Some(state)
} else if let Some(state) = wait::check_input(state_context, &ground_common) { } else if let Some(state) = walk::check_input(state_context) {
Some(state)
} else if let Some(state) = wait::check_input(state_context) {
Some(state) Some(state)
} else { } else {
None None
+5 -14
View File
@@ -2,14 +2,13 @@ use crate::fighter::{
attack::{AttackKind, update_active_hitbox_list}, attack::{AttackKind, update_active_hitbox_list},
state::{ state::{
CollisionContext, EnterContext, ExitContext, FighterState, FighterStateImpl, CollisionContext, EnterContext, ExitContext, FighterState, FighterStateImpl,
InterruptContext, UpdateContext, ground::GroundedStateCommon, wait::WaitState, InterruptContext, UpdateContext, wait::WaitState,
}, },
}; };
#[derive(Clone, Debug, Hash)] #[derive(Clone, Debug, Hash)]
pub struct GroundAttackState { pub struct GroundAttackState {
pub attack_kind: AttackKind, pub attack_kind: AttackKind,
pub grounded_common: GroundedStateCommon,
} }
impl FighterStateImpl for GroundAttackState { impl FighterStateImpl for GroundAttackState {
@@ -17,9 +16,7 @@ impl FighterStateImpl for GroundAttackState {
fn check_interrupt(&self, state_context: &mut InterruptContext) -> Option<FighterState> { fn check_interrupt(&self, state_context: &mut InterruptContext) -> Option<FighterState> {
if state_context.is_current_animation_finished() { if state_context.is_current_animation_finished() {
Some(FighterState::Wait(WaitState { Some(FighterState::Wait(WaitState))
grounded_common: self.grounded_common.clone(),
}))
} else { } else {
None None
} }
@@ -53,7 +50,7 @@ impl FighterStateImpl for GroundAttackState {
active_hitboxes: Vec::new(), active_hitboxes: Vec::new(),
solved_hitboxes: Vec::new(), solved_hitboxes: Vec::new(),
hit_fighters: Vec::new(), hit_fighters: Vec::new(),
stalled: false stalled: false,
}); });
} }
@@ -68,17 +65,12 @@ impl FighterStateImpl for GroundAttackState {
None None
} }
fn is_visually_grounded<'a>( fn is_visually_grounded<'a>(&'a self) -> bool {
&'a self,
) -> bool {
true true
} }
} }
pub fn check_interrupt( pub fn check_interrupt(state_context: &InterruptContext) -> Option<FighterState> {
state_context: &InterruptContext,
grounded_common: &GroundedStateCommon,
) -> Option<FighterState> {
if state_context if state_context
.input .input
.has_command(crate::input::FighterCommands::Attack) .has_command(crate::input::FighterCommands::Attack)
@@ -89,7 +81,6 @@ pub fn check_interrupt(
.to_attack_kind_grounded(); .to_attack_kind_grounded();
Some(FighterState::GroundAttack(GroundAttackState { Some(FighterState::GroundAttack(GroundAttackState {
attack_kind, attack_kind,
grounded_common: grounded_common.clone(),
})) }))
} else { } else {
None None
+20 -17
View File
@@ -7,7 +7,7 @@ use crate::{
InterruptContext, UpdateContext, InterruptContext, UpdateContext,
air::{self, AirborneStateCommon}, air::{self, AirborneStateCommon},
fall::FallState, fall::FallState,
ground::{GroundedStateCommon, collision_interrupt}, ground::collision_interrupt,
land::LandingType, land::LandingType,
wait::WaitState, wait::WaitState,
}, },
@@ -17,7 +17,7 @@ use crate::{
#[derive(Clone, Debug, Hash)] #[derive(Clone, Debug, Hash)]
pub enum HitstopStateKind { pub enum HitstopStateKind {
Grounded(GroundedStateCommon), Grounded,
Airborne, Airborne,
} }
@@ -43,7 +43,7 @@ impl FighterStateImpl for HitstunState {
fn name(&self) -> String { fn name(&self) -> String {
let hitstop_kind = match self.hitstop_kind { let hitstop_kind = match self.hitstop_kind {
HitstopStateKind::Grounded(_) => "Grounded", HitstopStateKind::Grounded => "Grounded",
HitstopStateKind::Airborne => "Airborne", HitstopStateKind::Airborne => "Airborne",
}; };
@@ -58,14 +58,10 @@ impl FighterStateImpl for HitstunState {
fn check_interrupt(&self, state_context: &mut InterruptContext) -> Option<FighterState> { fn check_interrupt(&self, state_context: &mut InterruptContext) -> Option<FighterState> {
if state_context.get_current_animation_frame() > self.hit_reaction.hitstun_frames { if state_context.get_current_animation_frame() > self.hit_reaction.hitstun_frames {
match &self.hitstop_kind { match &self.hitstop_kind {
HitstopStateKind::Grounded(grounded_state_common) => { HitstopStateKind::Grounded => Some(FighterState::Wait(WaitState)),
Some(FighterState::Wait(WaitState { HitstopStateKind::Airborne => Some(FighterState::Fall(FallState::new(
grounded_common: grounded_state_common.clone(), AirborneStateCommon::default(),
})) ))),
}
HitstopStateKind::Airborne => {
Some(FighterState::Fall(FallState::new(AirborneStateCommon::default())))
}
} }
} else { } else {
None None
@@ -85,7 +81,7 @@ impl FighterStateImpl for HitstunState {
} }
match self.hitstop_kind { match self.hitstop_kind {
HitstopStateKind::Grounded(_) => {} HitstopStateKind::Grounded => {}
HitstopStateKind::Airborne => { HitstopStateKind::Airborne => {
air::integrate_gravity(ctx.velocity, ctx.fighter_attributes, false); air::integrate_gravity(ctx.velocity, ctx.fighter_attributes, false);
} }
@@ -103,7 +99,7 @@ impl FighterStateImpl for HitstunState {
fn on_enter(&mut self, state_context: &mut EnterContext) { fn on_enter(&mut self, state_context: &mut EnterContext) {
let animation = match self.hitstop_kind { let animation = match self.hitstop_kind {
HitstopStateKind::Grounded(_) => AnimKind::FlinchGround, HitstopStateKind::Grounded => AnimKind::FlinchGround,
HitstopStateKind::Airborne => AnimKind::FlinchAir, HitstopStateKind::Airborne => AnimKind::FlinchAir,
}; };
state_context.play_animation(animation, false); state_context.play_animation(animation, false);
@@ -116,9 +112,7 @@ impl FighterStateImpl for HitstunState {
state_context: &mut CollisionContext, state_context: &mut CollisionContext,
) -> Option<FighterState> { ) -> Option<FighterState> {
match &mut self.hitstop_kind { match &mut self.hitstop_kind {
HitstopStateKind::Grounded(grounded_state_common) => { HitstopStateKind::Grounded => collision_interrupt(state_context, true),
collision_interrupt(state_context, grounded_state_common, true)
}
HitstopStateKind::Airborne => { HitstopStateKind::Airborne => {
air::collision_interrupt(state_context, LandingType::Normal) air::collision_interrupt(state_context, LandingType::Normal)
} }
@@ -127,8 +121,17 @@ impl FighterStateImpl for HitstunState {
fn is_visually_grounded<'a>(&'a self) -> bool { fn is_visually_grounded<'a>(&'a self) -> bool {
match self.hitstop_kind { match self.hitstop_kind {
HitstopStateKind::Grounded(_) => true, HitstopStateKind::Grounded => true,
HitstopStateKind::Airborne => false, HitstopStateKind::Airborne => false,
} }
} }
fn surface_policy(&self) -> super::SurfacePolicy {
match self.hitstop_kind {
HitstopStateKind::Grounded => super::SurfacePolicy::Grounded,
HitstopStateKind::Airborne => super::SurfacePolicy::Airborne(
crate::fighter::surface::EcbLockPolicy::StartOnDetach,
),
}
}
} }
+32 -21
View File
@@ -2,10 +2,17 @@ use bevy::prelude::*;
use crate::{ use crate::{
fighter::{ fighter::{
animation::AnimKind, state::{ animation::AnimKind,
CollisionContext, EnterContext, FighterState, FighterStateImpl, InterruptContext, UpdateContext, air::{self, AirborneStateCommon}, air_dodge::{self, AirDodgeState}, ground::{self, GroundedStateCommon}, state::{
CollisionContext, EnterContext, FighterState, FighterStateImpl, InterruptContext,
UpdateContext,
air::{self, AirborneStateCommon},
air_dodge::{self, AirDodgeState},
ground,
}, },
}, input::FighterCommands, math::{int::FGi32, vec::FGVec2}, },
input::FighterCommands,
math::{int::FGi32, vec::FGVec2},
}; };
#[derive(Debug, Hash, Clone, Copy)] #[derive(Debug, Hash, Clone, Copy)]
pub enum JumpType { pub enum JumpType {
@@ -22,14 +29,12 @@ pub struct JumpState {
#[derive(Debug, Clone, Hash)] #[derive(Debug, Clone, Hash)]
pub struct JumpSquatState { pub struct JumpSquatState {
pub grounded_common: GroundedStateCommon,
pub duration_counter: u32, pub duration_counter: u32,
} }
impl JumpSquatState { impl JumpSquatState {
pub fn create(grounded_common: GroundedStateCommon) -> Self { pub fn create() -> Self {
Self { Self {
grounded_common,
duration_counter: 0, duration_counter: 0,
} }
} }
@@ -69,7 +74,10 @@ impl FighterStateImpl for JumpSquatState {
} else { } else {
JumpType::ShortHop JumpType::ShortHop
}; };
Some(FighterState::Jump(JumpState { jump_type, airborne_state_common: AirborneStateCommon::default() })) Some(FighterState::Jump(JumpState {
jump_type,
airborne_state_common: AirborneStateCommon::default(),
}))
} else { } else {
None None
} }
@@ -84,7 +92,7 @@ impl FighterStateImpl for JumpSquatState {
&mut self, &mut self,
state_context: &mut CollisionContext, state_context: &mut CollisionContext,
) -> Option<FighterState> { ) -> Option<FighterState> {
ground::collision_interrupt(state_context, &mut self.grounded_common, false) ground::collision_interrupt(state_context, false)
} }
fn on_enter(&mut self, state_context: &mut EnterContext) { fn on_enter(&mut self, state_context: &mut EnterContext) {
@@ -92,9 +100,7 @@ impl FighterStateImpl for JumpSquatState {
state_context.input.clear_command(FighterCommands::Jump); state_context.input.clear_command(FighterCommands::Jump);
} }
fn is_visually_grounded<'a>( fn is_visually_grounded<'a>(&'a self) -> bool {
&'a self,
) -> bool {
true true
} }
} }
@@ -105,7 +111,7 @@ impl FighterStateImpl for JumpState {
if state_context.input.has_command(FighterCommands::Jump) { if state_context.input.has_command(FighterCommands::Jump) {
Some(FighterState::Jump(JumpState { Some(FighterState::Jump(JumpState {
jump_type: JumpType::DoubleJump, jump_type: JumpType::DoubleJump,
airborne_state_common: AirborneStateCommon::default() airborne_state_common: AirborneStateCommon::default(),
})) }))
} else { } else {
air_dodge::check_input(state_context) air_dodge::check_input(state_context)
@@ -177,21 +183,26 @@ impl FighterStateImpl for JumpState {
) )
} }
fn is_visually_grounded<'a>( fn is_visually_grounded<'a>(&'a self) -> bool {
&'a self,
) -> bool {
false false
} }
fn surface_policy(&self) -> super::SurfacePolicy {
use crate::fighter::surface::EcbLockPolicy;
match self.jump_type {
JumpType::DoubleJump => super::SurfacePolicy::Airborne(EcbLockPolicy::Restart),
JumpType::ShortHop | JumpType::LongJump => {
super::SurfacePolicy::Airborne(EcbLockPolicy::StartOnDetach)
}
}
}
} }
pub fn check_input( pub fn check_input(state_context: &InterruptContext) -> Option<FighterState> {
state_context: &InterruptContext,
ground_common: &GroundedStateCommon,
) -> Option<FighterState> {
state_context state_context
.input .input
.has_command(FighterCommands::Jump) .has_command(FighterCommands::Jump)
.then(|| FighterState::JumpSquat(JumpSquatState::create(ground_common.clone()))) .then(|| FighterState::JumpSquat(JumpSquatState::create()))
} }
pub fn check_input_double_jump(state_context: &InterruptContext) -> Option<FighterState> { pub fn check_input_double_jump(state_context: &InterruptContext) -> Option<FighterState> {
@@ -201,7 +212,7 @@ pub fn check_input_double_jump(state_context: &InterruptContext) -> Option<Fight
.then(|| { .then(|| {
FighterState::Jump(JumpState { FighterState::Jump(JumpState {
jump_type: JumpType::DoubleJump, jump_type: JumpType::DoubleJump,
airborne_state_common: AirborneStateCommon::default() airborne_state_common: AirborneStateCommon::default(),
}) })
}) })
} }
+9 -15
View File
@@ -3,7 +3,7 @@ use crate::fighter::{
state::{ state::{
CollisionContext, EnterContext, FighterState, FighterStateImpl, InterruptContext, CollisionContext, EnterContext, FighterState, FighterStateImpl, InterruptContext,
UpdateContext, dash, UpdateContext, dash,
ground::{self, GroundedStateCommon, grounded_movement_standstill_common_interrupts}, ground::{self, grounded_movement_standstill_common_interrupts},
walk, walk,
}, },
}; };
@@ -16,16 +16,12 @@ pub enum LandingType {
#[derive(Debug, Clone, Hash)] #[derive(Debug, Clone, Hash)]
pub struct LandingState { pub struct LandingState {
pub grounded_common: GroundedStateCommon,
pub landing_type: LandingType, pub landing_type: LandingType,
} }
impl LandingState { impl LandingState {
pub fn create(grounded_common: GroundedStateCommon, landing_type: LandingType) -> Self { pub fn create(landing_type: LandingType) -> Self {
Self { Self { landing_type }
grounded_common,
landing_type,
}
} }
} }
@@ -34,14 +30,14 @@ impl FighterStateImpl for LandingState {
fn check_interrupt(&self, state_context: &mut InterruptContext) -> Option<FighterState> { fn check_interrupt(&self, state_context: &mut InterruptContext) -> Option<FighterState> {
if state_context.is_current_animation_finished() { if state_context.is_current_animation_finished() {
grounded_movement_standstill_common_interrupts(state_context, &self.grounded_common) grounded_movement_standstill_common_interrupts(state_context)
} else if state_context.get_current_animation_frame() } else if state_context.get_current_animation_frame()
>= state_context.fighter_attributes.landing_iasa >= state_context.fighter_attributes.landing_iasa
&& let LandingType::Normal = self.landing_type && let LandingType::Normal = self.landing_type
{ {
dash::check_input(state_context, &self.grounded_common).or_else(|| { dash::check_input(state_context).or_else(|| {
ground::grounded_movement_common_interrupts(state_context, &self.grounded_common) ground::grounded_movement_common_interrupts(state_context)
.or_else(|| walk::check_input(state_context, &self.grounded_common)) .or_else(|| walk::check_input(state_context))
}) })
} else { } else {
None None
@@ -56,7 +52,7 @@ impl FighterStateImpl for LandingState {
&mut self, &mut self,
state_context: &mut CollisionContext, state_context: &mut CollisionContext,
) -> Option<FighterState> { ) -> Option<FighterState> {
ground::collision_interrupt(state_context, &mut self.grounded_common, true) ground::collision_interrupt(state_context, true)
} }
fn on_enter(&mut self, state_context: &mut EnterContext) { fn on_enter(&mut self, state_context: &mut EnterContext) {
@@ -70,9 +66,7 @@ impl FighterStateImpl for LandingState {
}; };
} }
fn is_visually_grounded<'a>( fn is_visually_grounded<'a>(&'a self) -> bool {
&'a self,
) -> bool {
true true
} }
} }
+82 -36
View File
@@ -7,7 +7,8 @@ use bevy::prelude::*;
use crate::fighter::animation::{AnimKind, FighterAnimationFrame}; use crate::fighter::animation::{AnimKind, FighterAnimationFrame};
use crate::fighter::attack::{ use crate::fighter::attack::{
FighterAttackScriptAssets, FighterKnockbackVelocity, FighterPendingHitReaction, FighterStaleMoveQueue, HitStop, FighterAttackScriptAssets, FighterKnockbackVelocity, FighterPendingHitReaction,
FighterStaleMoveQueue, HitStop,
}; };
use crate::fighter::attributes::FighterAttributes; use crate::fighter::attributes::FighterAttributes;
use crate::fighter::baked_animation::BakedFighterAnimations; use crate::fighter::baked_animation::BakedFighterAnimations;
@@ -16,8 +17,11 @@ use crate::fighter::manifest::FighterManifest;
use crate::fighter::state::hitstun::HitstunState; use crate::fighter::state::hitstun::HitstunState;
use crate::fighter::visual::FighterAnimations; use crate::fighter::visual::FighterAnimations;
use crate::fighter::{ use crate::fighter::{
Fighter, FighterECB, FighterFacingDirection, FighterHitboxes, FighterHitstop, FighterHitstopShake, FighterHitstopShakeKind, FighterHitstopShakeRole, FighterPreviousTranslation, FighterTranslation, FighterVelocity, Fighter, FighterECB, FighterFacingDirection, FighterHitboxes, FighterHitstop,
FighterHitstopShake, FighterHitstopShakeKind, FighterHitstopShakeRole,
FighterPreviousTranslation, FighterSurfaceState, FighterTranslation, FighterVelocity,
}; };
use crate::fighter::surface::EcbLockPolicy;
use crate::game_settings::GameSettings; use crate::game_settings::GameSettings;
use crate::input::FighterInput; use crate::input::FighterInput;
use crate::math::int::FGi32; use crate::math::int::FGi32;
@@ -37,6 +41,14 @@ pub mod run;
pub mod turn; pub mod turn;
pub mod wait; pub mod wait;
pub mod walk; pub mod walk;
pub mod crouch;
pub mod platform_pass;
#[derive(Clone, Copy, Debug, Hash, PartialEq, Eq)]
pub enum SurfacePolicy {
Grounded,
Airborne(EcbLockPolicy),
}
macro_rules! fighter_states { macro_rules! fighter_states {
($($variant:ident => $ty:ty),* $(,)?) => { ($($variant:ident => $ty:ty),* $(,)?) => {
@@ -69,6 +81,10 @@ macro_rules! fighter_states {
pub fn is_visually_grounded(&self) -> bool { pub fn is_visually_grounded(&self) -> bool {
match self { $(Self::$variant(s) => s.is_visually_grounded()),* } match self { $(Self::$variant(s) => s.is_visually_grounded()),* }
} }
pub fn surface_policy(&self) -> SurfacePolicy {
match self { $(Self::$variant(s) => s.surface_policy()),* }
}
} }
$(impl From<$ty> for FighterState { $(impl From<$ty> for FighterState {
@@ -95,9 +111,11 @@ pub trait FighterStateImpl: Sized {
None None
} }
fn is_visually_grounded<'a>( fn is_visually_grounded<'a>(&'a self) -> bool;
&'a self,
) -> bool; fn surface_policy(&self) -> SurfacePolicy {
SurfacePolicy::Grounded
}
} }
pub struct AnimationStatus { pub struct AnimationStatus {
@@ -110,7 +128,9 @@ pub struct InterruptContext<'a> {
pub facing_direction: &'a mut FighterFacingDirection, pub facing_direction: &'a mut FighterFacingDirection,
pub game_settings: &'a GameSettings, pub game_settings: &'a GameSettings,
pub fighter_attributes: &'a FighterAttributes, pub fighter_attributes: &'a FighterAttributes,
pub surface: &'a FighterSurfaceState,
pub animation: AnimationStatus, pub animation: AnimationStatus,
pub stage_collision: &'a StageCollision,
} }
impl InterruptContext<'_> { impl InterruptContext<'_> {
@@ -131,8 +151,10 @@ pub struct EnterContext<'a> {
pub stale_move_queue: &'a mut FighterStaleMoveQueue, pub stale_move_queue: &'a mut FighterStaleMoveQueue,
pub facing_direction: &'a mut FighterFacingDirection, pub facing_direction: &'a mut FighterFacingDirection,
pub animation_frame: &'a mut FighterAnimationFrame, pub animation_frame: &'a mut FighterAnimationFrame,
pub surface: &'a mut FighterSurfaceState,
pub fighter_attributes: &'a FighterAttributes, pub fighter_attributes: &'a FighterAttributes,
pub attack_script_assets: &'a FighterAttackScriptAssets, pub attack_script_assets: &'a FighterAttackScriptAssets,
pub game_settings: &'a GameSettings,
} }
impl EnterContext<'_> { impl EnterContext<'_> {
@@ -143,6 +165,7 @@ impl EnterContext<'_> {
pub struct ExitContext<'a> { pub struct ExitContext<'a> {
pub hitboxes: &'a mut FighterHitboxes, pub hitboxes: &'a mut FighterHitboxes,
pub surface: &'a mut FighterSurfaceState,
} }
pub struct UpdateContext<'a> { pub struct UpdateContext<'a> {
@@ -151,6 +174,7 @@ pub struct UpdateContext<'a> {
pub input: &'a mut FighterInput, pub input: &'a mut FighterInput,
pub hitboxes: &'a mut FighterHitboxes, pub hitboxes: &'a mut FighterHitboxes,
pub velocity: &'a mut FighterVelocity, pub velocity: &'a mut FighterVelocity,
pub surface: &'a mut FighterSurfaceState,
pub knockback_velocity: &'a mut FighterKnockbackVelocity, pub knockback_velocity: &'a mut FighterKnockbackVelocity,
pub game_settings: &'a GameSettings, pub game_settings: &'a GameSettings,
pub animation_frame: u32, pub animation_frame: u32,
@@ -170,21 +194,25 @@ pub struct CollisionContext<'a> {
pub translation: &'a mut FighterTranslation, pub translation: &'a mut FighterTranslation,
pub prev_translation: &'a FighterPreviousTranslation, pub prev_translation: &'a FighterPreviousTranslation,
pub velocity: &'a mut FighterVelocity, pub velocity: &'a mut FighterVelocity,
pub ecb: &'a FighterECB, pub surface: &'a mut FighterSurfaceState,
pub ecb: &'a mut FighterECB,
pub prev_ecb: &'a FighterPreviousECB, pub prev_ecb: &'a FighterPreviousECB,
pub stage_collision: &'a StageCollision, pub stage_collision: &'a StageCollision,
pub leave_ground_ecb_lock_duration: u32,
} }
impl CollisionContext<'_> { impl CollisionContext<'_> {
pub fn air_collide_with_stage( pub fn air_collide_with_stage(
&self, &self,
) -> Option<crate::fighter::collision::AirCollisionWithStageResult> { ) -> Option<crate::fighter::collision::AirCollisionWithStageResult> {
let ignored_polys = self.surface.ignored_polygon_ids();
crate::fighter::collision::air_collide_with_stage( crate::fighter::collision::air_collide_with_stage(
self.prev_translation, self.prev_translation,
self.translation, self.translation,
self.prev_ecb, self.prev_ecb,
self.ecb, self.ecb,
self.stage_collision, self.stage_collision,
&ignored_polys,
) )
} }
} }
@@ -192,6 +220,8 @@ impl CollisionContext<'_> {
fighter_states! { fighter_states! {
Wait => wait::WaitState, Wait => wait::WaitState,
Walk => walk::WalkState, Walk => walk::WalkState,
PlatformPass => platform_pass::PlatformPassState,
Crouch => crouch::CrouchState,
Dash => dash::DashState, Dash => dash::DashState,
Run => run::RunState, Run => run::RunState,
Fall => fall::FallState, Fall => fall::FallState,
@@ -212,9 +242,10 @@ pub struct FighterFrameQuery {
pub input: &'static mut FighterInput, pub input: &'static mut FighterInput,
pub hitboxes: &'static mut FighterHitboxes, pub hitboxes: &'static mut FighterHitboxes,
pub velocity: &'static mut FighterVelocity, pub velocity: &'static mut FighterVelocity,
pub surface: &'static mut FighterSurfaceState,
pub knockback_velocity: &'static mut FighterKnockbackVelocity, pub knockback_velocity: &'static mut FighterKnockbackVelocity,
pub stale_move_queue: &'static mut FighterStaleMoveQueue, pub stale_move_queue: &'static mut FighterStaleMoveQueue,
pub ecb: &'static FighterECB, pub ecb: &'static mut FighterECB,
pub prev_ecb: &'static FighterPreviousECB, pub prev_ecb: &'static FighterPreviousECB,
pub facing_direction: &'static mut FighterFacingDirection, pub facing_direction: &'static mut FighterFacingDirection,
pub animation_frame: &'static mut FighterAnimationFrame, pub animation_frame: &'static mut FighterAnimationFrame,
@@ -244,6 +275,7 @@ impl<'w, 's> FighterFrameQueryItem<'w, 's> {
animations: &'a FighterAnimations, animations: &'a FighterAnimations,
baked_animations: &'a Assets<BakedFighterAnimations>, baked_animations: &'a Assets<BakedFighterAnimations>,
attributes: &'a FighterAttributes, attributes: &'a FighterAttributes,
stage_collision: &'a StageCollision,
) -> InterruptContext<'a> { ) -> InterruptContext<'a> {
let animation = self.animation_status(animations, baked_animations); let animation = self.animation_status(animations, baked_animations);
InterruptContext { InterruptContext {
@@ -252,6 +284,8 @@ impl<'w, 's> FighterFrameQueryItem<'w, 's> {
game_settings, game_settings,
fighter_attributes: attributes, fighter_attributes: attributes,
animation, animation,
surface: &self.surface,
stage_collision,
} }
} }
@@ -259,6 +293,7 @@ impl<'w, 's> FighterFrameQueryItem<'w, 's> {
&'a mut self, &'a mut self,
attributes: &'a FighterAttributes, attributes: &'a FighterAttributes,
attack_script_assets: &'a FighterAttackScriptAssets, attack_script_assets: &'a FighterAttackScriptAssets,
game_settings: &'a GameSettings,
) -> EnterContext<'a> { ) -> EnterContext<'a> {
EnterContext { EnterContext {
input: &mut self.input, input: &mut self.input,
@@ -268,14 +303,17 @@ impl<'w, 's> FighterFrameQueryItem<'w, 's> {
stale_move_queue: &mut self.stale_move_queue, stale_move_queue: &mut self.stale_move_queue,
facing_direction: &mut self.facing_direction, facing_direction: &mut self.facing_direction,
animation_frame: &mut self.animation_frame, animation_frame: &mut self.animation_frame,
surface: &mut self.surface,
fighter_attributes: attributes, fighter_attributes: attributes,
attack_script_assets, attack_script_assets,
game_settings
} }
} }
fn exit_context(&mut self) -> ExitContext<'_> { fn exit_context(&mut self) -> ExitContext<'_> {
ExitContext { ExitContext {
hitboxes: &mut self.hitboxes, hitboxes: &mut self.hitboxes,
surface: &mut self.surface,
} }
} }
@@ -292,27 +330,31 @@ impl<'w, 's> FighterFrameQueryItem<'w, 's> {
input: &mut self.input, input: &mut self.input,
hitboxes: &mut self.hitboxes, hitboxes: &mut self.hitboxes,
velocity: &mut self.velocity, velocity: &mut self.velocity,
surface: &mut self.surface,
knockback_velocity: &mut self.knockback_velocity, knockback_velocity: &mut self.knockback_velocity,
game_settings, game_settings,
animation_frame: self.animation_frame.frame, animation_frame: self.animation_frame.frame,
fighter_attributes: attributes, fighter_attributes: attributes,
attack_scripts, attack_scripts,
attack_script_assets, attack_script_assets,
facing_direction: &self.facing_direction facing_direction: &self.facing_direction,
} }
} }
fn collision_context<'a>( fn collision_context<'a>(
&'a mut self, &'a mut self,
stage_collision: &'a StageCollision, stage_collision: &'a StageCollision,
game_settings: &'a GameSettings,
) -> CollisionContext<'a> { ) -> CollisionContext<'a> {
CollisionContext { CollisionContext {
translation: &mut self.translation, translation: &mut self.translation,
prev_translation: &self.prev_translation, prev_translation: &self.prev_translation,
velocity: &mut self.velocity, velocity: &mut self.velocity,
ecb: &self.ecb, surface: &mut self.surface,
ecb: &mut self.ecb,
prev_ecb: &self.prev_ecb, prev_ecb: &self.prev_ecb,
stage_collision, stage_collision,
leave_ground_ecb_lock_duration: game_settings.fighter_common.leave_ground_ecb_frame_lock_duration
} }
} }
} }
@@ -367,12 +409,19 @@ fn transition_state(
frame: &mut FighterFrameQueryItem, frame: &mut FighterFrameQueryItem,
attributes: &FighterAttributes, attributes: &FighterAttributes,
attack_script_assets: &FighterAttackScriptAssets, attack_script_assets: &FighterAttackScriptAssets,
game_settings: &GameSettings,
) { ) {
let old_name = current.name(); let old_name = current.name();
let new_name = next.name(); let new_name = next.name();
current.on_exit(&mut frame.exit_context()); current.on_exit(&mut frame.exit_context());
next.on_enter(&mut frame.enter_context(attributes, attack_script_assets)); if let SurfacePolicy::Airborne(lock_policy) = next.surface_policy() {
frame.surface.apply_airborne_policy(
lock_policy,
game_settings.fighter_common.leave_ground_ecb_frame_lock_duration,
);
}
next.on_enter(&mut frame.enter_context(attributes, attack_script_assets, game_settings));
*current = next; *current = next;
info!("{} -> {}", old_name, new_name); info!("{} -> {}", old_name, new_name);
} }
@@ -382,6 +431,7 @@ pub fn state_interrupt_system(
game_settings: Res<GameSettings>, game_settings: Res<GameSettings>,
baked_animations: Res<Assets<BakedFighterAnimations>>, baked_animations: Res<Assets<BakedFighterAnimations>>,
fighter_manifests: Res<Assets<FighterManifest>>, fighter_manifests: Res<Assets<FighterManifest>>,
stage_collision: Res<StageCollision>,
) { ) {
for fighter in &mut query { for fighter in &mut query {
let StatefulFighterQueryItem { let StatefulFighterQueryItem {
@@ -400,7 +450,9 @@ pub fn state_interrupt_system(
let new_state = if let Some(reaction) = pending_hit_reaction.take() { let new_state = if let Some(reaction) = pending_hit_reaction.take() {
hitstop.remaining_frames = *reaction.hitstop_frames; hitstop.remaining_frames = *reaction.hitstop_frames;
let shake_frames = reaction.hitstop_frames.calculate_shake_frames(&game_settings); let shake_frames = reaction
.hitstop_frames
.calculate_shake_frames(&game_settings);
hitstop_shake.role = FighterHitstopShakeRole::Receiver; hitstop_shake.role = FighterHitstopShakeRole::Receiver;
hitstop_shake.total_frames = shake_frames; hitstop_shake.total_frames = shake_frames;
hitstop_shake.remaining_frames = shake_frames; hitstop_shake.remaining_frames = shake_frames;
@@ -410,35 +462,25 @@ pub fn state_interrupt_system(
FighterHitstopShakeKind::Vertical FighterHitstopShakeKind::Vertical
}; };
let mut hitstop_kind = match &*state { let mut hitstop_kind = if frame.surface.is_grounded() {
FighterState::Wait(value) => { hitstun::HitstopStateKind::Grounded
hitstun::HitstopStateKind::Grounded(value.grounded_common.clone()) } else {
} hitstun::HitstopStateKind::Airborne
FighterState::Walk(value) => {
hitstun::HitstopStateKind::Grounded(value.grounded_common.clone())
}
FighterState::Dash(value) => {
hitstun::HitstopStateKind::Grounded(value.ground_common.clone())
}
FighterState::Run(value) => {
hitstun::HitstopStateKind::Grounded(value.grounded_common.clone())
}
FighterState::Turn(value) => {
hitstun::HitstopStateKind::Grounded(value.grounded_common.clone())
}
FighterState::GroundAttack(value) => {
hitstun::HitstopStateKind::Grounded(value.grounded_common.clone())
}
_ => hitstun::HitstopStateKind::Airborne,
}; };
if let hitstun::HitstopStateKind::Grounded(_) = hitstop_kind { if let hitstun::HitstopStateKind::Grounded = hitstop_kind {
let straight_up_angle = FGi32::lit("90.0"); let straight_up_angle = FGi32::lit("90.0");
if reaction.hitstop_frames >= HitStop::new(game_settings.fighter_common.tumble_bounce_hitstop_threshold) { if reaction.hitstop_frames
>= HitStop::new(game_settings.fighter_common.tumble_bounce_hitstop_threshold)
{
hitstop_kind = hitstun::HitstopStateKind::Airborne; hitstop_kind = hitstun::HitstopStateKind::Airborne;
// TODO: Use floor normal here // TODO: Use floor normal here
} else if reaction.launch_angle.abs_diff(straight_up_angle) < game_settings.fighter_common.attack_ground_to_airborne_transition_vertical_angle_threshold { } else if reaction.launch_angle.abs_diff(straight_up_angle)
hitstop_kind = hitstun::HitstopStateKind::Airborne; < game_settings
.fighter_common
.attack_ground_to_airborne_transition_vertical_angle_threshold
{
hitstop_kind = hitstun::HitstopStateKind::Airborne;
} else { } else {
// straight down is 270 // straight down is 270
let straight_down_angle = FGi32::lit("270.0"); let straight_down_angle = FGi32::lit("270.0");
@@ -463,6 +505,7 @@ pub fn state_interrupt_system(
animations, animations,
&baked_animations, &baked_animations,
&manifest.attributes, &manifest.attributes,
&stage_collision
)) ))
}; };
@@ -473,6 +516,7 @@ pub fn state_interrupt_system(
&mut frame, &mut frame,
&manifest.attributes, &manifest.attributes,
attack_script_assets, attack_script_assets,
&game_settings,
); );
}; };
} }
@@ -482,6 +526,7 @@ pub fn state_collision_interrupt_system(
mut query: Query<StatefulFighterQuery>, mut query: Query<StatefulFighterQuery>,
stage_collision: Res<StageCollision>, stage_collision: Res<StageCollision>,
fighter_manifests: Res<Assets<FighterManifest>>, fighter_manifests: Res<Assets<FighterManifest>>,
game_settings: Res<GameSettings>,
) { ) {
for fighter in &mut query { for fighter in &mut query {
let StatefulFighterQueryItem { let StatefulFighterQueryItem {
@@ -500,7 +545,7 @@ pub fn state_collision_interrupt_system(
.get(&fighter.manifest) .get(&fighter.manifest)
.expect("Fighter manifest should be valid"); .expect("Fighter manifest should be valid");
let new_state = let new_state =
state.check_collision_interrupt(&mut frame.collision_context(&stage_collision)); state.check_collision_interrupt(&mut frame.collision_context(&stage_collision, &game_settings));
if let Some(new_state) = new_state { if let Some(new_state) = new_state {
transition_state( transition_state(
&mut state, &mut state,
@@ -508,6 +553,7 @@ pub fn state_collision_interrupt_system(
&mut frame, &mut frame,
&manifest.attributes, &manifest.attributes,
&attack_script_assets, &attack_script_assets,
&game_settings,
); );
} }
} }
+61
View File
@@ -0,0 +1,61 @@
use super::{CollisionContext, EnterContext, FighterStateImpl, InterruptContext, UpdateContext};
use crate::fighter::animation::AnimKind;
use crate::fighter::state::air::AirborneStateCommon;
use crate::fighter::state::{ExitContext, FighterState, air, jump};
#[derive(Debug, Clone, Copy, Hash, Default)]
pub struct PlatformPassState {
airborne_state_common: AirborneStateCommon,
ignored_polygon: usize,
}
impl PlatformPassState {
pub fn new(airborne_state_common: AirborneStateCommon, ignored_polygon: usize) -> Self {
Self {
airborne_state_common,
ignored_polygon
}
}
}
impl FighterStateImpl for PlatformPassState {
const NAME: &'static str = "PlatformPass";
fn check_interrupt(&self, state_context: &mut InterruptContext) -> Option<FighterState> {
jump::check_input_double_jump(state_context)
}
fn on_enter(&mut self, state_context: &mut EnterContext) {
state_context.surface.ignore_polygon(self.ignored_polygon, state_context.game_settings.fighter_common.platform_pass_platform_ignore_duration_frames);
state_context.velocity.y = state_context.game_settings.fighter_common.platform_pass_initial_downwards_velocity;
state_context.play_animation(AnimKind::PlatformPass, false);
}
fn on_exit(&mut self, state_context: &mut ExitContext) {
state_context.surface.clear_polygon_ignore(self.ignored_polygon);
}
fn update(&mut self, state_context: &mut UpdateContext) {
air::update_standard_motion(state_context, &mut self.airborne_state_common);
}
fn check_collision_interrupt(
&mut self,
state_context: &mut CollisionContext,
) -> Option<FighterState> {
air::collision_interrupt(
state_context,
crate::fighter::state::land::LandingType::Normal,
)
}
fn is_visually_grounded<'a>(
&'a self,
) -> bool {
false
}
fn surface_policy(&self) -> super::SurfacePolicy {
super::SurfacePolicy::Airborne(crate::fighter::surface::EcbLockPolicy::StartOnDetach)
}
}
+7 -20
View File
@@ -6,19 +6,14 @@ use super::{
}; };
use crate::fighter::animation::AnimKind; use crate::fighter::animation::AnimKind;
use crate::fighter::state::FighterState; use crate::fighter::state::FighterState;
use crate::fighter::state::ground::GroundedStateCommon;
#[derive(Component, Debug, Clone, Hash)] #[derive(Component, Debug, Clone, Hash)]
pub struct RunState { pub struct RunState;
pub grounded_common: GroundedStateCommon,
}
impl FighterStateImpl for RunState { impl FighterStateImpl for RunState {
const NAME: &'static str = "Run"; const NAME: &'static str = "Run";
fn check_interrupt(&self, state_context: &mut InterruptContext) -> Option<FighterState> { fn check_interrupt(&self, state_context: &mut InterruptContext) -> Option<FighterState> {
if let Some(state) = if let Some(state) = ground::grounded_movement_common_interrupts(state_context) {
ground::grounded_movement_common_interrupts(state_context, &self.grounded_common)
{
return Some(state); return Some(state);
} }
@@ -28,8 +23,7 @@ impl FighterStateImpl for RunState {
{ {
None None
} else { } else {
walk::check_input(state_context, &self.grounded_common) walk::check_input(state_context).or_else(|| wait::check_input(state_context))
.or_else(|| wait::check_input(state_context, &self.grounded_common))
} }
} }
@@ -62,26 +56,19 @@ impl FighterStateImpl for RunState {
&mut self, &mut self,
state_context: &mut CollisionContext, state_context: &mut CollisionContext,
) -> Option<FighterState> { ) -> Option<FighterState> {
ground::collision_interrupt(state_context, &mut self.grounded_common, true) ground::collision_interrupt(state_context, true)
} }
fn is_visually_grounded<'a>( fn is_visually_grounded<'a>(&'a self) -> bool {
&'a self,
) -> bool {
true true
} }
} }
pub fn check_input( pub fn check_input(state_context: &InterruptContext) -> Option<FighterState> {
state_context: &InterruptContext,
ground_state_common: &GroundedStateCommon,
) -> Option<FighterState> {
let input_frame = state_context.input.get_last_frame(); let input_frame = state_context.input.get_last_frame();
if input_frame.movement.x.abs() >= state_context.game_settings.input_common.run_stick_threshold if input_frame.movement.x.abs() >= state_context.game_settings.input_common.run_stick_threshold
{ {
return Some(FighterState::Run(RunState { return Some(FighterState::Run(RunState));
grounded_common: ground_state_common.clone(),
}));
} }
None None
} }
+11 -20
View File
@@ -1,13 +1,11 @@
use super::{CollisionContext, EnterContext, FighterStateImpl, InterruptContext, UpdateContext}; use super::{CollisionContext, EnterContext, FighterStateImpl, InterruptContext, UpdateContext};
use crate::fighter::animation::AnimKind; use crate::fighter::animation::AnimKind;
use crate::fighter::state::ground::{self, GroundedStateCommon}; use crate::fighter::state::ground;
use crate::fighter::state::{FighterState, dash, jump, wait, walk}; use crate::fighter::state::{FighterState, dash, jump, wait, walk};
use crate::input::FighterCommands; use crate::input::FighterCommands;
#[derive(Debug, Clone, Hash)] #[derive(Debug, Clone, Hash)]
pub struct TurnState { pub struct TurnState;
pub grounded_common: GroundedStateCommon,
}
impl FighterStateImpl for TurnState { impl FighterStateImpl for TurnState {
const NAME: &'static str = "Turn"; const NAME: &'static str = "Turn";
@@ -19,19 +17,19 @@ impl FighterStateImpl for TurnState {
.input_common .input_common
.turn_into_dashback_window as u32 .turn_into_dashback_window as u32
{ {
if let Some(state) = dash::check_input(state_context, &self.grounded_common) { if let Some(state) = dash::check_input(state_context) {
return Some(state); return Some(state);
} }
} }
if let Some(state) = jump::check_input(state_context, &self.grounded_common) { if let Some(state) = jump::check_input(state_context) {
*state_context.facing_direction = state_context.facing_direction.reverse(); *state_context.facing_direction = state_context.facing_direction.reverse();
Some(state) Some(state)
} else if state_context.is_current_animation_finished() { } else if state_context.is_current_animation_finished() {
if let Some(state) = dash::check_input(state_context, &self.grounded_common) { if let Some(state) = dash::check_input(state_context) {
Some(state) Some(state)
} else if let Some(state) = walk::check_input(state_context, &self.grounded_common) { } else if let Some(state) = walk::check_input(state_context) {
Some(state) Some(state)
} else if let Some(state) = wait::check_input(state_context, &self.grounded_common) { } else if let Some(state) = wait::check_input(state_context) {
Some(state) Some(state)
} else { } else {
None None
@@ -54,20 +52,15 @@ impl FighterStateImpl for TurnState {
&mut self, &mut self,
state_context: &mut CollisionContext, state_context: &mut CollisionContext,
) -> Option<FighterState> { ) -> Option<FighterState> {
ground::collision_interrupt(state_context, &mut self.grounded_common, false) ground::collision_interrupt(state_context, false)
} }
fn is_visually_grounded<'a>( fn is_visually_grounded<'a>(&'a self) -> bool {
&'a self,
) -> bool {
true true
} }
} }
pub fn check_input( pub fn check_input(state_context: &InterruptContext) -> Option<FighterState> {
state_context: &InterruptContext,
grounded_common: &GroundedStateCommon,
) -> Option<FighterState> {
let input_frame = state_context.input.get_last_frame(); let input_frame = state_context.input.get_last_frame();
let has_smash_input = state_context let has_smash_input = state_context
@@ -81,9 +74,7 @@ pub fn check_input(
&& input_frame.movement.x.signum() != state_context.facing_direction.to_sign() && input_frame.movement.x.signum() != state_context.facing_direction.to_sign()
&& !has_smash_input && !has_smash_input
{ {
return Some(FighterState::Turn(TurnState { return Some(FighterState::Turn(TurnState));
grounded_common: grounded_common.clone(),
}));
} }
None None
} }
+9 -22
View File
@@ -3,24 +3,18 @@ use super::{
}; };
use crate::fighter::animation::AnimKind; use crate::fighter::animation::AnimKind;
use crate::fighter::state::FighterState; use crate::fighter::state::FighterState;
use crate::fighter::state::ground::GroundedStateCommon;
#[derive(Debug, Clone, Hash)] #[derive(Debug, Clone, Hash)]
pub struct WaitState { pub struct WaitState;
pub grounded_common: GroundedStateCommon,
}
impl FighterStateImpl for WaitState { impl FighterStateImpl for WaitState {
const NAME: &'static str = "Wait"; const NAME: &'static str = "Wait";
fn check_interrupt(&self, state_context: &mut InterruptContext) -> Option<FighterState> { fn check_interrupt(&self, state_context: &mut InterruptContext) -> Option<FighterState> {
if let Some(state) = if let Some(state) = ground::grounded_movement_common_interrupts(state_context) {
ground::grounded_movement_common_interrupts(state_context, &self.grounded_common)
{
Some(state) Some(state)
} else if let Some(state) = ground::grounded_movement_standstill_common_interrupts( } else if let Some(state) =
state_context, ground::grounded_movement_standstill_common_interrupts(state_context)
&self.grounded_common, {
) {
// Don't transition into yourself // Don't transition into yourself
if let FighterState::Wait(_) = state { if let FighterState::Wait(_) = state {
None None
@@ -44,26 +38,19 @@ impl FighterStateImpl for WaitState {
&mut self, &mut self,
state_context: &mut CollisionContext, state_context: &mut CollisionContext,
) -> Option<FighterState> { ) -> Option<FighterState> {
ground::collision_interrupt(state_context, &mut self.grounded_common, false) ground::collision_interrupt(state_context, false)
} }
fn is_visually_grounded<'a>( fn is_visually_grounded<'a>(&'a self) -> bool {
&'a self,
) -> bool {
true true
} }
} }
pub fn check_input( pub fn check_input(state_context: &InterruptContext) -> Option<FighterState> {
state_context: &InterruptContext,
ground_state_common: &GroundedStateCommon,
) -> Option<FighterState> {
let input_frame = state_context.input.get_last_frame(); let input_frame = state_context.input.get_last_frame();
if input_frame.movement.x.abs() < state_context.game_settings.input_common.stick_deadzone { if input_frame.movement.x.abs() < state_context.game_settings.input_common.stick_deadzone {
return Some(FighterState::Wait(WaitState { return Some(FighterState::Wait(WaitState));
grounded_common: ground_state_common.clone(),
}));
} }
None None
} }
+7 -20
View File
@@ -4,23 +4,17 @@ use super::{
}; };
use crate::fighter::animation::AnimKind; use crate::fighter::animation::AnimKind;
use crate::fighter::state::FighterState; use crate::fighter::state::FighterState;
use crate::fighter::state::ground::GroundedStateCommon;
#[derive(Debug, Clone, Hash)] #[derive(Debug, Clone, Hash)]
pub struct WalkState { pub struct WalkState;
pub grounded_common: GroundedStateCommon,
}
impl FighterStateImpl for WalkState { impl FighterStateImpl for WalkState {
const NAME: &'static str = "Walk"; const NAME: &'static str = "Walk";
fn check_interrupt(&self, state_context: &mut InterruptContext) -> Option<FighterState> { fn check_interrupt(&self, state_context: &mut InterruptContext) -> Option<FighterState> {
if let Some(state) = if let Some(state) = ground::grounded_movement_common_interrupts(state_context) {
ground::grounded_movement_common_interrupts(state_context, &self.grounded_common)
{
return Some(state); return Some(state);
} }
wait::check_input(state_context, &self.grounded_common) wait::check_input(state_context).or_else(|| dash::check_input(state_context))
.or_else(|| dash::check_input(state_context, &self.grounded_common))
} }
fn on_enter(&mut self, state_context: &mut EnterContext) { fn on_enter(&mut self, state_context: &mut EnterContext) {
@@ -54,26 +48,19 @@ impl FighterStateImpl for WalkState {
&mut self, &mut self,
state_context: &mut CollisionContext, state_context: &mut CollisionContext,
) -> Option<FighterState> { ) -> Option<FighterState> {
ground::collision_interrupt(state_context, &mut self.grounded_common, false) ground::collision_interrupt(state_context, false)
} }
fn is_visually_grounded<'a>( fn is_visually_grounded<'a>(&'a self) -> bool {
&'a self,
) -> bool {
true true
} }
} }
pub fn check_input( pub fn check_input(state_context: &InterruptContext) -> Option<FighterState> {
state_context: &InterruptContext,
ground_state_common: &GroundedStateCommon,
) -> Option<FighterState> {
let input_frame = state_context.input.get_last_frame(); let input_frame = state_context.input.get_last_frame();
if !input_frame.movement.x.is_zero() { if !input_frame.movement.x.is_zero() {
return Some(FighterState::Walk(WalkState { return Some(FighterState::Walk(WalkState));
grounded_common: ground_state_common.clone(),
}));
} }
None None
+227
View File
@@ -0,0 +1,227 @@
use bevy::prelude::*;
use crate::stage::line::StageLineID;
#[derive(Clone, Copy, Debug, Hash, PartialEq, Eq)]
pub enum EcbLockPolicy {
StartOnDetach,
Restart,
Preserve,
Clear,
}
/// The stage surface currently supporting a fighter.
///
/// This is physics state rather than fighter-state-machine state. Keeping it
/// separate means grounded, landing, and hitstun states all share one source
/// of truth for stage contact.
#[derive(Clone, Debug, Hash, PartialEq, Eq)]
pub struct IgnoredPolygon {
pub polygon: usize,
pub frames_remaining: u32,
}
#[derive(Component, Clone, Debug, Hash, PartialEq, Eq)]
pub enum FighterSurfaceState {
Airborne {
ecb_lock_frames_remaining: u32,
ignored_polys: Vec<IgnoredPolygon>,
},
Grounded {
line_id: StageLineID,
},
}
impl Default for FighterSurfaceState {
fn default() -> Self {
Self::Airborne {
ecb_lock_frames_remaining: 0,
ignored_polys: vec![],
}
}
}
impl FighterSurfaceState {
pub fn is_grounded(&self) -> bool {
matches!(self, Self::Grounded { .. })
}
pub fn line_id(&self) -> Option<StageLineID> {
match self {
Self::Airborne { .. } => None,
Self::Grounded { line_id } => Some(*line_id),
}
}
pub(crate) fn land(&mut self, line_id: StageLineID) {
*self = Self::Grounded { line_id };
}
pub fn clear_polygon_ignore(&mut self, polygon: usize) {
let Self::Airborne { ignored_polys, .. } = self else {
return;
};
ignored_polys.retain(|element| element.polygon != polygon);
}
pub fn ignore_polygon(&mut self, polygon: usize, duration_frames: u32) {
let Self::Airborne { ignored_polys, .. } = self else {
return;
};
if duration_frames == 0 {
return;
}
if let Some(ignored) = ignored_polys.iter_mut().find(|ignored| ignored.polygon == polygon) {
ignored.frames_remaining = duration_frames;
} else {
ignored_polys.push(IgnoredPolygon {
polygon,
frames_remaining: duration_frames,
});
}
}
pub fn is_polygon_ignored(&self, polygon: usize) -> bool {
matches!(self, Self::Airborne { ignored_polys, .. }
if ignored_polys.iter().any(|ignored| ignored.polygon == polygon))
}
pub(crate) fn ignored_polygon_ids(&self) -> Vec<usize> {
match self {
Self::Airborne { ignored_polys, .. } => {
ignored_polys.iter().map(|ignored| ignored.polygon).collect()
}
Self::Grounded { .. } => vec![],
}
}
pub(crate) fn apply_airborne_policy(
&mut self,
policy: EcbLockPolicy,
ecb_lock_duration: u32,
) {
let current_lock = match self {
Self::Airborne { ecb_lock_frames_remaining, .. } => *ecb_lock_frames_remaining,
Self::Grounded { .. } => 0,
};
let ecb_lock_frames_remaining = match policy {
EcbLockPolicy::StartOnDetach if self.is_grounded() => ecb_lock_duration,
EcbLockPolicy::StartOnDetach => current_lock,
EcbLockPolicy::Restart => ecb_lock_duration,
EcbLockPolicy::Preserve => current_lock,
EcbLockPolicy::Clear => 0,
};
let ignored_polys = match self {
Self::Airborne { ignored_polys, .. } => ignored_polys.clone(),
Self::Grounded { .. } => vec![],
};
*self = Self::Airborne { ecb_lock_frames_remaining, ignored_polys };
}
pub(crate) fn tick_ecb_lock(&mut self) {
if let Self::Airborne { ecb_lock_frames_remaining, .. } = self {
*ecb_lock_frames_remaining = ecb_lock_frames_remaining.saturating_sub(1);
}
}
pub(crate) fn tick_ignored_polygons(&mut self) {
if let Self::Airborne { ignored_polys, .. } = self {
for ignored in ignored_polys.iter_mut() {
ignored.frames_remaining = ignored.frames_remaining.saturating_sub(1);
}
ignored_polys.retain(|ignored| ignored.frames_remaining > 0);
}
}
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn contact_lifecycle_has_one_source_of_truth() {
let mut surface = FighterSurfaceState::default();
assert!(!surface.is_grounded());
assert_eq!(surface.line_id(), None);
let line_id = StageLineID {
polygon: 2,
segment: 3,
};
surface.land(line_id);
assert!(surface.is_grounded());
assert_eq!(surface.line_id(), Some(line_id));
surface.apply_airborne_policy(EcbLockPolicy::Clear, 0);
assert!(!surface.is_grounded());
assert_eq!(surface.line_id(), None);
}
#[test]
fn start_on_detach_does_not_reset_an_existing_lock() {
let mut surface = FighterSurfaceState::default();
surface.apply_airborne_policy(EcbLockPolicy::Restart, 5);
surface.tick_ecb_lock();
surface.apply_airborne_policy(EcbLockPolicy::StartOnDetach, 5);
assert_eq!(
surface,
FighterSurfaceState::Airborne {
ecb_lock_frames_remaining: 4,
ignored_polys: vec![],
}
);
}
#[test]
fn restart_retriggers_an_existing_lock() {
let mut surface = FighterSurfaceState::default();
surface.apply_airborne_policy(EcbLockPolicy::Restart, 5);
surface.tick_ecb_lock();
surface.apply_airborne_policy(EcbLockPolicy::Restart, 5);
assert_eq!(
surface,
FighterSurfaceState::Airborne {
ecb_lock_frames_remaining: 5,
ignored_polys: vec![],
}
);
}
#[test]
fn ignored_polygon_expires_after_requested_frames() {
let mut surface = FighterSurfaceState::default();
surface.ignore_polygon(3, 2);
assert!(surface.is_polygon_ignored(3));
surface.tick_ignored_polygons();
assert!(surface.is_polygon_ignored(3));
surface.tick_ignored_polygons();
assert!(!surface.is_polygon_ignored(3));
}
#[test]
fn ignoring_polygon_refreshes_existing_entry() {
let mut surface = FighterSurfaceState::default();
surface.ignore_polygon(3, 2);
surface.ignore_polygon(3, 5);
surface.tick_ignored_polygons();
surface.tick_ignored_polygons();
assert!(surface.is_polygon_ignored(3));
}
#[test]
fn airborne_policy_preserves_ignored_polygons_and_landing_clears_them() {
let mut surface = FighterSurfaceState::default();
surface.ignore_polygon(3, 5);
surface.apply_airborne_policy(EcbLockPolicy::Restart, 2);
assert!(surface.is_polygon_ignored(3));
surface.land(StageLineID { polygon: 0, segment: 0 });
assert!(!surface.is_polygon_ignored(3));
}
}
+3
View File
@@ -39,6 +39,9 @@ pub struct FighterSettingsCommon {
/// Maximum angle changed caused by directional influence /// Maximum angle changed caused by directional influence
pub di_max_angle: FGi32, pub di_max_angle: FGi32,
pub leave_ground_ecb_frame_lock_duration: u32,
pub platform_pass_platform_ignore_duration_frames: u32,
pub platform_pass_initial_downwards_velocity: FGi32,
} }
#[derive(Reflect, Serialize, Deserialize, Clone)] #[derive(Reflect, Serialize, Deserialize, Clone)]
#[reflect(opaque)] #[reflect(opaque)]
+2
View File
@@ -233,6 +233,8 @@ pub fn postprocess_input(
input.clear_command(FighterCommands::SmashMoveUp); input.clear_command(FighterCommands::SmashMoveUp);
input.clear_command(FighterCommands::SmashMoveDown); input.clear_command(FighterCommands::SmashMoveDown);
input.frames_in_y_flick_deadzone = 0xFF;
let command_to_set = if input.current_frame.movement.y > 0.0 { let command_to_set = if input.current_frame.movement.y > 0.0 {
FighterCommands::SmashMoveUp FighterCommands::SmashMoveUp
} else { } else {
+74 -10
View File
@@ -1,6 +1,8 @@
use std::panic::{self, AssertUnwindSafe}; use std::panic::{self, AssertUnwindSafe};
use std::sync::atomic::{AtomicBool, Ordering}; use std::sync::atomic::{AtomicBool, Ordering};
use std::sync::{Arc, Mutex}; use std::sync::{Arc, Mutex};
use std::thread::JoinHandle;
use std::time::{Duration, Instant};
use bevy::prelude::*; use bevy::prelude::*;
use gc_adapter_neo::{Controller, GcAdapter}; use gc_adapter_neo::{Controller, GcAdapter};
@@ -55,10 +57,11 @@ impl GcPortState {
/// Shared, `Send + Sync` handle to the latest snapshot from the poll /// Shared, `Send + Sync` handle to the latest snapshot from the poll
/// thread. Safe to store as an ordinary [`Resource`] (no `NonSend` needed) /// thread. Safe to store as an ordinary [`Resource`] (no `NonSend` needed)
/// because the `GcAdapter` itself never leaves its thread. /// because the `GcAdapter` itself never leaves its thread.
#[derive(Resource, Clone)] #[derive(Resource)]
pub struct GcAdapterSnapshot { pub struct GcAdapterSnapshot {
ports: Arc<Mutex<[GcPortState; 4]>>, ports: Arc<Mutex<[GcPortState; 4]>>,
shutdown: Arc<AtomicBool>, shutdown: Arc<AtomicBool>,
poll_thread: Option<JoinHandle<()>>,
} }
impl GcAdapterSnapshot { impl GcAdapterSnapshot {
@@ -69,14 +72,38 @@ impl GcAdapterSnapshot {
impl Drop for GcAdapterSnapshot { impl Drop for GcAdapterSnapshot {
fn drop(&mut self) { fn drop(&mut self) {
// Only actually signals shutdown once the last clone (this resource self.shutdown.store(true, Ordering::Release);
// is never cloned in practice, but be defensive) is dropped.
if Arc::strong_count(&self.shutdown) <= 1 { if let Some(poll_thread) = self.poll_thread.take() {
self.shutdown.store(true, Ordering::Relaxed); if let Err(payload) = poll_thread.join() {
error!(
"GameCube Controller Adapter poll thread panicked during shutdown: {payload:?}"
);
}
} }
} }
} }
const INITIAL_ERROR_BACKOFF: Duration = Duration::from_millis(1);
const MAX_ERROR_BACKOFF: Duration = Duration::from_millis(100);
fn next_error_backoff(backoff: Duration) -> Duration {
backoff.saturating_mul(2).min(MAX_ERROR_BACKOFF)
}
/// Wait for a retry while still allowing the owner to shut the poll thread down promptly.
fn wait_for_retry(shutdown: &AtomicBool, delay: Duration) -> bool {
let deadline = Instant::now() + delay;
while !shutdown.load(Ordering::Acquire) {
let remaining = deadline.saturating_duration_since(Instant::now());
if remaining.is_zero() {
return true;
}
std::thread::sleep(remaining.min(Duration::from_millis(10)));
}
false
}
/// Connects to the first GameCube adapter found on the USB bus and starts /// Connects to the first GameCube adapter found on the USB bus and starts
/// polling it on a dedicated thread. Returns `None` (after logging a /// polling it on a dedicated thread. Returns `None` (after logging a
/// warning) if no adapter is plugged in /// warning) if no adapter is plugged in
@@ -94,7 +121,7 @@ pub fn spawn_poll_thread() -> Result<GcAdapterSnapshot, gc_adapter_neo::UsbError
let thread_ports = ports.clone(); let thread_ports = ports.clone();
let thread_shutdown = shutdown.clone(); let thread_shutdown = shutdown.clone();
std::thread::Builder::new() let poll_thread = std::thread::Builder::new()
.name("gc-adapter-poll".into()) .name("gc-adapter-poll".into())
.spawn(move || { .spawn(move || {
// Flush whatever the adapter had buffered before we started // Flush whatever the adapter had buffered before we started
@@ -107,17 +134,27 @@ pub fn spawn_poll_thread() -> Result<GcAdapterSnapshot, gc_adapter_neo::UsbError
let mut rate_window_start = std::time::Instant::now(); let mut rate_window_start = std::time::Instant::now();
#[cfg(debug_assertions)] #[cfg(debug_assertions)]
let mut rate_window_count: u32 = 0; let mut rate_window_count: u32 = 0;
let mut error_backoff = INITIAL_ERROR_BACKOFF;
while !thread_shutdown.load(Ordering::Relaxed) { while !thread_shutdown.load(Ordering::Acquire) {
let result = panic::catch_unwind(AssertUnwindSafe(|| adapter.read_controllers())); let result = panic::catch_unwind(AssertUnwindSafe(|| adapter.read_controllers()));
let controllers = match result { let controllers = match result {
Ok(Ok(controllers)) => controllers, Ok(Ok(controllers)) => {
error_backoff = INITIAL_ERROR_BACKOFF;
controllers
}
// Ignore this, for some reason we get a bunch of these when we start reading // Ignore this, for some reason we get a bunch of these when we start reading
Ok(Err( Ok(Err(
gc_adapter_neo::AdapterError::Parse(_) gc_adapter_neo::AdapterError::Parse(_)
| gc_adapter_neo::AdapterError::ShortRead(_), | gc_adapter_neo::AdapterError::ShortRead(_),
)) => continue, )) => {
if !wait_for_retry(&thread_shutdown, error_backoff) {
break;
}
error_backoff = next_error_backoff(error_backoff);
continue;
}
Ok(Err(gc_adapter_neo::AdapterError::Usb(err))) => { Ok(Err(gc_adapter_neo::AdapterError::Usb(err))) => {
error!( error!(
"GameCube Controller Adapter USB read failed ({err:?}); stopping \ "GameCube Controller Adapter USB read failed ({err:?}); stopping \
@@ -160,5 +197,32 @@ pub fn spawn_poll_thread() -> Result<GcAdapterSnapshot, gc_adapter_neo::UsbError
}) })
.expect("failed to spawn gc-adapter poll thread"); .expect("failed to spawn gc-adapter poll thread");
Ok(GcAdapterSnapshot { ports, shutdown }) Ok(GcAdapterSnapshot {
ports,
shutdown,
poll_thread: Some(poll_thread),
})
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn error_backoff_is_capped() {
let mut backoff = INITIAL_ERROR_BACKOFF;
for _ in 0..16 {
backoff = next_error_backoff(backoff);
}
assert_eq!(backoff, MAX_ERROR_BACKOFF);
assert_eq!(next_error_backoff(MAX_ERROR_BACKOFF), MAX_ERROR_BACKOFF);
}
#[test]
fn retry_wait_stops_when_shutdown_is_requested() {
let shutdown = AtomicBool::new(true);
assert!(!wait_for_retry(&shutdown, Duration::from_secs(1)));
}
} }
+7 -7
View File
@@ -32,22 +32,20 @@ use clap::Parser;
use ron_asset_manager::RonAssetPlugin; use ron_asset_manager::RonAssetPlugin;
use crate::{ use crate::{
camera::MatchCameraPlugin, camera::MatchCameraPlugin, fighter::manifest::FighterManifest, game_settings::GameSettings,
fighter::manifest::FighterManifest, match_runtime::MatchRuntimePlugin, menus::style::FGUiStyle, schedule::GameplaySchedulePlugin,
game_settings::GameSettings, stage::manifest::StageManifest, ui::InGameUIPlugin,
menus::style::FGUiStyle,
schedule::GameplaySchedulePlugin,
stage::manifest::StageManifest,
ui::InGameUIPlugin,
}; };
mod args; mod args;
pub mod blend_asset;
pub mod camera; pub mod camera;
pub mod debug_tools; pub mod debug_tools;
pub mod fighter; pub mod fighter;
pub mod game_settings; pub mod game_settings;
pub mod input; pub mod input;
pub mod match_loading; pub mod match_loading;
pub mod match_runtime;
mod math; mod math;
pub mod menus; pub mod menus;
pub mod netcode; pub mod netcode;
@@ -92,6 +90,7 @@ pub struct GameAssetPlugin;
impl Plugin for GameAssetPlugin { impl Plugin for GameAssetPlugin {
fn build(&self, app: &mut App) { fn build(&self, app: &mut App) {
app.add_plugins(( app.add_plugins((
blend_asset::BlendAssetProcessingPlugin,
RonAssetPlugin::<FighterManifest>::create("fighter.ron"), RonAssetPlugin::<FighterManifest>::create("fighter.ron"),
RonAssetPlugin::<StageManifest>::create("stage.ron"), RonAssetPlugin::<StageManifest>::create("stage.ron"),
RonAssetPlugin::<GameSettings>::create("ron"), RonAssetPlugin::<GameSettings>::create("ron"),
@@ -111,6 +110,7 @@ impl Plugin for GamePlugin {
// Brings up GGRS (and with it `GgrsSchedule`), so it goes first. // Brings up GGRS (and with it `GgrsSchedule`), so it goes first.
netcode::FighterNetcodePlugin::default(), netcode::FighterNetcodePlugin::default(),
GameplaySchedulePlugin, GameplaySchedulePlugin,
MatchRuntimePlugin,
input::FighterInputPlugin, input::FighterInputPlugin,
replay::ReplayPlugin, replay::ReplayPlugin,
debug_tools::DebugToolsPlugin, debug_tools::DebugToolsPlugin,
+11 -6
View File
@@ -1,6 +1,7 @@
use bevy::asset::AssetMode::Processed; use bevy::asset::AssetMode::Processed;
#[cfg(feature = "debug_features")] #[cfg(feature = "debug_features")]
use bevy::camera_controller::free_camera::FreeCameraPlugin; use bevy::camera_controller::free_camera::FreeCameraPlugin;
use bevy::gltf::GltfPlugin;
use bevy::image::{ImageAddressMode, ImagePlugin, ImageSamplerDescriptor}; use bevy::image::{ImageAddressMode, ImagePlugin, ImageSamplerDescriptor};
use bevy::prelude::*; use bevy::prelude::*;
#[cfg(feature = "debug_features")] #[cfg(feature = "debug_features")]
@@ -12,14 +13,18 @@ fn main() -> AppExit {
// A `Repeat` sampler so the tileable materials authored in the // A `Repeat` sampler so the tileable materials authored in the
// editor render the same way at runtime; Bevy's default // editor render the same way at runtime; Bevy's default
// `ClampToEdge` smears texture edges on brush geometry. // `ClampToEdge` smears texture edges on brush geometry.
let default_sampler = ImageSamplerDescriptor::linear()
.set_address_mode(ImageAddressMode::Repeat)
.set_anisotropic_filter(16)
.clone();
let default_plugins = DefaultPlugins let default_plugins = DefaultPlugins
.set(ImagePlugin { .set(ImagePlugin {
default_sampler: ImageSamplerDescriptor { default_sampler: default_sampler.clone(),
address_mode_u: ImageAddressMode::Repeat, })
address_mode_v: ImageAddressMode::Repeat, .set(GltfPlugin {
address_mode_w: ImageAddressMode::Repeat, default_sampler,
..ImageSamplerDescriptor::linear() ..default()
},
}) })
.set(AssetPlugin { .set(AssetPlugin {
mode: Processed, mode: Processed,
+138 -34
View File
@@ -8,28 +8,29 @@ use bevy_ggrs::prelude::Session;
use serde::{Deserialize, Serialize}; use serde::{Deserialize, Serialize};
use crate::{ use crate::{
AppState,
args::Args, args::Args,
fighter::{ fighter::{
FighterId, FighterRoster,
animation::AnimKind, animation::AnimKind,
attack::{AttackKind, FighterAttackScriptAssets}, attack::{AttackKind, FighterAttackScriptAssets},
baked_animation::{BakedFighterAnimations, BAKED_ANIMATION_FPS}, baked_animation::{BAKED_ANIMATION_FPS, BakedFighterAnimations},
manifest::{FighterManifest, FighterManifestRegistry}, manifest::{FighterManifest, FighterManifestRegistry},
spawn_fighter, spawn_fighter,
visual::FighterAnimations, visual::FighterAnimations,
FighterId, FighterRoster,
}, },
input::{LocalInputAssignments, LocalInputSource}, input::{LocalInputAssignments, LocalInputSource},
match_runtime::MatchState,
math::{int::FGi32, vec::FGVec2}, math::{int::FGi32, vec::FGVec2},
netcode::{ netcode::{
session::{create_session, ConnectionStatus, SessionConfig},
GGRSCfg, GGRSCfg,
session::{ConnectionStatus, SessionConfig, create_session},
}, },
scripting::FighterAttackScript, scripting::FighterAttackScript,
stage::{ stage::{
self, self,
manifest::{StageId, StageManifest, StageManifestRegistry}, manifest::{StageId, StageManifest, StageManifestRegistry},
}, },
AppState,
}; };
#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)] #[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
@@ -38,10 +39,49 @@ pub struct MatchPlayer {
pub fighter: FighterId, pub fighter: FighterId,
} }
#[derive(Resource, Debug, Clone, PartialEq, Eq)] #[derive(Resource, Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
pub struct PendingMatch { pub struct MatchConfig {
pub stage: StageId, pub stage: StageId,
pub players: Vec<MatchPlayer>, pub players: Vec<MatchPlayer>,
pub rules: MatchRules,
}
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
pub enum MatchRules {
Stock {
starting_stocks: u8,
time_limit_frames: Option<u32>,
},
Timed {
time_limit_frames: u32,
},
}
impl Default for MatchRules {
fn default() -> Self {
Self::Stock {
starting_stocks: 3,
time_limit_frames: None,
}
}
}
impl MatchRules {
fn validate(&self) -> Result<(), &'static str> {
match self {
Self::Stock {
starting_stocks: 0, ..
} => Err("stock matches must start with at least one stock"),
Self::Stock {
time_limit_frames: Some(0),
..
} => Err("stock match time limits must be greater than zero frames"),
Self::Timed {
time_limit_frames: 0,
} => Err("timed match limits must be greater than zero frames"),
_ => Ok(()),
}
}
} }
pub struct SelectedFighterAssets { pub struct SelectedFighterAssets {
@@ -59,7 +99,7 @@ pub struct MatchAssets {
impl MatchAssets { impl MatchAssets {
fn requested(world: &World) -> Self { fn requested(world: &World) -> Self {
let request = world.resource::<PendingMatch>(); let config = world.resource::<MatchConfig>();
let asset_server = world.resource::<AssetServer>(); let asset_server = world.resource::<AssetServer>();
let registry = world.resource::<FighterManifestRegistry>(); let registry = world.resource::<FighterManifestRegistry>();
let stage_registry = world.resource::<StageManifestRegistry>(); let stage_registry = world.resource::<StageManifestRegistry>();
@@ -67,7 +107,7 @@ impl MatchAssets {
let stage_manifests = world.resource::<Assets<StageManifest>>(); let stage_manifests = world.resource::<Assets<StageManifest>>();
let stage_handle = stage_registry let stage_handle = stage_registry
.get(request.stage) .get(config.stage)
.expect("Startup validation guarantees every stage has a manifest"); .expect("Startup validation guarantees every stage has a manifest");
let stage_manifest = stage_manifests let stage_manifest = stage_manifests
.get(&stage_handle) .get(&stage_handle)
@@ -75,7 +115,7 @@ impl MatchAssets {
Self { Self {
stage: asset_server.load(stage_manifest.model_path.clone()), stage: asset_server.load(stage_manifest.model_path.clone()),
fighters: request fighters: config
.players .players
.iter() .iter()
.map(|player| { .map(|player| {
@@ -141,10 +181,10 @@ pub struct MatchRoot;
pub fn initiate_match( pub fn initiate_match(
commands: &mut Commands, commands: &mut Commands,
next_state: &mut NextState<AppState>, next_state: &mut NextState<AppState>,
request: PendingMatch, config: MatchConfig,
) { ) {
commands.remove_resource::<crate::netcode::session::MatchDisconnected>(); commands.remove_resource::<crate::netcode::session::MatchDisconnected>();
commands.insert_resource(request); commands.insert_resource(config);
next_state.set(AppState::LoadingMatch); next_state.set(AppState::LoadingMatch);
} }
@@ -166,12 +206,9 @@ pub fn initiate_default_match(
if let Some(path) = &args.play_replay { if let Some(path) = &args.play_replay {
match crate::replay::load(path) { match crate::replay::load(path) {
Ok(replay) => { Ok(replay) => {
let request = PendingMatch { let config = replay.match_config.clone();
stage: replay.match_config.stage,
players: replay.match_config.players.clone(),
};
commands.insert_resource(crate::replay::LoadedReplay(replay)); commands.insert_resource(crate::replay::LoadedReplay(replay));
initiate_match(&mut commands, &mut next_state, request); initiate_match(&mut commands, &mut next_state, config);
} }
Err(error) => { Err(error) => {
error!("Replay load failed: {error}"); error!("Replay load failed: {error}");
@@ -215,16 +252,17 @@ pub fn initiate_default_match(
initiate_match( initiate_match(
&mut commands, &mut commands,
&mut next_state, &mut next_state,
PendingMatch { MatchConfig {
stage: StageId::TestStage, stage: StageId::TestStage,
players, players,
rules: MatchRules::default(),
}, },
); );
} }
pub fn prepare_match( pub fn prepare_match(
mut commands: Commands, mut commands: Commands,
request: Res<PendingMatch>, config: Res<MatchConfig>,
assets: Res<MatchAssets>, assets: Res<MatchAssets>,
gltfs: Res<Assets<Gltf>>, gltfs: Res<Assets<Gltf>>,
baked_animations: Res<Assets<BakedFighterAnimations>>, baked_animations: Res<Assets<BakedFighterAnimations>>,
@@ -236,7 +274,7 @@ pub fn prepare_match(
args: Res<Args>, args: Res<Args>,
mut next_state: ResMut<NextState<AppState>>, mut next_state: ResMut<NextState<AppState>>,
) { ) {
if !valid_player_handles(&request.players) { if !valid_player_handles(&config.players) {
fail_match( fail_match(
&mut next_state, &mut next_state,
"player handles must be unique and cover 0..player_count", "player handles must be unique and cover 0..player_count",
@@ -244,7 +282,12 @@ pub fn prepare_match(
return; return;
} }
if assets.fighters.len() != request.players.len() { if let Err(error) = config.rules.validate() {
fail_match(&mut next_state, error);
return;
}
if assets.fighters.len() != config.players.len() {
fail_match( fail_match(
&mut next_state, &mut next_state,
"loaded character assets do not match the requested player slots", "loaded character assets do not match the requested player slots",
@@ -293,6 +336,15 @@ pub fn prepare_match(
); );
return; return;
} }
let ecb_bone_indices = baked.bone_names.iter().enumerate().filter_map(|(idx, name)| {
if manifest.ecb_bones.contains(name) {
Some(idx)
} else {
None
}
}).collect::<Vec<_>>();
if let Err(error) = manifest.attributes.validate() { if let Err(error) = manifest.attributes.validate() {
fail_match( fail_match(
&mut next_state, &mut next_state,
@@ -393,10 +445,11 @@ pub fn prepare_match(
attack_scripts, attack_scripts,
manifest_handle, manifest_handle,
manifest.model_scale, manifest.model_scale,
ecb_bone_indices,
)); ));
} }
let session_config = match SessionConfig::from_args(&args, request.players.len()) { let session_config = match SessionConfig::from_args(&args, config.players.len()) {
Ok(config) => config, Ok(config) => config,
Err(error) => { Err(error) => {
fail_match( fail_match(
@@ -406,7 +459,7 @@ pub fn prepare_match(
return; return;
} }
}; };
let session = match create_session(&args, request.players.len()) { let session = match create_session(&args, config.players.len()) {
Ok(session) => session, Ok(session) => session,
Err(error) => { Err(error) => {
fail_match( fail_match(
@@ -420,7 +473,7 @@ pub fn prepare_match(
let root = commands.spawn((Name::new("Match"), MatchRoot)).id(); let root = commands.spawn((Name::new("Match"), MatchRoot)).id();
let stage_handle = stage_registry let stage_handle = stage_registry
.get(request.stage) .get(config.stage)
.expect("Initialization check should ensure all stages exist"); .expect("Initialization check should ensure all stages exist");
let stage_manifest = stage_manifests let stage_manifest = stage_manifests
.get(&stage_handle) .get(&stage_handle)
@@ -433,11 +486,11 @@ pub fn prepare_match(
stage_manifest.camera.clone(), stage_manifest.camera.clone(),
); );
let mut fighter_roster = Vec::with_capacity(request.players.len()); let mut fighter_roster = Vec::with_capacity(config.players.len());
for (index, (player, (scene, animations, attack_scripts, manifest_handle, model_scale))) in for (index, (player, (scene, animations, attack_scripts, manifest_handle, model_scale, ecb_bone_indices))) in
request.players.iter().zip(prepared).enumerate() config.players.iter().zip(prepared).enumerate()
{ {
let spawn_x = (index as i32 * 2 + 1 - request.players.len() as i32) * 5; let spawn_x = (index as i32 * 2 + 1 - config.players.len() as i32) * 5;
fighter_roster.push(spawn_fighter( fighter_roster.push(spawn_fighter(
&mut commands, &mut commands,
player.handle, player.handle,
@@ -447,10 +500,12 @@ pub fn prepare_match(
animations, animations,
attack_scripts, attack_scripts,
WorldAssetRoot(scene), WorldAssetRoot(scene),
ecb_bone_indices
)); ));
} }
commands.insert_resource(FighterRoster(fighter_roster)); commands.insert_resource(FighterRoster(fighter_roster));
commands.insert_resource(MatchState::from_config(&config));
commands.insert_resource(session_config); commands.insert_resource(session_config);
commands.insert_resource(ConnectionStatus::default()); commands.insert_resource(ConnectionStatus::default());
commands.insert_resource::<Session<GGRSCfg>>(session); commands.insert_resource::<Session<GGRSCfg>>(session);
@@ -487,7 +542,8 @@ pub fn cleanup_match(
commands.remove_resource::<ConnectionStatus>(); commands.remove_resource::<ConnectionStatus>();
commands.remove_resource::<stage::line::StageCollision>(); commands.remove_resource::<stage::line::StageCollision>();
commands.remove_resource::<MatchAssets>(); commands.remove_resource::<MatchAssets>();
commands.remove_resource::<PendingMatch>(); commands.remove_resource::<MatchConfig>();
commands.remove_resource::<MatchState>();
commands.remove_resource::<FighterRoster>(); commands.remove_resource::<FighterRoster>();
} }
@@ -496,8 +552,8 @@ mod tests {
use super::*; use super::*;
#[test] #[test]
fn match_request_keeps_duplicate_fighter_slots() { fn match_config_keeps_duplicate_fighter_slots() {
let request = PendingMatch { let config = MatchConfig {
stage: StageId::TestStage, stage: StageId::TestStage,
players: vec![ players: vec![
MatchPlayer { MatchPlayer {
@@ -509,12 +565,13 @@ mod tests {
fighter: FighterId::TestFighter, fighter: FighterId::TestFighter,
}, },
], ],
rules: MatchRules::default(),
}; };
assert_eq!(request.players.len(), 2); assert_eq!(config.players.len(), 2);
assert_eq!(request.players[0].handle, 0); assert_eq!(config.players[0].handle, 0);
assert_eq!(request.players[1].handle, 1); assert_eq!(config.players[1].handle, 1);
assert!(valid_player_handles(&request.players)); assert!(valid_player_handles(&config.players));
} }
#[test] #[test]
@@ -533,6 +590,53 @@ mod tests {
assert!(!valid_player_handles(&players)); assert!(!valid_player_handles(&players));
} }
#[test]
fn match_rules_reject_zero_limits() {
assert!(
MatchRules::Stock {
starting_stocks: 0,
time_limit_frames: None,
}
.validate()
.is_err()
);
assert!(
MatchRules::Stock {
starting_stocks: 3,
time_limit_frames: Some(0),
}
.validate()
.is_err()
);
assert!(
MatchRules::Timed {
time_limit_frames: 0,
}
.validate()
.is_err()
);
}
#[test]
fn match_rules_accept_valid_modes() {
assert!(MatchRules::default().validate().is_ok());
assert!(
MatchRules::Stock {
starting_stocks: 3,
time_limit_frames: Some(60),
}
.validate()
.is_ok()
);
assert!(
MatchRules::Timed {
time_limit_frames: 60,
}
.validate()
.is_ok()
);
}
#[test] #[test]
fn match_loading_waits_for_attack_scripts() { fn match_loading_waits_for_attack_scripts() {
let mut attack_scripts = HashMap::new(); let mut attack_scripts = HashMap::new();
+102
View File
@@ -0,0 +1,102 @@
//! Rollback-simulated state for an active match.
use bevy::prelude::*;
use bevy_ggrs::prelude::*;
use crate::match_loading::{MatchConfig, MatchRules};
#[derive(Resource, Clone, Debug, Hash, PartialEq, Eq)]
pub struct MatchState {
pub elapsed_frames: u32,
/// Indexed by the player's session handle.
pub players: Vec<PlayerMatchState>,
}
#[derive(Clone, Debug, Hash, PartialEq, Eq)]
pub struct PlayerMatchState {
pub stocks_remaining: Option<u8>,
pub score: i32,
pub deaths: u32,
}
impl MatchState {
pub fn from_config(config: &MatchConfig) -> Self {
let stocks_remaining = match &config.rules {
MatchRules::Stock {
starting_stocks, ..
} => Some(*starting_stocks),
MatchRules::Timed { .. } => None,
};
Self {
elapsed_frames: 0,
players: (0..config.players.len())
.map(|_| PlayerMatchState {
stocks_remaining,
score: 0,
deaths: 0,
})
.collect(),
}
}
}
pub struct MatchRuntimePlugin;
impl Plugin for MatchRuntimePlugin {
fn build(&self, app: &mut App) {
app.rollback_resource_with_clone::<MatchState>()
.checksum_resource_with_hash::<MatchState>();
}
}
#[cfg(test)]
mod tests {
use super::*;
use crate::{fighter::FighterId, match_loading::MatchPlayer, stage::manifest::StageId};
fn config(rules: MatchRules) -> MatchConfig {
MatchConfig {
stage: StageId::TestStage,
players: vec![
MatchPlayer {
handle: 1,
fighter: FighterId::TestFighter,
},
MatchPlayer {
handle: 0,
fighter: FighterId::TestFighter,
},
],
rules,
}
}
#[test]
fn stock_state_starts_with_configured_stocks() {
let state = MatchState::from_config(&config(MatchRules::Stock {
starting_stocks: 4,
time_limit_frames: Some(60),
}));
assert_eq!(state.elapsed_frames, 0);
assert_eq!(state.players.len(), 2);
assert!(state.players.iter().all(|player| {
player.stocks_remaining == Some(4) && player.score == 0 && player.deaths == 0
}));
}
#[test]
fn timed_state_has_no_stock_counter() {
let state = MatchState::from_config(&config(MatchRules::Timed {
time_limit_frames: 60,
}));
assert!(
state
.players
.iter()
.all(|player| player.stocks_remaining.is_none())
);
}
}
+10 -1
View File
@@ -2,7 +2,7 @@ use bevy::math::Vec2;
use bevy::prelude::*; use bevy::prelude::*;
use fixed::types::I32F32; use fixed::types::I32F32;
use serde::{Deserialize, Serialize}; use serde::{Deserialize, Serialize};
use std::ops::{Add, AddAssign, Div, Mul, MulAssign, Sub}; use std::ops::{Add, AddAssign, Div, Mul, MulAssign, Sub, SubAssign};
use super::int::{FGWide, FGi32}; use super::int::{FGWide, FGi32};
@@ -227,6 +227,15 @@ impl AddAssign for FGVec2 {
} }
} }
impl SubAssign for FGVec2 {
fn sub_assign(&mut self, rhs: Self) {
*self = Self {
x: self.x - rhs.x,
y: self.y - rhs.y,
}
}
}
impl MulAssign for FGVec2 { impl MulAssign for FGVec2 {
fn mul_assign(&mut self, rhs: Self) { fn mul_assign(&mut self, rhs: Self) {
*self = Self { *self = Self {
+3 -14
View File
@@ -1,19 +1,8 @@
use bevy::{picking::pointer::PointerId, prelude::*}; use bevy::{picking::pointer::PointerId, prelude::*};
use crate::{ use crate::{
AppState, AppState, fighter::manifest::{FighterManifest, FighterManifestRegistry}, game_settings::CommonAssets, input::{LocalInputAssignments, LocalInputSource}, menus::{
fighter::manifest::{FighterManifest, FighterManifestRegistry}, MenuCameraMarker, MenuMarker, button::FGUiButton, character_select::{character_box::CharacterBox, token::CharacterSelectToken}, cursor::{FGMenuCursor, MenuCursorInputSource}, errors::MenuErrors::FighterManifestNotFound, match_config::{MenuMatchConfig, MenuMatchPlayerSlot}, scaling, spawn_menu, style::{FGUiButtonType, FGUiStyle},
game_settings::CommonAssets,
input::{LocalInputAssignments, LocalInputSource},
menus::{
MenuMarker,
button::FGUiButton,
character_select::{character_box::CharacterBox, token::CharacterSelectToken},
cursor::{FGMenuCursor, MenuCursorInputSource},
errors::MenuErrors::FighterManifestNotFound,
match_config::{MenuMatchConfig, MenuMatchPlayerSlot},
scaling, spawn_menu,
style::{FGUiButtonType, FGUiStyle},
}, },
}; };
@@ -241,7 +230,7 @@ pub fn copy_cursor_transform_to_token(
character_boxes: Query<(&CharacterBox, &ComputedNode, &UiGlobalTransform)>, character_boxes: Query<(&CharacterBox, &ComputedNode, &UiGlobalTransform)>,
match_config: Res<MenuMatchConfig>, match_config: Res<MenuMatchConfig>,
cursors: Query<&UiGlobalTransform, With<FGMenuCursor>>, cursors: Query<&UiGlobalTransform, With<FGMenuCursor>>,
cam: Single<&Camera, With<IsDefaultUiCamera>>, cam: Single<&Camera, With<MenuCameraMarker>>,
ui_scale: Res<UiScale>, ui_scale: Res<UiScale>,
) -> Result { ) -> Result {
let camera = cam.into_inner(); let camera = cam.into_inner();
+3 -6
View File
@@ -9,11 +9,8 @@ use bevy::{
}; };
use crate::{ use crate::{
input::{LocalInputAssignments, LocalInputSource}, input::{LocalInputAssignments, LocalInputSource}, menus::{
menus::{ MenuCameraMarker, input::{MenuInput, MenuInputState}, scaling, style::FGUiStyle,
input::{MenuInput, MenuInputState},
scaling,
style::FGUiStyle,
}, },
}; };
@@ -181,7 +178,7 @@ pub fn cursor_input(
} }
pub fn update_cursor_transform( pub fn update_cursor_transform(
camera: Single<&Camera, With<IsDefaultUiCamera>>, camera: Single<&Camera, With<MenuCameraMarker>>,
query: Query<(&mut Node, &PointerLocation), With<FGMenuCursor>>, query: Query<(&mut Node, &PointerLocation), With<FGMenuCursor>>,
ui_scale: Res<UiScale>, ui_scale: Res<UiScale>,
) { ) {
+22 -3
View File
@@ -3,7 +3,7 @@ use thiserror::Error;
use crate::{ use crate::{
fighter::FighterId, fighter::FighterId,
match_loading::{MatchPlayer, PendingMatch}, match_loading::{MatchConfig, MatchPlayer, MatchRules},
stage::manifest::StageId, stage::manifest::StageId,
}; };
@@ -60,7 +60,7 @@ impl MenuMatchConfig {
!has_unselected_fighter !has_unselected_fighter
} }
pub fn to_pending_match(&self) -> Result<PendingMatch, MenuMatchConfigErrors> { pub fn to_match_config(&self) -> Result<MatchConfig, MenuMatchConfigErrors> {
let mut match_players = vec![]; let mut match_players = vec![];
let stage = self.stage.ok_or(MenuMatchConfigErrors::StageNotSelected)?; let stage = self.stage.ok_or(MenuMatchConfigErrors::StageNotSelected)?;
@@ -78,9 +78,28 @@ impl MenuMatchConfig {
}); });
} }
Ok(PendingMatch { Ok(MatchConfig {
players: match_players, players: match_players,
stage, stage,
rules: MatchRules::default(),
}) })
} }
} }
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn menu_config_uses_default_match_rules() {
let menu = MenuMatchConfig {
stage: Some(StageId::TestStage),
players: vec![MenuMatchPlayerSlot {
slot: 0,
fighter: Some(FighterId::TestFighter),
}],
};
assert_eq!(menu.to_match_config().unwrap().rules, MatchRules::default());
}
}
+11 -14
View File
@@ -25,6 +25,8 @@ pub mod style;
#[derive(Component, Clone, Default)] #[derive(Component, Clone, Default)]
pub struct MenuMarker {} pub struct MenuMarker {}
#[derive(Component, Clone, Default)]
pub struct MenuCameraMarker {}
pub struct MenuPlugin; pub struct MenuPlugin;
@@ -38,6 +40,7 @@ pub fn wrap_menu(menu: impl Scene) -> impl Scene {
bsn! { bsn! {
#MenuRoot #MenuRoot
MenuMarker MenuMarker
Transform
Node { Node {
width: percent(100), width: percent(100),
height: percent(100), height: percent(100),
@@ -46,6 +49,12 @@ pub fn wrap_menu(menu: impl Scene) -> impl Scene {
flex_direction: FlexDirection::Column, flex_direction: FlexDirection::Column,
} }
Children [ Children [
(
#MenuCamera
Camera
Camera2d
MenuCameraMarker
),
( (
#MenuContainer #MenuContainer
Node { Node {
@@ -70,10 +79,9 @@ pub fn despawn_menu(
if let Some(entity) = existing_menu { if let Some(entity) = existing_menu {
commands commands
.entity(entity.into_inner()) .entity(entity.into_inner())
.remove::<Camera2d>()
.remove::<Camera>()
.despawn(); .despawn();
} }
} }
pub fn spawn_menu( pub fn spawn_menu(
@@ -84,8 +92,6 @@ pub fn spawn_menu(
if let Some(entity) = existing_menu { if let Some(entity) = existing_menu {
commands commands
.entity(entity.into_inner()) .entity(entity.into_inner())
.remove::<Camera2d>()
.remove::<Camera>()
.despawn(); .despawn();
} }
commands.queue_spawn_scene(wrap_menu(menu)); commands.queue_spawn_scene(wrap_menu(menu));
@@ -113,16 +119,7 @@ impl Plugin for MenuPlugin {
fn build(&self, app: &mut App) { fn build(&self, app: &mut App) {
app.add_systems( app.add_systems(
OnEnter(AppState::MainMenu), OnEnter(AppState::MainMenu),
(build_menu::<MainMenu>, |mut commands: Commands| { build_menu::<MainMenu>,
commands.spawn((Camera2d, IsDefaultUiCamera));
commands.spawn((
Camera2d,
Camera {
order: 1,
..default()
},
));
}),
) )
.add_message::<character_select::PlayerSlotAssigned>() .add_message::<character_select::PlayerSlotAssigned>()
.init_resource::<navigation::UINavigationActionState>() .init_resource::<navigation::UINavigationActionState>()
+1 -1
View File
@@ -77,7 +77,7 @@ pub fn stage_selected(
initiate_match( initiate_match(
&mut commands, &mut commands,
&mut next_state, &mut next_state,
match_config.to_pending_match()?, match_config.to_match_config()?,
); );
} }
Ok(()) Ok(())
+102 -45
View File
@@ -12,16 +12,12 @@ use clap::ValueEnum;
use serde::{Deserialize, Serialize}; use serde::{Deserialize, Serialize};
use crate::{ use crate::{
AppState, AppState, args::Args, input::FighterInputFrame, match_loading::MatchConfig, netcode::GGRSCfg,
args::Args,
input::FighterInputFrame,
match_loading::{MatchPlayer, PendingMatch},
netcode::GGRSCfg,
schedule::GameplaySet, schedule::GameplaySet,
}; };
const MAGIC: &[u8; 8] = b"SPRPLY01"; const MAGIC: &[u8; 8] = b"SPRPLY01";
pub const REPLAY_VERSION: u32 = 1; pub const REPLAY_VERSION: u32 = 2;
#[derive(Clone, Copy, Debug, Default, Eq, PartialEq, ValueEnum)] #[derive(Clone, Copy, Debug, Default, Eq, PartialEq, ValueEnum)]
pub enum ReplayFormat { pub enum ReplayFormat {
@@ -34,17 +30,11 @@ pub enum ReplayFormat {
pub struct Replay { pub struct Replay {
pub replay_version: u32, pub replay_version: u32,
pub game_version: String, pub game_version: String,
pub match_config: ReplayMatch, pub match_config: MatchConfig,
pub frames: Vec<ReplayFrame>, pub frames: Vec<ReplayFrame>,
pub checksums: Vec<ReplayChecksum>, pub checksums: Vec<ReplayChecksum>,
} }
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
pub struct ReplayMatch {
pub stage: crate::stage::manifest::StageId,
pub players: Vec<MatchPlayer>,
}
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)] #[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
pub struct ReplayFrame { pub struct ReplayFrame {
pub frame: i32, pub frame: i32,
@@ -162,6 +152,20 @@ fn validate(replay: &Replay) -> Result<(), String> {
{ {
return Err("replay frames must be strictly ordered".into()); return Err("replay frames must be strictly ordered".into());
} }
if replay
.frames
.windows(2)
.any(|frames| frames[0].frame.checked_add(1) != Some(frames[1].frame))
{
return Err("replay frames must be contiguous".into());
}
if replay
.checksums
.windows(2)
.any(|checksums| checksums[0].frame >= checksums[1].frame)
{
return Err("replay checksums must be strictly ordered".into());
}
if replay if replay
.frames .frames
.iter() .iter()
@@ -183,6 +187,21 @@ impl Replay {
handles.sort_unstable(); handles.sort_unstable();
handles != (0..handles.len()).collect::<Vec<_>>() handles != (0..handles.len()).collect::<Vec<_>>()
} }
fn frame(&self, frame: i32) -> Option<&ReplayFrame> {
let first_frame = self.frames.first()?.frame;
let index = frame.checked_sub(first_frame)? as usize;
self.frames
.get(index)
.filter(|recorded| recorded.frame == frame)
}
fn checksum(&self, frame: i32) -> Option<u128> {
self.checksums
.binary_search_by_key(&frame, |checksum| checksum.frame)
.ok()
.map(|index| self.checksums[index].checksum)
}
} }
fn start_replay(mut commands: Commands, args: Res<Args>, loaded: Option<Res<LoadedReplay>>) { fn start_replay(mut commands: Commands, args: Res<Args>, loaded: Option<Res<LoadedReplay>>) {
@@ -220,11 +239,7 @@ fn replay_inputs(
.insert(frame.0, inputs.iter().map(|(input, _)| *input).collect()); .insert(frame.0, inputs.iter().map(|(input, _)| *input).collect());
} }
ReplayMode::Playback { replay, mismatch } if !*mismatch => { ReplayMode::Playback { replay, mismatch } if !*mismatch => {
let Some(recorded) = replay let Some(recorded) = replay.frame(frame.0) else {
.frames
.iter()
.find(|recorded| recorded.frame == frame.0)
else {
error!("Replay has no input for frame {}", frame.0); error!("Replay has no input for frame {}", frame.0);
*mismatch = true; *mismatch = true;
return; return;
@@ -245,21 +260,15 @@ fn record_checksum(
let Some(mut runtime) = runtime else { return }; let Some(mut runtime) = runtime else { return };
if matches!(&runtime.mode, ReplayMode::Record { .. }) { if matches!(&runtime.mode, ReplayMode::Record { .. }) {
runtime.checksums.insert(frame.0, checksum.0); runtime.checksums.insert(frame.0, checksum.0);
} else if let ReplayMode::Playback { replay, mismatch } = &mut runtime.mode { } else if let ReplayMode::Playback { replay, mismatch } = &mut runtime.mode
if let Some(expected) = replay && let Some(expected) = replay.checksum(frame.0)
.checksums && expected != checksum.0
.iter() {
.find(|value| value.frame == frame.0) error!(
.map(|value| value.checksum) "Replay desync at frame {}: expected {:X}, got {:X}",
{ frame.0, expected, checksum.0
if expected != checksum.0 { );
error!( *mismatch = true;
"Replay desync at frame {}: expected {:X}, got {:X}",
frame.0, expected, checksum.0
);
*mismatch = true;
}
}
} }
} }
@@ -267,27 +276,27 @@ fn stop_recording(
mut commands: Commands, mut commands: Commands,
stop_request: Option<Res<StopReplayRecording>>, stop_request: Option<Res<StopReplayRecording>>,
runtime: Option<ResMut<ReplayRuntime>>, runtime: Option<ResMut<ReplayRuntime>>,
request: Option<Res<PendingMatch>>, config: Option<Res<MatchConfig>>,
) { ) {
if stop_request.is_none() { if stop_request.is_none() {
return; return;
} }
commands.remove_resource::<StopReplayRecording>(); commands.remove_resource::<StopReplayRecording>();
finish_recording_inner(&mut commands, runtime, request); finish_recording_inner(&mut commands, runtime, config);
} }
fn finish_recording( fn finish_recording(
mut commands: Commands, mut commands: Commands,
runtime: Option<ResMut<ReplayRuntime>>, runtime: Option<ResMut<ReplayRuntime>>,
request: Option<Res<PendingMatch>>, config: Option<Res<MatchConfig>>,
) { ) {
finish_recording_inner(&mut commands, runtime, request); finish_recording_inner(&mut commands, runtime, config);
} }
fn finish_recording_inner( fn finish_recording_inner(
commands: &mut Commands, commands: &mut Commands,
runtime: Option<ResMut<ReplayRuntime>>, runtime: Option<ResMut<ReplayRuntime>>,
request: Option<Res<PendingMatch>>, config: Option<Res<MatchConfig>>,
) { ) {
let Some(mut runtime) = runtime else { return }; let Some(mut runtime) = runtime else { return };
let ReplayMode::Record { path, format } = &runtime.mode else { let ReplayMode::Record { path, format } = &runtime.mode else {
@@ -296,16 +305,13 @@ fn finish_recording_inner(
if runtime.finished || runtime.frames.is_empty() { if runtime.finished || runtime.frames.is_empty() {
return; return;
} }
let Some(request) = request else { return }; let Some(config) = config else { return };
let path = path.clone(); let path = path.clone();
let format = *format; let format = *format;
let replay = Replay { let replay = Replay {
replay_version: REPLAY_VERSION, replay_version: REPLAY_VERSION,
game_version: env!("CARGO_PKG_VERSION").into(), game_version: env!("CARGO_PKG_VERSION").into(),
match_config: ReplayMatch { match_config: config.as_ref().clone(),
stage: request.stage,
players: request.players.clone(),
},
frames: runtime frames: runtime
.frames .frames
.iter() .iter()
@@ -355,7 +361,7 @@ mod tests {
use super::*; use super::*;
use crate::{ use crate::{
fighter::FighterId, fighter::FighterId,
match_loading::MatchPlayer, match_loading::{MatchPlayer, MatchRules},
math::{int::FGi32, vec::FGVec2}, math::{int::FGi32, vec::FGVec2},
stage::manifest::StageId, stage::manifest::StageId,
}; };
@@ -364,12 +370,15 @@ mod tests {
Replay { Replay {
replay_version: REPLAY_VERSION, replay_version: REPLAY_VERSION,
game_version: "test".into(), game_version: "test".into(),
match_config: ReplayMatch { match_config: MatchConfig {
stage: StageId::TestStage, stage: StageId::TestStage,
players: vec![MatchPlayer { players: vec![MatchPlayer {
handle: 0, handle: 0,
fighter: FighterId::TestFighter, fighter: FighterId::TestFighter,
}], }],
rules: MatchRules::Timed {
time_limit_frames: 21_600,
},
}, },
frames: vec![ReplayFrame { frames: vec![ReplayFrame {
frame: 1, frame: 1,
@@ -406,4 +415,52 @@ mod tests {
replay.frames[0].inputs.clear(); replay.frames[0].inputs.clear();
assert!(validate(&replay).is_err()); assert!(validate(&replay).is_err());
} }
#[test]
fn unsupported_replay_version_is_rejected() {
let mut replay = sample();
replay.replay_version = 1;
assert_eq!(
validate(&replay).unwrap_err(),
"unsupported replay version 1"
);
}
#[test]
fn playback_lookups_use_frame_offsets_and_support_sparse_checksums() {
let mut replay = sample();
replay.frames[0].frame = 10;
replay.frames.push(ReplayFrame {
frame: 11,
inputs: replay.frames[0].inputs.clone(),
});
replay.checksums.push(ReplayChecksum {
frame: 11,
checksum: 84,
});
replay.checksums[0].frame = 10;
validate(&replay).unwrap();
assert_eq!(replay.frame(10).unwrap().frame, 10);
assert_eq!(replay.frame(11).unwrap().frame, 11);
assert!(replay.frame(9).is_none());
assert_eq!(replay.checksum(10), Some(42));
assert_eq!(replay.checksum(11), Some(84));
assert_eq!(replay.checksum(12), None);
}
#[test]
fn noncontiguous_input_frames_are_rejected() {
let mut replay = sample();
replay.frames.push(ReplayFrame {
frame: 3,
inputs: replay.frames[0].inputs.clone(),
});
assert_eq!(
validate(&replay).unwrap_err(),
"replay frames must be contiguous"
);
}
} }
+3 -3
View File
@@ -19,10 +19,10 @@ pub enum GameplaySet {
StateUpdate, StateUpdate,
/// Integrate velocities into positions. /// Integrate velocities into positions.
Physics, Physics,
/// Solve collision boxes
Animation,
/// Resolve the integrated positions against the stage. /// Resolve the integrated positions against the stage.
Collision, Collision,
/// Solve collision boxes
Animation,
/// Resolve attacks /// Resolve attacks
Attacks, Attacks,
} }
@@ -40,8 +40,8 @@ impl Plugin for GameplaySchedulePlugin {
GameplaySet::Interrupt, GameplaySet::Interrupt,
GameplaySet::StateUpdate, GameplaySet::StateUpdate,
GameplaySet::Physics, GameplaySet::Physics,
GameplaySet::Collision,
GameplaySet::Animation, GameplaySet::Animation,
GameplaySet::Collision,
GameplaySet::Attacks, GameplaySet::Attacks,
) )
.chain(), .chain(),
+2 -2
View File
@@ -26,7 +26,7 @@ pub enum StagePolyType {
Platform, Platform,
} }
#[derive(Reflect, Hash, Debug, Clone, Copy, Default)] #[derive(Reflect, Hash, Debug, Clone, Copy, Default, PartialEq, Eq)]
pub struct StageLineID { pub struct StageLineID {
pub polygon: usize, pub polygon: usize,
pub segment: usize, pub segment: usize,
@@ -34,7 +34,7 @@ pub struct StageLineID {
#[derive(Reflect, Clone, Default)] #[derive(Reflect, Clone, Default)]
pub struct StagePoly { pub struct StagePoly {
poly_type: StagePolyType, pub poly_type: StagePolyType,
pub segments: Vec<StagePolyLineSegment>, pub segments: Vec<StagePolyLineSegment>,
} }
+17 -8
View File
@@ -1,20 +1,29 @@
use bevy::prelude::*; use bevy::prelude::*;
use crate::{ use crate::{
fighter::manifest::{FighterManifest, FighterManifestRegistry}, match_loading::{PendingMatch}, ui::{errors::UIErrors, fighter_info::FighterInfoUI}, fighter::manifest::{FighterManifest, FighterManifestRegistry},
match_loading::MatchConfig,
ui::{errors::UIErrors, fighter_info::FighterInfoUI},
}; };
#[derive(Component, FromTemplate)] #[derive(Component, FromTemplate)]
pub struct BattleUI { pub struct BattleUI {}
}
pub fn spawn_battle_ui(mut commands: Commands, request: Res<PendingMatch>, fighter_registry: Res<FighterManifestRegistry>, manifests: Res<Assets<FighterManifest>>) -> Result {
pub fn spawn_battle_ui(
mut commands: Commands,
config: Res<MatchConfig>,
fighter_registry: Res<FighterManifestRegistry>,
manifests: Res<Assets<FighterManifest>>,
) -> Result {
let mut fighter_uis = vec![]; let mut fighter_uis = vec![];
for player in &request.players { for player in &config.players {
let manifest = fighter_registry.get(player.fighter).ok_or_else(|| UIErrors::FighterManifestHandleNotFound(player.fighter))?; let manifest = fighter_registry
let manifest = manifests.get(manifest).ok_or_else(|| UIErrors::FighterManifestNotFound(player.fighter))?; .get(player.fighter)
.ok_or_else(|| UIErrors::FighterManifestHandleNotFound(player.fighter))?;
let manifest = manifests
.get(manifest)
.ok_or_else(|| UIErrors::FighterManifestNotFound(player.fighter))?;
fighter_uis.push(FighterInfoUI::build(manifest, player)); fighter_uis.push(FighterInfoUI::build(manifest, player));
} }
+52 -6
View File
@@ -1,13 +1,17 @@
use bevy::prelude::*; use bevy::prelude::*;
use crate::{fighter::{attack::FighterDamage, manifest::{FighterManifest}}, match_loading::MatchPlayer, player::Player}; use crate::{
fighter::{attack::FighterDamage, manifest::FighterManifest}, match_loading::{MatchPlayer}, match_runtime::MatchState, player::Player, ui::stock_icon::BattleUIStockIcon,
};
#[derive(Component, FromTemplate)] #[derive(Component, FromTemplate)]
pub struct FighterInfoUI { pub struct FighterInfoUI {
percentage_text: Entity, percentage_text: Entity,
stock_icon_container: Entity,
_name_text: Entity, _name_text: Entity,
player_handle: usize, player_handle: usize,
visible_damage: FighterDamage, visible_damage: FighterDamage,
visible_stocks: u8,
} }
impl FighterInfoUI { impl FighterInfoUI {
@@ -16,6 +20,7 @@ impl FighterInfoUI {
bsn! { bsn! {
FighterInfoUI { FighterInfoUI {
percentage_text: #PercentageText, percentage_text: #PercentageText,
stock_icon_container: #StockIconContainer,
_name_text: #NameText, _name_text: #NameText,
player_handle: {match_player.handle} player_handle: {match_player.handle}
} }
@@ -25,6 +30,10 @@ impl FighterInfoUI {
justify_content: JustifyContent::Center, justify_content: JustifyContent::Center,
} }
Children [ Children [
(
#StockIconContainer
Node
)
( (
#PercentageText #PercentageText
Text("0.00%") Text("0.00%")
@@ -41,17 +50,54 @@ impl FighterInfoUI {
} }
} }
pub fn update_fighter_info_damage(fighters: Query<(&Player, &FighterDamage)>, ui_elements: Query<&mut FighterInfoUI>, mut commands: Commands) { pub fn update_fighter_info_damage(
fighters: Query<(&Player, &FighterDamage)>,
ui_elements: Query<&mut FighterInfoUI>,
mut commands: Commands,
) {
for mut ui_element in ui_elements { for mut ui_element in ui_elements {
let Some((_, damage)) = fighters.iter().find(|(player, _)| { let Some((_, damage)) = fighters
player.handle == ui_element.player_handle .iter()
}) else { .find(|(player, _)| player.handle == ui_element.player_handle)
else {
continue; continue;
}; };
if *damage != ui_element.visible_damage { if *damage != ui_element.visible_damage {
commands.entity(ui_element.percentage_text).insert(Text(format!("{}%", damage))); commands
.entity(ui_element.percentage_text)
.insert(Text(format!("{}%", damage)));
ui_element.visible_damage = damage.clone(); ui_element.visible_damage = damage.clone();
} }
} }
} }
pub fn update_fighter_info_stocks(
match_state: Res<MatchState>,
ui_elements: Query<&mut FighterInfoUI>,
mut commands: Commands,
) {
for mut ui_element in ui_elements {
let handle = ui_element.player_handle;
let Some(match_player) = match_state.players.get(handle) else {
continue;
};
let Some(stocks) = match_player.stocks_remaining else {
continue;
};
if stocks != ui_element.visible_stocks {
commands
.entity(ui_element.stock_icon_container)
.despawn_children()
.with_children(|spawner| {
for _ in 0..stocks {
spawner.spawn_empty().apply_scene(BattleUIStockIcon::scene());
}
});
ui_element.visible_stocks = stocks;
}
}
}
+21 -2
View File
@@ -1,10 +1,15 @@
use bevy::prelude::*; use bevy::prelude::*;
use crate::AppState; use crate::{
AppState,
match_loading::{MatchConfig, MatchRules},
match_runtime::MatchState,
};
pub mod battle_ui; pub mod battle_ui;
pub mod errors; pub mod errors;
pub mod fighter_info; pub mod fighter_info;
pub mod stock_icon;
#[derive(Default)] #[derive(Default)]
pub struct InGameUIPlugin; pub struct InGameUIPlugin;
@@ -13,6 +18,20 @@ impl Plugin for InGameUIPlugin {
fn build(&self, app: &mut App) { fn build(&self, app: &mut App) {
app.add_systems(OnEnter(AppState::InMatch), battle_ui::spawn_battle_ui) app.add_systems(OnEnter(AppState::InMatch), battle_ui::spawn_battle_ui)
.add_systems(OnExit(AppState::InMatch), battle_ui::cleanup_battle_ui) .add_systems(OnExit(AppState::InMatch), battle_ui::cleanup_battle_ui)
.add_systems(PostUpdate, fighter_info::update_fighter_info_damage); .add_systems(PostUpdate, fighter_info::update_fighter_info_damage)
.add_systems(
PostUpdate,
fighter_info::update_fighter_info_stocks.run_if(
resource_exists::<MatchState>
.and_then(resource_exists::<MatchConfig>)
.and_then(|match_config: Res<MatchConfig>| {
if let MatchRules::Stock { .. } = match_config.rules {
true
} else {
false
}
}),
),
);
} }
} }
+17
View File
@@ -0,0 +1,17 @@
use bevy::prelude::*;
#[derive(SceneComponent, Clone, FromTemplate)]
pub struct BattleUIStockIcon;
impl BattleUIStockIcon {
pub fn scene() -> impl Scene {
bsn! {
Node {
width: px(32),
height: px(32),
border_radius: BorderRadius::MAX,
}
BackgroundColor({bevy::color::palettes::css::RED})
}
}
}
+123
View File
@@ -0,0 +1,123 @@
"""LLDB summaries for Rust's `fixed` crate.
Load this file from LLDB with:
command script import /path/to/shinespark/tools/lldb_fixed.py
The implementation does not use floating-point arithmetic, so displayed values
are exact even for FixedI128/FixedU128 values.
"""
import re
try:
import lldb
except ImportError:
# Keep the pure parsing and formatting helpers testable without LLDB.
lldb = None
_FIXED_TYPE_RE = re.compile(r"(?:^|::)Fixed([IU])(8|16|32|64|128)<(.+)>$")
_DIRECT_TYPENUM_RE = re.compile(r"(?:^|::)U(\d+)$")
_TYPENUM_BIT_RE = re.compile(r"(?:^|::)B([01])(?=\s*[,>])")
def parse_fixed_type(type_name):
"""Return (signed, storage_bits, fractional_bits), or None."""
if not type_name:
return None
match = _FIXED_TYPE_RE.search(type_name.replace(" ", ""))
if match is None:
return None
signed = match.group(1) == "I"
storage_bits = int(match.group(2))
fractional_type = match.group(3)
direct = _DIRECT_TYPENUM_RE.search(fractional_type)
if direct is not None:
fractional_bits = int(direct.group(1))
else:
# typenum represents UInt<N, B> as a binary tree. Its textual Rust
# type lists the bits from most significant to least significant.
digits = _TYPENUM_BIT_RE.findall(fractional_type)
if not digits:
return None
fractional_bits = int("".join(digits), 2)
if fractional_bits > storage_bits:
return None
return signed, storage_bits, fractional_bits
def normalize_bits(raw_bits, signed, storage_bits):
"""Interpret a possibly unsigned LLDB integer using the fixed type's width."""
mask = (1 << storage_bits) - 1
raw_bits &= mask
if signed and raw_bits >= 1 << (storage_bits - 1):
raw_bits -= 1 << storage_bits
return raw_bits
def format_fixed(raw_bits, fractional_bits):
"""Format a scaled integer exactly as a decimal string."""
if fractional_bits == 0:
return str(raw_bits)
negative = raw_bits < 0
magnitude = -raw_bits if negative else raw_bits
whole = magnitude >> fractional_bits
remainder = magnitude & ((1 << fractional_bits) - 1)
if remainder == 0:
result = str(whole)
else:
# remainder / 2^n == (remainder * 5^n) / 10^n, which gives a finite,
# exact decimal representation without converting through a float.
decimal = str(remainder * 5**fractional_bits).zfill(fractional_bits)
result = f"{whole}.{decimal.rstrip('0')}"
return f"-{result}" if negative else result
def _parse_lldb_integer(value):
text = value.GetValue()
if text is not None:
try:
return int(text, 0)
except ValueError:
pass
# GetValueAsUnsigned is also useful on LLDB versions that do not render
# primitive values through GetValue. It is sufficient for all <= 64-bit
# fixed types; current LLDB versions render i128/u128 through GetValue.
return value.GetValueAsUnsigned()
def fixed_summary(value, _internal_dict):
layout = parse_fixed_type(value.GetTypeName())
if layout is None:
return None
signed, storage_bits, fractional_bits = layout
bits = value.GetChildMemberWithName("bits")
if not bits.IsValid():
return None
raw_bits = _parse_lldb_integer(bits)
raw_bits = normalize_bits(raw_bits, signed, storage_bits)
return format_fixed(raw_bits, fractional_bits)
def __lldb_init_module(debugger, _internal_dict):
# LLDB's type-name regex sees the concrete fixed type rather than project
# aliases such as FGi32 and FGWide.
debugger.HandleCommand(
"type summary add --python-function lldb_fixed.fixed_summary "
"--category Shinespark --regex "
"'^fixed::Fixed(I|U)(8|16|32|64|128)<.+>$'"
)
# A dedicated category makes the formatter work even when CodeLLDB has not
# enabled rustc's standard `Rust` formatter category yet.
debugger.HandleCommand("type category enable Shinespark")
+58
View File
@@ -0,0 +1,58 @@
import unittest
import lldb_fixed
class ParseFixedTypeTests(unittest.TestCase):
def test_direct_typenum_alias(self):
self.assertEqual(
lldb_fixed.parse_fixed_type("fixed::FixedI32<typenum::uint::U16>"),
(True, 32, 16),
)
def test_expanded_typenum(self):
type_name = (
"fixed::FixedI32<"
"typenum::uint::UInt<"
"typenum::uint::UInt<"
"typenum::uint::UInt<"
"typenum::uint::UInt<"
"typenum::uint::UInt<typenum::uint::UTerm, typenum::bit::B1>, "
"typenum::bit::B0>, typenum::bit::B0>, typenum::bit::B0>, "
"typenum::bit::B0>>"
)
self.assertEqual(lldb_fixed.parse_fixed_type(type_name), (True, 32, 16))
def test_unsigned_type(self):
self.assertEqual(
lldb_fixed.parse_fixed_type("fixed::FixedU64<typenum::uint::U24>"),
(False, 64, 24),
)
def test_unrelated_type(self):
self.assertIsNone(lldb_fixed.parse_fixed_type("core::primitive::i32"))
class FormatFixedTests(unittest.TestCase):
def test_q16_16(self):
self.assertEqual(lldb_fixed.format_fixed(3 << 15, 16), "1.5")
self.assertEqual(lldb_fixed.format_fixed(-(3 << 15), 16), "-1.5")
self.assertEqual(lldb_fixed.format_fixed(1, 16), "0.0000152587890625")
def test_integer_value_has_no_decimal_suffix(self):
self.assertEqual(lldb_fixed.format_fixed(12 << 16, 16), "12")
def test_q96_32(self):
raw = (1 << 100) + (1 << 31)
self.assertEqual(
lldb_fixed.format_fixed(raw, 32),
"295147905179352825856.5",
)
def test_twos_complement_normalization(self):
self.assertEqual(lldb_fixed.normalize_bits(0xFFFF8000, True, 32), -32768)
self.assertEqual(lldb_fixed.normalize_bits(0xFFFF8000, False, 32), 0xFFFF8000)
if __name__ == "__main__":
unittest.main()