Compare commits
9
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
46c2af8114 | ||
|
|
b56b7b0421 | ||
|
|
84e731fbc8 | ||
|
|
65727ed04f | ||
|
|
0cb81ec2e9 | ||
|
|
d521461625 | ||
|
|
3daf8f2e21 | ||
|
|
aea1cf35ff | ||
|
|
2e06cbb4b7 |
+23
-4
@@ -3,11 +3,9 @@
|
||||
use std::{collections::HashMap, time::Duration};
|
||||
|
||||
use bevy::{
|
||||
input::InputSystems,
|
||||
prelude::*,
|
||||
settings::{ReflectSettingsGroup, SaveSettingsDeferred, SettingsGroup},
|
||||
camera::{CameraOutputMode, visibility::RenderLayers}, input::InputSystems, prelude::*, render::render_resource::BlendState, settings::{ReflectSettingsGroup, SaveSettingsDeferred, SettingsGroup},
|
||||
};
|
||||
use bevy_egui::{EguiContexts, EguiPrimaryContextPass, egui};
|
||||
use bevy_egui::{EguiContexts, EguiGlobalSettings, EguiPrimaryContextPass, PrimaryEguiContext, egui};
|
||||
use bevy_ggrs::{RollbackFrameRate, RunGgrsSystems};
|
||||
use enum_cycling::EnumCycle;
|
||||
use enum_cycling_derive::EnumCycle;
|
||||
@@ -397,6 +395,7 @@ impl Plugin for DebugToolsPlugin {
|
||||
.before(RunGgrsSystems)
|
||||
.run_if(in_state(AppState::InMatch)),
|
||||
)
|
||||
.add_systems(Startup, spawn_egui_camera)
|
||||
.add_systems(PreUpdate, restore_frame_step_time.after(RunGgrsSystems))
|
||||
.add_systems(
|
||||
Update,
|
||||
@@ -408,6 +407,26 @@ impl Plugin for DebugToolsPlugin {
|
||||
}
|
||||
}
|
||||
|
||||
pub fn spawn_egui_camera(mut commands: Commands, mut egui_global_settings: ResMut<EguiGlobalSettings>,) {
|
||||
egui_global_settings.auto_create_primary_context = false;
|
||||
commands.spawn((
|
||||
// The `PrimaryEguiContext` component requires everything needed to render a primary context.
|
||||
PrimaryEguiContext,
|
||||
Camera2d,
|
||||
// Setting RenderLayers to none makes sure we won't render anything apart from the UI.
|
||||
RenderLayers::none(),
|
||||
Camera {
|
||||
order: 2,
|
||||
output_mode: CameraOutputMode::Write {
|
||||
blend_state: Some(BlendState::ALPHA_BLENDING),
|
||||
clear_color: ClearColorConfig::None,
|
||||
},
|
||||
clear_color: ClearColorConfig::Custom(Color::NONE),
|
||||
..default()
|
||||
},
|
||||
));
|
||||
}
|
||||
|
||||
fn player_handles(players: &Query<&Player>) -> Vec<usize> {
|
||||
let mut handles = players
|
||||
.iter()
|
||||
|
||||
@@ -84,6 +84,9 @@ pub enum AnimKind {
|
||||
AirDodge,
|
||||
Fall,
|
||||
Turn,
|
||||
CrouchEnter,
|
||||
CrouchIdle,
|
||||
CrouchExit,
|
||||
|
||||
FlinchGround,
|
||||
FlinchAir,
|
||||
|
||||
@@ -605,7 +605,6 @@ impl Plugin for FighterAttackPlugin {
|
||||
intersect_attacks_with_hurtboxes,
|
||||
)
|
||||
.chain()
|
||||
.after(crate::fighter::baked_animation::update_fighter_bone_matrices)
|
||||
.in_set(GameplaySet::Attacks),
|
||||
);
|
||||
}
|
||||
|
||||
@@ -219,6 +219,7 @@ mod tests {
|
||||
second.translate(FGVec3::lit("0", "3", "0"));
|
||||
let mut matrices = FighterBoneMatrices::default();
|
||||
matrices.set_pose(
|
||||
AnimKind::Wait,
|
||||
&["root".into(), "hand".into()],
|
||||
&[None, Some(0)],
|
||||
&[first, second],
|
||||
@@ -239,6 +240,7 @@ mod tests {
|
||||
hand.translate(FGVec3::lit("0", "3", "0"));
|
||||
let mut matrices = FighterBoneMatrices::default();
|
||||
matrices.set_pose(
|
||||
AnimKind::Wait,
|
||||
&["root".into(), "hand".into()],
|
||||
&[None, Some(0)],
|
||||
&[root, hand],
|
||||
@@ -266,9 +268,9 @@ mod tests {
|
||||
let parents = [None, Some(0)];
|
||||
let pose = [FixedMat4::IDENTITY, FixedMat4::IDENTITY];
|
||||
|
||||
matrices.set_pose(&names, &parents, &pose, FGi32::ONE);
|
||||
matrices.set_pose(AnimKind::Wait, &names, &parents, &pose, FGi32::ONE);
|
||||
let capacities = matrices.buffer_capacities();
|
||||
matrices.set_pose(&names, &parents, &pose, FGi32::ONE);
|
||||
matrices.set_pose(AnimKind::Wait, &names, &parents, &pose, FGi32::ONE);
|
||||
|
||||
assert_eq!(capacities, matrices.buffer_capacities());
|
||||
}
|
||||
@@ -281,6 +283,7 @@ mod tests {
|
||||
hand.translate(FGVec3::lit("0", "2", "0"));
|
||||
let mut matrices = FighterBoneMatrices::default();
|
||||
matrices.set_pose(
|
||||
AnimKind::Wait,
|
||||
&["root".into(), "hand".into()],
|
||||
&[None, Some(0)],
|
||||
&[root, hand],
|
||||
|
||||
@@ -71,6 +71,7 @@ pub struct FighterBoneMatrices {
|
||||
local_matrices: Vec<FixedMat4>,
|
||||
previous_local_matrices: Vec<FixedMat4>,
|
||||
model_matrices: Vec<Option<FixedMat4>>,
|
||||
presentation_kind: Option<AnimKind>,
|
||||
}
|
||||
|
||||
#[derive(Component, Clone, Debug, Default)]
|
||||
@@ -88,6 +89,12 @@ impl FighterBoneMatrices {
|
||||
]
|
||||
}
|
||||
|
||||
pub fn get_by_idx(&self, index: usize) -> Option<(FixedMat4, FixedMat4)> {
|
||||
Some((
|
||||
*self.previous_frame_matrices.get(index)?,
|
||||
*self.matrices.get(index)?,
|
||||
))
|
||||
}
|
||||
pub fn get(&self, bone: &str) -> Option<(FixedMat4, FixedMat4)> {
|
||||
let index = self.bone_names.iter().position(|name| name == bone)?;
|
||||
Some((
|
||||
@@ -132,6 +139,7 @@ impl FighterBoneMatrices {
|
||||
}
|
||||
pub(super) fn set_pose(
|
||||
&mut self,
|
||||
kind: AnimKind,
|
||||
bone_names: &[String],
|
||||
parents: &[Option<usize>],
|
||||
local: &[FixedMat4],
|
||||
@@ -160,6 +168,7 @@ impl FighterBoneMatrices {
|
||||
self.previous_local_matrices.reserve(local.len());
|
||||
self.model_matrices.reserve(local.len());
|
||||
std::mem::swap(&mut self.matrices, &mut self.previous_frame_matrices);
|
||||
let animation_changed = self.presentation_kind != Some(kind);
|
||||
std::mem::swap(&mut self.local_matrices, &mut self.previous_local_matrices);
|
||||
self.local_matrices.clear();
|
||||
self.local_matrices.extend_from_slice(local);
|
||||
@@ -183,6 +192,14 @@ impl FighterBoneMatrices {
|
||||
model_scale.mul(matrix.expect("baked bone hierarchy should be valid"))
|
||||
}),
|
||||
);
|
||||
// A state transition is a discontinuity, not an animation frame to
|
||||
// interpolate from the previous clip. Keep the presentation pose at
|
||||
// the new clip's first/current frame immediately.
|
||||
if animation_changed {
|
||||
self.previous_local_matrices
|
||||
.clone_from(&self.local_matrices);
|
||||
}
|
||||
self.presentation_kind = Some(kind);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -212,6 +229,7 @@ pub fn update_fighter_bone_matrices(
|
||||
.get(&fighter.manifest)
|
||||
.expect("fighter manifest should be loaded before the match starts");
|
||||
matrices.set_pose(
|
||||
frame.kind,
|
||||
&baked.bone_names,
|
||||
&baked.parents,
|
||||
pose,
|
||||
|
||||
+18
-4
@@ -27,6 +27,7 @@ use crate::game_settings::GameSettings;
|
||||
use crate::input::FighterInput;
|
||||
use crate::math::int::FGi32;
|
||||
use crate::math::vec::FGVec2;
|
||||
use crate::math::vec3::FGVec3;
|
||||
use crate::player::Player;
|
||||
|
||||
pub fn debug_draw_ecb(
|
||||
@@ -39,6 +40,12 @@ pub fn debug_draw_ecb(
|
||||
mut gizmos: Gizmos,
|
||||
) {
|
||||
for (ecb, trf, ecb_prev, trf_prev) in ecbs {
|
||||
gizmos.cross(
|
||||
FGVec3::new(trf.0.x, trf.0.y, FGi32::ZERO).to_vec3(),
|
||||
2.0,
|
||||
bevy::color::palettes::css::BLUE,
|
||||
);
|
||||
|
||||
let transformed =
|
||||
ecb.to_3d_lineloop(Transform::from_xyz(trf.x.to_num(), trf.y.to_num(), 0.0));
|
||||
gizmos.lineloop(transformed, YELLOW);
|
||||
@@ -153,10 +160,17 @@ pub fn fighter_debug(
|
||||
Ok(())
|
||||
}
|
||||
|
||||
pub fn animation_debug(query: Query<(&GlobalTransform, &FighterBoneMatrices)>, mut gizmos: Gizmos) {
|
||||
for (global_transform, matrices) in query {
|
||||
let (_, rotation, translation) = global_transform.to_scale_rotation_translation();
|
||||
let marker_transform = Transform::from_translation(translation).with_rotation(rotation);
|
||||
pub fn animation_debug(
|
||||
query: Query<(
|
||||
&FighterTranslation,
|
||||
&FighterFacingDirection,
|
||||
&FighterBoneMatrices,
|
||||
)>,
|
||||
mut gizmos: Gizmos,
|
||||
) {
|
||||
for (global_transform, facing_dir, matrices) in query {
|
||||
let global_transform = global_transform.get_3d_transform(facing_dir);
|
||||
let marker_transform = global_transform.to_mat4();
|
||||
for (_, matrix) in matrices.iter() {
|
||||
let pos = marker_transform.transform_point(Vec3::new(
|
||||
matrix.cols[3][0].to_num(),
|
||||
|
||||
+99
-48
@@ -1,28 +1,44 @@
|
||||
use bevy::prelude::*;
|
||||
|
||||
use crate::math::{int::FGi32, vec::FGVec2};
|
||||
use crate::{
|
||||
fighter::{
|
||||
FighterFacingDirection, FighterSurfaceState, FighterTranslation,
|
||||
baked_animation::FighterBoneMatrices,
|
||||
}, math::{int::FGi32, vec::FGVec2},
|
||||
};
|
||||
|
||||
/// Environment collision box: the diamond used to resolve a fighter against
|
||||
/// the stage. Purely geometry — the collision response lives in
|
||||
/// [`super::collision`].
|
||||
#[derive(Component, Debug, Clone, Copy, Hash)]
|
||||
#[derive(Component, Debug, Clone, Copy, Hash, Default)]
|
||||
#[require(FighterPreviousECB)]
|
||||
pub struct FighterECB {
|
||||
pub vertical_half: FGi32,
|
||||
pub horizontal_half: FGi32,
|
||||
pub top: FGVec2,
|
||||
pub bottom: FGVec2,
|
||||
pub left: FGVec2,
|
||||
pub right: FGVec2,
|
||||
}
|
||||
|
||||
#[derive(Component, Debug, Clone)]
|
||||
pub struct FighterECBBoneIndices {
|
||||
pub indices: Vec<usize>,
|
||||
}
|
||||
|
||||
#[derive(Component, Debug, Clone, Copy, Default, Hash)]
|
||||
pub struct FighterPreviousECB {
|
||||
pub vertical_half: FGi32,
|
||||
pub horizontal_half: FGi32,
|
||||
pub top: FGVec2,
|
||||
pub bottom: FGVec2,
|
||||
pub left: FGVec2,
|
||||
pub right: FGVec2,
|
||||
}
|
||||
|
||||
impl From<FighterECB> for FighterPreviousECB {
|
||||
fn from(ecb: FighterECB) -> Self {
|
||||
Self {
|
||||
vertical_half: ecb.vertical_half,
|
||||
horizontal_half: ecb.horizontal_half,
|
||||
top: ecb.top,
|
||||
bottom: ecb.bottom,
|
||||
left: ecb.left,
|
||||
right: ecb.right,
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -35,53 +51,84 @@ pub fn snapshot_fighter_ecb(fighters: Query<(&FighterECB, &mut FighterPreviousEC
|
||||
|
||||
impl FighterECB {
|
||||
pub fn to_3d_lineloop(&self, trf: Transform) -> [Vec3; 4] {
|
||||
let rel_up = trf.transform_point(Vec3::new(
|
||||
0.0,
|
||||
(self.vertical_half + self.vertical_half).to_num(),
|
||||
0.0,
|
||||
));
|
||||
let rel_down = trf.transform_point(Vec3::new(0.0, 0.0, 0.0));
|
||||
let rel_left = trf.transform_point(Vec3::new(
|
||||
(-self.horizontal_half).to_num(),
|
||||
self.vertical_half.to_num(),
|
||||
0.0,
|
||||
));
|
||||
let rel_right = trf.transform_point(Vec3::new(
|
||||
self.horizontal_half.to_num(),
|
||||
self.vertical_half.to_num(),
|
||||
0.0,
|
||||
));
|
||||
[rel_up, rel_right, rel_down, rel_left]
|
||||
[self.top, self.right, self.bottom, self.left]
|
||||
.map(|point| trf.transform_point(Vec3::new(point.x.to_num(), point.y.to_num(), 0.0)))
|
||||
}
|
||||
|
||||
pub fn get_bottom_point(&self) -> FGVec2 {
|
||||
FGVec2::new(FGi32::ZERO, FGi32::ZERO)
|
||||
self.bottom
|
||||
}
|
||||
}
|
||||
|
||||
impl FighterPreviousECB {
|
||||
pub fn to_3d_lineloop(&self, trf: Transform) -> [Vec3; 4] {
|
||||
let rel_up = trf.transform_point(Vec3::new(
|
||||
0.0,
|
||||
(self.vertical_half + self.vertical_half).to_num(),
|
||||
0.0,
|
||||
));
|
||||
let rel_down = trf.transform_point(Vec3::new(0.0, 0.0, 0.0));
|
||||
let rel_left = trf.transform_point(Vec3::new(
|
||||
(-self.horizontal_half).to_num(),
|
||||
self.vertical_half.to_num(),
|
||||
0.0,
|
||||
));
|
||||
let rel_right = trf.transform_point(Vec3::new(
|
||||
self.horizontal_half.to_num(),
|
||||
self.vertical_half.to_num(),
|
||||
0.0,
|
||||
));
|
||||
[rel_up, rel_right, rel_down, rel_left]
|
||||
[self.top, self.right, self.bottom, self.left]
|
||||
.map(|point| trf.transform_point(Vec3::new(point.x.to_num(), point.y.to_num(), 0.0)))
|
||||
}
|
||||
|
||||
pub fn get_bottom_point(&self) -> FGVec2 {
|
||||
FGVec2::new(FGi32::ZERO, FGi32::ZERO)
|
||||
self.bottom
|
||||
}
|
||||
}
|
||||
|
||||
pub fn update_ecb(
|
||||
query: Query<(
|
||||
&mut FighterECB,
|
||||
&FighterSurfaceState,
|
||||
&FighterECBBoneIndices,
|
||||
&FighterBoneMatrices,
|
||||
&FighterTranslation,
|
||||
&FighterFacingDirection,
|
||||
)>,
|
||||
) {
|
||||
for (mut ecb, surface_state, bone_indices, bone_matrices, translation, facing_dir) in query {
|
||||
let trf = translation.get_3d_transform(facing_dir);
|
||||
|
||||
let transformed_ecb_bones = bone_indices.indices.iter().filter_map(|idx| {
|
||||
let Some((_, bone_matrix)) = bone_matrices.get_by_idx(*idx) else {
|
||||
return None;
|
||||
};
|
||||
|
||||
let pt = trf.transform_point(bone_matrix.get_translation());
|
||||
|
||||
Some(FGVec2::new(pt.x, pt.y) - translation.0)
|
||||
}).collect::<Vec<_>>();
|
||||
|
||||
let max_x = transformed_ecb_bones.iter().max_by(|a, b| a.x.cmp(&b.x)).map(|final_val| final_val.x).unwrap_or(FGi32::lit("0.5"));
|
||||
let min_x = transformed_ecb_bones.iter().min_by(|a, b| a.x.cmp(&b.x)).map(|final_val| final_val.x).unwrap_or(FGi32::lit("-0.5"));
|
||||
let max_y = transformed_ecb_bones.iter().max_by(|a, b| a.y.cmp(&b.y)).map(|final_val| final_val.y).unwrap_or(FGi32::lit("0.5"));
|
||||
let min_y = transformed_ecb_bones.iter().min_by(|a, b| a.y.cmp(&b.y)).map(|final_val| final_val.y).unwrap_or(FGi32::lit("-0.5"));
|
||||
|
||||
let midpoint_height = (max_y + min_y) / FGi32::lit("2.0");
|
||||
let top = FGVec2::new(FGi32::ZERO, max_y);
|
||||
let bottom = FGVec2::new(FGi32::ZERO, min_y);
|
||||
let left = FGVec2::new(min_x, midpoint_height);
|
||||
let right = FGVec2::new(max_x, midpoint_height);
|
||||
|
||||
let ecb_lock_frames_remaining = if let FighterSurfaceState::Airborne { ecb_lock_frames_remaining } = *surface_state {
|
||||
ecb_lock_frames_remaining
|
||||
} else {
|
||||
0
|
||||
};
|
||||
|
||||
ecb.top = top;
|
||||
|
||||
if ecb_lock_frames_remaining == 0 {
|
||||
ecb.bottom = bottom;
|
||||
}
|
||||
|
||||
ecb.left = left;
|
||||
ecb.right = right;
|
||||
|
||||
if surface_state.is_grounded() {
|
||||
ecb.bottom = FGVec2::ZERO;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
pub fn decrement_ecb_lockout(surface_states: Query<&mut FighterSurfaceState>) {
|
||||
for mut state in surface_states {
|
||||
state.tick_ecb_lock();
|
||||
}
|
||||
}
|
||||
|
||||
@@ -92,12 +139,16 @@ mod tests {
|
||||
#[test]
|
||||
fn previous_ecb_copies_current_dimensions() {
|
||||
let current = FighterECB {
|
||||
vertical_half: FGi32::lit("0.5"),
|
||||
horizontal_half: FGi32::lit("0.25"),
|
||||
bottom: FGVec2::lit("0.0", "-0.5"),
|
||||
top: FGVec2::lit("0.0", "0.5"),
|
||||
left: FGVec2::lit("-0.5", "0.0"),
|
||||
right: FGVec2::lit("0.5", "0.0"),
|
||||
};
|
||||
let previous = FighterPreviousECB::from(current);
|
||||
|
||||
assert_eq!(previous.vertical_half, current.vertical_half);
|
||||
assert_eq!(previous.horizontal_half, current.horizontal_half);
|
||||
assert_eq!(previous.top, current.top);
|
||||
assert_eq!(previous.bottom, current.bottom);
|
||||
assert_eq!(previous.left, current.left);
|
||||
assert_eq!(previous.right, current.right);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -65,6 +65,7 @@ pub struct FighterManifest {
|
||||
pub animations: HashMap<AnimKind, String>,
|
||||
pub attack_scripts: HashMap<AttackKind, String>,
|
||||
pub hurtboxes: Vec<FighterHurtbox>,
|
||||
pub ecb_bones: Vec<String>,
|
||||
}
|
||||
|
||||
#[derive(Resource)]
|
||||
|
||||
+16
-21
@@ -34,24 +34,13 @@ pub use motion::{
|
||||
pub use surface::FighterSurfaceState;
|
||||
|
||||
use crate::{
|
||||
AppState,
|
||||
fighter::{
|
||||
AppState, fighter::{
|
||||
attack::{
|
||||
AttackKind, FighterAttackPlugin, FighterAttackScriptAssets, FighterDamage,
|
||||
FighterKnockbackVelocity, FighterPendingHitReaction, FighterSolvedHurtboxes,
|
||||
FighterStaleMoveQueue,
|
||||
},
|
||||
baked_animation::{FighterBoneIndexMap, FighterBoneMatrices},
|
||||
manifest::FighterManifest,
|
||||
state::{FighterState, air::AirborneStateCommon, fall::FallState},
|
||||
visual::FighterAnimations,
|
||||
},
|
||||
input::FighterInput,
|
||||
math::{int::FGi32, vec::FGVec2},
|
||||
player::Player,
|
||||
schedule::GameplaySet,
|
||||
scripting::FighterAttackScript,
|
||||
stage::line::StageCollision,
|
||||
}, baked_animation::{FighterBoneIndexMap, FighterBoneMatrices}, ecb::FighterECBBoneIndices, manifest::FighterManifest, state::{FighterState, air::AirborneStateCommon, fall::FallState}, visual::FighterAnimations,
|
||||
}, input::FighterInput, math::{int::FGi32, vec::FGVec2}, player::Player, schedule::GameplaySet, scripting::FighterAttackScript, stage::line::StageCollision,
|
||||
};
|
||||
use state::state_interrupt_system;
|
||||
|
||||
@@ -182,10 +171,15 @@ impl Plugin for FighterPlugin {
|
||||
)*/
|
||||
.add_systems(
|
||||
GgrsSchedule,
|
||||
state::state_collision_interrupt_system.in_set(GameplaySet::Collision),
|
||||
(
|
||||
(ecb::update_ecb, ecb::decrement_ecb_lockout, state::state_collision_interrupt_system).chain(),
|
||||
baked_animation::update_fighter_bone_matrices,
|
||||
)
|
||||
.chain()
|
||||
.in_set(GameplaySet::Collision),
|
||||
)
|
||||
.add_systems(
|
||||
Update,
|
||||
PostUpdate,
|
||||
(
|
||||
motion::apply_fighter_translation_to_visuals,
|
||||
animation::apply_animation,
|
||||
@@ -286,6 +280,7 @@ pub fn spawn_fighter(
|
||||
animations: FighterAnimations,
|
||||
attack_scripts: FighterAttackScriptAssets,
|
||||
visual_root: WorldAssetRoot,
|
||||
ecb_bone_indices: Vec<usize>,
|
||||
) -> Entity {
|
||||
commands
|
||||
.spawn((
|
||||
@@ -296,14 +291,14 @@ pub fn spawn_fighter(
|
||||
Fighter { manifest: manifest },
|
||||
FighterFacingDirection::Right,
|
||||
FighterPreviousFacingDirection(FighterFacingDirection::Right),
|
||||
FighterSurfaceState::Airborne,
|
||||
FighterSurfaceState::default(),
|
||||
Transform::from_scale(Vec3::splat(model_scale.to_num())),
|
||||
(
|
||||
FighterECB {
|
||||
vertical_half: FGi32::lit("5.0"),
|
||||
horizontal_half: FGi32::lit("2.5"),
|
||||
},
|
||||
FighterECB::default(),
|
||||
FighterHitboxes::default(),
|
||||
FighterECBBoneIndices {
|
||||
indices: ecb_bone_indices
|
||||
}
|
||||
),
|
||||
(
|
||||
FighterVelocity::default(),
|
||||
|
||||
@@ -8,7 +8,7 @@ use crate::debug_tools::PresentationMotionMode;
|
||||
use crate::fighter::FighterHitstopShake;
|
||||
use crate::game_settings::GameSettings;
|
||||
use crate::{
|
||||
fighter::{FighterECB, FighterFacingDirection, baked_animation::FixedMat4},
|
||||
fighter::{FighterFacingDirection, baked_animation::FixedMat4},
|
||||
math::{int::FGi32, vec::FGVec2, vec3::FGVec3},
|
||||
};
|
||||
|
||||
@@ -56,7 +56,6 @@ pub fn apply_fighter_translation_to_visuals(
|
||||
query: Query<(
|
||||
&FighterTranslation,
|
||||
&FighterPreviousTranslation,
|
||||
&FighterECB,
|
||||
&FighterHitstopShake,
|
||||
&mut Transform,
|
||||
)>,
|
||||
@@ -65,17 +64,16 @@ pub fn apply_fighter_translation_to_visuals(
|
||||
game_settings: Res<GameSettings>,
|
||||
) {
|
||||
let overstep_fraction = timing.overstep_fraction();
|
||||
for (translation, previous_translation, ecb, hitstop_shake, mut transform) in query {
|
||||
for (translation, previous_translation, hitstop_shake, mut transform) in query {
|
||||
let translation = sample_presentation_translation(
|
||||
*previous_translation,
|
||||
*translation,
|
||||
overstep_fraction,
|
||||
debug_settings.motion_sampling,
|
||||
);
|
||||
let bottom = ecb.get_bottom_point();
|
||||
transform.translation = Vec3::new(
|
||||
translation.x + bottom.x.to_num::<f32>(),
|
||||
translation.y + bottom.y.to_num::<f32>(),
|
||||
translation.x,
|
||||
translation.y,
|
||||
0.0,
|
||||
);
|
||||
|
||||
|
||||
@@ -83,9 +83,7 @@ pub fn apply_air_motion(
|
||||
velocity: &FighterVelocity,
|
||||
translation: &mut FighterTranslation,
|
||||
prev_translation: &mut FighterPreviousTranslation,
|
||||
surface: &mut FighterSurfaceState,
|
||||
) {
|
||||
surface.leave_ground();
|
||||
// Vertical velocity should be 0 on the ground
|
||||
prev_translation.0 = translation.0;
|
||||
translation.0 += velocity.0;
|
||||
@@ -111,7 +109,6 @@ pub fn update_standard_motion(
|
||||
ctx.velocity,
|
||||
ctx.translation,
|
||||
ctx.prev_translation,
|
||||
ctx.surface,
|
||||
);
|
||||
}
|
||||
|
||||
@@ -120,7 +117,12 @@ pub fn collision_interrupt(
|
||||
landing_type: LandingType,
|
||||
) -> Option<FighterState> {
|
||||
let res = ctx.air_collide_with_stage()?;
|
||||
ctx.translation.0 = res.hit_position - ctx.ecb.get_bottom_point();
|
||||
let diff = res.hit_position - ctx.translation.0;
|
||||
ctx.ecb.bottom -= diff;
|
||||
ctx.ecb.top -= diff;
|
||||
ctx.ecb.left -= diff;
|
||||
ctx.ecb.right -= diff;
|
||||
ctx.translation.0 = res.hit_position;
|
||||
ctx.surface.land(res.line_id);
|
||||
Some(FighterState::Land(LandingState::create(landing_type)))
|
||||
}
|
||||
|
||||
@@ -38,7 +38,6 @@ impl FighterStateImpl for AirDodgeState {
|
||||
state_context.velocity,
|
||||
state_context.translation,
|
||||
state_context.prev_translation,
|
||||
state_context.surface,
|
||||
);
|
||||
}
|
||||
|
||||
@@ -59,6 +58,10 @@ impl FighterStateImpl for AirDodgeState {
|
||||
fn is_visually_grounded<'a>(&'a self) -> bool {
|
||||
false
|
||||
}
|
||||
|
||||
fn surface_policy(&self) -> super::SurfacePolicy {
|
||||
super::SurfacePolicy::Airborne(crate::fighter::surface::EcbLockPolicy::StartOnDetach)
|
||||
}
|
||||
}
|
||||
|
||||
pub fn check_input(state_context: &InterruptContext) -> Option<FighterState> {
|
||||
|
||||
@@ -0,0 +1,126 @@
|
||||
use super::{
|
||||
CollisionContext, EnterContext, FighterStateImpl, InterruptContext, UpdateContext, ground,
|
||||
};
|
||||
use crate::fighter::animation::AnimKind;
|
||||
use crate::fighter::state::{FighterState, dash, ground_attack, turn, walk};
|
||||
use crate::fighter::state::ground::{grounded_movement_common_interrupts, grounded_movement_standstill_common_interrupts};
|
||||
|
||||
#[derive(Debug, Clone, Hash)]
|
||||
pub enum CrouchSubState {
|
||||
Entering,
|
||||
Idle,
|
||||
Exiting
|
||||
}
|
||||
|
||||
#[derive(Debug, Clone, Hash)]
|
||||
pub struct CrouchState {
|
||||
sub_state: CrouchSubState
|
||||
}
|
||||
|
||||
pub fn crouch_idle_interrupts(
|
||||
state_context: &InterruptContext,
|
||||
) -> Option<FighterState> {
|
||||
if let Some(state) = ground_attack::check_interrupt(state_context) {
|
||||
Some(state)
|
||||
} else if let Some(state) = dash::check_input(state_context) {
|
||||
Some(state)
|
||||
} else if let Some(state) = turn::check_input(state_context) {
|
||||
Some(state)
|
||||
} else if let Some(state) = walk::check_input(state_context) {
|
||||
Some(state)
|
||||
} else {
|
||||
None
|
||||
}
|
||||
}
|
||||
|
||||
pub fn crouch_entering_interrupts(
|
||||
state_context: &InterruptContext,
|
||||
) -> Option<FighterState> {
|
||||
if let Some(state) = ground_attack::check_interrupt(state_context) {
|
||||
Some(state)
|
||||
} else {
|
||||
None
|
||||
}
|
||||
}
|
||||
|
||||
impl FighterStateImpl for CrouchState {
|
||||
const NAME: &'static str = "Crouch";
|
||||
fn check_interrupt(&self, state_context: &mut InterruptContext) -> Option<FighterState> {
|
||||
if let Some(state) = grounded_movement_common_interrupts(state_context) {
|
||||
return Some(state);
|
||||
}
|
||||
|
||||
match self.sub_state {
|
||||
CrouchSubState::Entering => {
|
||||
// While entering the crouch animation we do not allow movement inputs, but we do allow attacks and jumps
|
||||
if state_context.is_current_animation_finished() {
|
||||
return Some(FighterState::Crouch(
|
||||
CrouchState {
|
||||
sub_state: CrouchSubState::Idle,
|
||||
}
|
||||
));
|
||||
} else {
|
||||
return crouch_entering_interrupts(state_context);
|
||||
}
|
||||
},
|
||||
CrouchSubState::Idle => {
|
||||
if state_context.input.get_last_frame().movement.y > -state_context.game_settings.input_common.run_stick_threshold {
|
||||
return Some(FighterState::Crouch (
|
||||
CrouchState {
|
||||
sub_state: CrouchSubState::Exiting,
|
||||
}
|
||||
));
|
||||
} else {
|
||||
return crouch_idle_interrupts(state_context);
|
||||
}
|
||||
},
|
||||
CrouchSubState::Exiting => {
|
||||
if state_context.is_current_animation_finished() {
|
||||
return grounded_movement_standstill_common_interrupts(state_context);
|
||||
} else {
|
||||
return crouch_idle_interrupts(state_context);
|
||||
}
|
||||
},
|
||||
}
|
||||
}
|
||||
|
||||
fn on_enter(&mut self, state_context: &mut EnterContext) {
|
||||
match self.sub_state {
|
||||
CrouchSubState::Entering => {
|
||||
state_context.play_animation(AnimKind::CrouchEnter, false);
|
||||
},
|
||||
CrouchSubState::Idle => {
|
||||
state_context.play_animation(AnimKind::CrouchIdle, true);
|
||||
},
|
||||
CrouchSubState::Exiting => {
|
||||
state_context.play_animation(AnimKind::CrouchExit, false);
|
||||
},
|
||||
}
|
||||
}
|
||||
|
||||
fn update(&mut self, state_context: &mut UpdateContext) {
|
||||
ground::update_friction_motion(state_context);
|
||||
}
|
||||
|
||||
fn check_collision_interrupt(
|
||||
&mut self,
|
||||
state_context: &mut CollisionContext,
|
||||
) -> Option<FighterState> {
|
||||
ground::collision_interrupt(state_context, false)
|
||||
}
|
||||
|
||||
fn is_visually_grounded<'a>(&'a self) -> bool {
|
||||
true
|
||||
}
|
||||
}
|
||||
|
||||
pub fn check_input(state_context: &InterruptContext) -> Option<FighterState> {
|
||||
let input_frame = state_context.input.get_last_frame();
|
||||
|
||||
if input_frame.movement.y <= -state_context.game_settings.input_common.run_stick_threshold {
|
||||
return Some(FighterState::Crouch(CrouchState {
|
||||
sub_state: CrouchSubState::Entering
|
||||
}));
|
||||
}
|
||||
None
|
||||
}
|
||||
@@ -46,5 +46,8 @@ impl FighterStateImpl for FallState {
|
||||
) -> bool {
|
||||
false
|
||||
}
|
||||
}
|
||||
|
||||
fn surface_policy(&self) -> super::SurfacePolicy {
|
||||
super::SurfacePolicy::Airborne(crate::fighter::surface::EcbLockPolicy::StartOnDetach)
|
||||
}
|
||||
}
|
||||
|
||||
+27
-14
@@ -3,8 +3,7 @@
|
||||
//! bit-for-bit deterministic for rollback.
|
||||
|
||||
use crate::fighter::state::{
|
||||
CollisionContext, FighterState, InterruptContext, air, dash, fall, ground_attack, turn, wait,
|
||||
walk,
|
||||
CollisionContext, FighterState, InterruptContext, air, crouch, dash, fall, ground_attack, turn, wait, walk,
|
||||
};
|
||||
use crate::fighter::{
|
||||
FighterAttributes, FighterPreviousTranslation, FighterTranslation, FighterVelocity,
|
||||
@@ -178,7 +177,7 @@ pub fn collide_with_stage_grounded(
|
||||
can_walk_off: bool,
|
||||
) -> GroundedMotionResult {
|
||||
let translation = &mut state_context.translation;
|
||||
let ecb = state_context.ecb;
|
||||
let ecb = &state_context.ecb;
|
||||
let stage_collision = state_context.stage_collision;
|
||||
|
||||
let Some(current_line_id) = state_context.surface.line_id() else {
|
||||
@@ -218,12 +217,18 @@ pub fn collide_with_stage_grounded(
|
||||
GroundedMotionResult::InGround
|
||||
}
|
||||
GroundedPositionResult::InAir => {
|
||||
state_context.surface.leave_ground();
|
||||
state_context.surface.apply_airborne_policy(
|
||||
crate::fighter::surface::EcbLockPolicy::StartOnDetach,
|
||||
state_context.leave_ground_ecb_lock_duration,
|
||||
);
|
||||
GroundedMotionResult::InAir
|
||||
}
|
||||
}
|
||||
} else {
|
||||
state_context.surface.leave_ground();
|
||||
state_context.surface.apply_airborne_policy(
|
||||
crate::fighter::surface::EcbLockPolicy::StartOnDetach,
|
||||
state_context.leave_ground_ecb_lock_duration,
|
||||
);
|
||||
GroundedMotionResult::InAir
|
||||
}
|
||||
}
|
||||
@@ -363,9 +368,11 @@ mod tests {
|
||||
let mut translation = FighterTranslation(FGVec2::lit("11", "0"));
|
||||
let previous_translation = FighterPreviousTranslation(translation.0);
|
||||
let mut velocity = FighterVelocity::default();
|
||||
let ecb = FighterECB {
|
||||
vertical_half: FGi32::ONE,
|
||||
horizontal_half: FGi32::ONE,
|
||||
let mut ecb = FighterECB {
|
||||
bottom: FGVec2::lit("0.0", "-0.5"),
|
||||
top: FGVec2::lit("0.0", "0.5"),
|
||||
left: FGVec2::lit("-0.5", "0.0"),
|
||||
right: FGVec2::lit("0.5", "0.0"),
|
||||
};
|
||||
let previous_ecb = FighterPreviousECB::from(ecb);
|
||||
let mut context = CollisionContext {
|
||||
@@ -373,9 +380,10 @@ mod tests {
|
||||
prev_translation: &previous_translation,
|
||||
velocity: &mut velocity,
|
||||
surface: &mut surface,
|
||||
ecb: &ecb,
|
||||
ecb: &mut ecb,
|
||||
prev_ecb: &previous_ecb,
|
||||
stage_collision: &stage_collision,
|
||||
leave_ground_ecb_lock_duration: 10,
|
||||
};
|
||||
|
||||
assert!(matches!(
|
||||
@@ -411,9 +419,11 @@ mod tests {
|
||||
let mut translation = FighterTranslation(FGVec2::lit("11", "0"));
|
||||
let previous_translation = FighterPreviousTranslation(translation.0);
|
||||
let mut velocity = FighterVelocity::default();
|
||||
let ecb = FighterECB {
|
||||
vertical_half: FGi32::ONE,
|
||||
horizontal_half: FGi32::ONE,
|
||||
let mut ecb = FighterECB {
|
||||
bottom: FGVec2::lit("0.0", "-0.5"),
|
||||
top: FGVec2::lit("0.0", "0.5"),
|
||||
left: FGVec2::lit("-0.5", "0.0"),
|
||||
right: FGVec2::lit("0.5", "0.0"),
|
||||
};
|
||||
let previous_ecb = FighterPreviousECB::from(ecb);
|
||||
let mut context = CollisionContext {
|
||||
@@ -421,16 +431,17 @@ mod tests {
|
||||
prev_translation: &previous_translation,
|
||||
velocity: &mut velocity,
|
||||
surface: &mut surface,
|
||||
ecb: &ecb,
|
||||
ecb: &mut ecb,
|
||||
prev_ecb: &previous_ecb,
|
||||
stage_collision: &stage_collision,
|
||||
leave_ground_ecb_lock_duration: 10,
|
||||
};
|
||||
|
||||
assert!(matches!(
|
||||
collide_with_stage_grounded(&mut context, true),
|
||||
GroundedMotionResult::InAir
|
||||
));
|
||||
assert_eq!(surface, FighterSurfaceState::Airborne);
|
||||
assert!(matches!(surface, FighterSurfaceState::Airborne { .. }));
|
||||
}
|
||||
}
|
||||
|
||||
@@ -449,6 +460,8 @@ pub fn grounded_movement_standstill_common_interrupts(
|
||||
Some(state)
|
||||
} else if let Some(state) = turn::check_input(state_context) {
|
||||
Some(state)
|
||||
} else if let Some(state) = crouch::check_input(state_context) {
|
||||
Some(state)
|
||||
} else if let Some(state) = walk::check_input(state_context) {
|
||||
Some(state)
|
||||
} else if let Some(state) = wait::check_input(state_context) {
|
||||
|
||||
@@ -83,7 +83,6 @@ impl FighterStateImpl for HitstunState {
|
||||
match self.hitstop_kind {
|
||||
HitstopStateKind::Grounded => {}
|
||||
HitstopStateKind::Airborne => {
|
||||
ctx.surface.leave_ground();
|
||||
air::integrate_gravity(ctx.velocity, ctx.fighter_attributes, false);
|
||||
}
|
||||
}
|
||||
@@ -126,4 +125,13 @@ impl FighterStateImpl for HitstunState {
|
||||
HitstopStateKind::Airborne => false,
|
||||
}
|
||||
}
|
||||
|
||||
fn surface_policy(&self) -> super::SurfacePolicy {
|
||||
match self.hitstop_kind {
|
||||
HitstopStateKind::Grounded => super::SurfacePolicy::Grounded,
|
||||
HitstopStateKind::Airborne => super::SurfacePolicy::Airborne(
|
||||
crate::fighter::surface::EcbLockPolicy::StartOnDetach,
|
||||
),
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -186,6 +186,16 @@ impl FighterStateImpl for JumpState {
|
||||
fn is_visually_grounded<'a>(&'a self) -> bool {
|
||||
false
|
||||
}
|
||||
|
||||
fn surface_policy(&self) -> super::SurfacePolicy {
|
||||
use crate::fighter::surface::EcbLockPolicy;
|
||||
match self.jump_type {
|
||||
JumpType::DoubleJump => super::SurfacePolicy::Airborne(EcbLockPolicy::Restart),
|
||||
JumpType::ShortHop | JumpType::LongJump => {
|
||||
super::SurfacePolicy::Airborne(EcbLockPolicy::StartOnDetach)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
pub fn check_input(state_context: &InterruptContext) -> Option<FighterState> {
|
||||
|
||||
@@ -21,6 +21,7 @@ use crate::fighter::{
|
||||
FighterHitstopShake, FighterHitstopShakeKind, FighterHitstopShakeRole,
|
||||
FighterPreviousTranslation, FighterSurfaceState, FighterTranslation, FighterVelocity,
|
||||
};
|
||||
use crate::fighter::surface::EcbLockPolicy;
|
||||
use crate::game_settings::GameSettings;
|
||||
use crate::input::FighterInput;
|
||||
use crate::math::int::FGi32;
|
||||
@@ -40,6 +41,13 @@ pub mod run;
|
||||
pub mod turn;
|
||||
pub mod wait;
|
||||
pub mod walk;
|
||||
pub mod crouch;
|
||||
|
||||
#[derive(Clone, Copy, Debug, Hash, PartialEq, Eq)]
|
||||
pub enum SurfacePolicy {
|
||||
Grounded,
|
||||
Airborne(EcbLockPolicy),
|
||||
}
|
||||
|
||||
macro_rules! fighter_states {
|
||||
($($variant:ident => $ty:ty),* $(,)?) => {
|
||||
@@ -72,6 +80,10 @@ macro_rules! fighter_states {
|
||||
pub fn is_visually_grounded(&self) -> bool {
|
||||
match self { $(Self::$variant(s) => s.is_visually_grounded()),* }
|
||||
}
|
||||
|
||||
pub fn surface_policy(&self) -> SurfacePolicy {
|
||||
match self { $(Self::$variant(s) => s.surface_policy()),* }
|
||||
}
|
||||
}
|
||||
|
||||
$(impl From<$ty> for FighterState {
|
||||
@@ -99,6 +111,10 @@ pub trait FighterStateImpl: Sized {
|
||||
}
|
||||
|
||||
fn is_visually_grounded<'a>(&'a self) -> bool;
|
||||
|
||||
fn surface_policy(&self) -> SurfacePolicy {
|
||||
SurfacePolicy::Grounded
|
||||
}
|
||||
}
|
||||
|
||||
pub struct AnimationStatus {
|
||||
@@ -173,9 +189,10 @@ pub struct CollisionContext<'a> {
|
||||
pub prev_translation: &'a FighterPreviousTranslation,
|
||||
pub velocity: &'a mut FighterVelocity,
|
||||
pub surface: &'a mut FighterSurfaceState,
|
||||
pub ecb: &'a FighterECB,
|
||||
pub ecb: &'a mut FighterECB,
|
||||
pub prev_ecb: &'a FighterPreviousECB,
|
||||
pub stage_collision: &'a StageCollision,
|
||||
pub leave_ground_ecb_lock_duration: u32,
|
||||
}
|
||||
|
||||
impl CollisionContext<'_> {
|
||||
@@ -195,6 +212,7 @@ impl CollisionContext<'_> {
|
||||
fighter_states! {
|
||||
Wait => wait::WaitState,
|
||||
Walk => walk::WalkState,
|
||||
Crouch => crouch::CrouchState,
|
||||
Dash => dash::DashState,
|
||||
Run => run::RunState,
|
||||
Fall => fall::FallState,
|
||||
@@ -218,7 +236,7 @@ pub struct FighterFrameQuery {
|
||||
pub surface: &'static mut FighterSurfaceState,
|
||||
pub knockback_velocity: &'static mut FighterKnockbackVelocity,
|
||||
pub stale_move_queue: &'static mut FighterStaleMoveQueue,
|
||||
pub ecb: &'static FighterECB,
|
||||
pub ecb: &'static mut FighterECB,
|
||||
pub prev_ecb: &'static FighterPreviousECB,
|
||||
pub facing_direction: &'static mut FighterFacingDirection,
|
||||
pub animation_frame: &'static mut FighterAnimationFrame,
|
||||
@@ -310,15 +328,17 @@ impl<'w, 's> FighterFrameQueryItem<'w, 's> {
|
||||
fn collision_context<'a>(
|
||||
&'a mut self,
|
||||
stage_collision: &'a StageCollision,
|
||||
game_settings: &'a GameSettings,
|
||||
) -> CollisionContext<'a> {
|
||||
CollisionContext {
|
||||
translation: &mut self.translation,
|
||||
prev_translation: &self.prev_translation,
|
||||
velocity: &mut self.velocity,
|
||||
surface: &mut self.surface,
|
||||
ecb: &self.ecb,
|
||||
ecb: &mut self.ecb,
|
||||
prev_ecb: &self.prev_ecb,
|
||||
stage_collision,
|
||||
leave_ground_ecb_lock_duration: game_settings.fighter_common.leave_ground_ecb_frame_lock_duration
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -373,11 +393,18 @@ fn transition_state(
|
||||
frame: &mut FighterFrameQueryItem,
|
||||
attributes: &FighterAttributes,
|
||||
attack_script_assets: &FighterAttackScriptAssets,
|
||||
game_settings: &GameSettings,
|
||||
) {
|
||||
let old_name = current.name();
|
||||
let new_name = next.name();
|
||||
|
||||
current.on_exit(&mut frame.exit_context());
|
||||
if let SurfacePolicy::Airborne(lock_policy) = next.surface_policy() {
|
||||
frame.surface.apply_airborne_policy(
|
||||
lock_policy,
|
||||
game_settings.fighter_common.leave_ground_ecb_frame_lock_duration,
|
||||
);
|
||||
}
|
||||
next.on_enter(&mut frame.enter_context(attributes, attack_script_assets));
|
||||
*current = next;
|
||||
info!("{} -> {}", old_name, new_name);
|
||||
@@ -448,10 +475,6 @@ pub fn state_interrupt_system(
|
||||
}
|
||||
}
|
||||
|
||||
if matches!(hitstop_kind, hitstun::HitstopStateKind::Airborne) {
|
||||
frame.surface.leave_ground();
|
||||
}
|
||||
|
||||
info!("Entering hitstop kind: {:?}", hitstop_kind);
|
||||
Some(FighterState::Hitstun(HitstunState::new(
|
||||
reaction,
|
||||
@@ -475,6 +498,7 @@ pub fn state_interrupt_system(
|
||||
&mut frame,
|
||||
&manifest.attributes,
|
||||
attack_script_assets,
|
||||
&game_settings,
|
||||
);
|
||||
};
|
||||
}
|
||||
@@ -484,6 +508,7 @@ pub fn state_collision_interrupt_system(
|
||||
mut query: Query<StatefulFighterQuery>,
|
||||
stage_collision: Res<StageCollision>,
|
||||
fighter_manifests: Res<Assets<FighterManifest>>,
|
||||
game_settings: Res<GameSettings>,
|
||||
) {
|
||||
for fighter in &mut query {
|
||||
let StatefulFighterQueryItem {
|
||||
@@ -502,7 +527,7 @@ pub fn state_collision_interrupt_system(
|
||||
.get(&fighter.manifest)
|
||||
.expect("Fighter manifest should be valid");
|
||||
let new_state =
|
||||
state.check_collision_interrupt(&mut frame.collision_context(&stage_collision));
|
||||
state.check_collision_interrupt(&mut frame.collision_context(&stage_collision, &game_settings));
|
||||
if let Some(new_state) = new_state {
|
||||
transition_state(
|
||||
&mut state,
|
||||
@@ -510,6 +535,7 @@ pub fn state_collision_interrupt_system(
|
||||
&mut frame,
|
||||
&manifest.attributes,
|
||||
&attack_script_assets,
|
||||
&game_settings,
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
+76
-8
@@ -1,21 +1,38 @@
|
||||
use bevy::prelude::*;
|
||||
|
||||
use crate::stage::line::StageLineID;
|
||||
use crate::{stage::line::StageLineID};
|
||||
|
||||
#[derive(Clone, Copy, Debug, Hash, PartialEq, Eq)]
|
||||
pub enum EcbLockPolicy {
|
||||
StartOnDetach,
|
||||
Restart,
|
||||
Preserve,
|
||||
Clear,
|
||||
}
|
||||
|
||||
/// The stage surface currently supporting a fighter.
|
||||
///
|
||||
/// This is physics state rather than fighter-state-machine state. Keeping it
|
||||
/// separate means grounded, landing, and hitstun states all share one source
|
||||
/// of truth for stage contact.
|
||||
#[derive(Component, Clone, Copy, Debug, Default, Hash, PartialEq, Eq)]
|
||||
#[derive(Component, Clone, Copy, Debug, Hash, PartialEq, Eq)]
|
||||
pub enum FighterSurfaceState {
|
||||
#[default]
|
||||
Airborne,
|
||||
Airborne {
|
||||
ecb_lock_frames_remaining: u32
|
||||
},
|
||||
Grounded {
|
||||
line_id: StageLineID,
|
||||
},
|
||||
}
|
||||
|
||||
impl Default for FighterSurfaceState {
|
||||
fn default() -> Self {
|
||||
Self::Airborne {
|
||||
ecb_lock_frames_remaining: 0
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
impl FighterSurfaceState {
|
||||
pub fn is_grounded(self) -> bool {
|
||||
matches!(self, Self::Grounded { .. })
|
||||
@@ -23,7 +40,7 @@ impl FighterSurfaceState {
|
||||
|
||||
pub fn line_id(self) -> Option<StageLineID> {
|
||||
match self {
|
||||
Self::Airborne => None,
|
||||
Self::Airborne { .. } => None,
|
||||
Self::Grounded { line_id } => Some(line_id),
|
||||
}
|
||||
}
|
||||
@@ -32,8 +49,29 @@ impl FighterSurfaceState {
|
||||
*self = Self::Grounded { line_id };
|
||||
}
|
||||
|
||||
pub(crate) fn leave_ground(&mut self) {
|
||||
*self = Self::Airborne;
|
||||
pub(crate) fn apply_airborne_policy(
|
||||
&mut self,
|
||||
policy: EcbLockPolicy,
|
||||
ecb_lock_duration: u32,
|
||||
) {
|
||||
let current_lock = match *self {
|
||||
Self::Airborne { ecb_lock_frames_remaining } => ecb_lock_frames_remaining,
|
||||
Self::Grounded { .. } => 0,
|
||||
};
|
||||
let ecb_lock_frames_remaining = match policy {
|
||||
EcbLockPolicy::StartOnDetach if self.is_grounded() => ecb_lock_duration,
|
||||
EcbLockPolicy::StartOnDetach => current_lock,
|
||||
EcbLockPolicy::Restart => ecb_lock_duration,
|
||||
EcbLockPolicy::Preserve => current_lock,
|
||||
EcbLockPolicy::Clear => 0,
|
||||
};
|
||||
*self = Self::Airborne { ecb_lock_frames_remaining };
|
||||
}
|
||||
|
||||
pub(crate) fn tick_ecb_lock(&mut self) {
|
||||
if let Self::Airborne { ecb_lock_frames_remaining } = self {
|
||||
*ecb_lock_frames_remaining = ecb_lock_frames_remaining.saturating_sub(1);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -55,8 +93,38 @@ mod tests {
|
||||
assert!(surface.is_grounded());
|
||||
assert_eq!(surface.line_id(), Some(line_id));
|
||||
|
||||
surface.leave_ground();
|
||||
surface.apply_airborne_policy(EcbLockPolicy::Clear, 0);
|
||||
assert!(!surface.is_grounded());
|
||||
assert_eq!(surface.line_id(), None);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn start_on_detach_does_not_reset_an_existing_lock() {
|
||||
let mut surface = FighterSurfaceState::default();
|
||||
surface.apply_airborne_policy(EcbLockPolicy::Restart, 5);
|
||||
surface.tick_ecb_lock();
|
||||
surface.apply_airborne_policy(EcbLockPolicy::StartOnDetach, 5);
|
||||
|
||||
assert_eq!(
|
||||
surface,
|
||||
FighterSurfaceState::Airborne {
|
||||
ecb_lock_frames_remaining: 4,
|
||||
}
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn restart_retriggers_an_existing_lock() {
|
||||
let mut surface = FighterSurfaceState::default();
|
||||
surface.apply_airborne_policy(EcbLockPolicy::Restart, 5);
|
||||
surface.tick_ecb_lock();
|
||||
surface.apply_airborne_policy(EcbLockPolicy::Restart, 5);
|
||||
|
||||
assert_eq!(
|
||||
surface,
|
||||
FighterSurfaceState::Airborne {
|
||||
ecb_lock_frames_remaining: 5,
|
||||
}
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -39,6 +39,7 @@ pub struct FighterSettingsCommon {
|
||||
|
||||
/// Maximum angle changed caused by directional influence
|
||||
pub di_max_angle: FGi32,
|
||||
pub leave_ground_ecb_frame_lock_duration: u32
|
||||
}
|
||||
#[derive(Reflect, Serialize, Deserialize, Clone)]
|
||||
#[reflect(opaque)]
|
||||
|
||||
+74
-10
@@ -1,6 +1,8 @@
|
||||
use std::panic::{self, AssertUnwindSafe};
|
||||
use std::sync::atomic::{AtomicBool, Ordering};
|
||||
use std::sync::{Arc, Mutex};
|
||||
use std::thread::JoinHandle;
|
||||
use std::time::{Duration, Instant};
|
||||
|
||||
use bevy::prelude::*;
|
||||
use gc_adapter_neo::{Controller, GcAdapter};
|
||||
@@ -55,10 +57,11 @@ impl GcPortState {
|
||||
/// Shared, `Send + Sync` handle to the latest snapshot from the poll
|
||||
/// thread. Safe to store as an ordinary [`Resource`] (no `NonSend` needed)
|
||||
/// because the `GcAdapter` itself never leaves its thread.
|
||||
#[derive(Resource, Clone)]
|
||||
#[derive(Resource)]
|
||||
pub struct GcAdapterSnapshot {
|
||||
ports: Arc<Mutex<[GcPortState; 4]>>,
|
||||
shutdown: Arc<AtomicBool>,
|
||||
poll_thread: Option<JoinHandle<()>>,
|
||||
}
|
||||
|
||||
impl GcAdapterSnapshot {
|
||||
@@ -69,13 +72,37 @@ impl GcAdapterSnapshot {
|
||||
|
||||
impl Drop for GcAdapterSnapshot {
|
||||
fn drop(&mut self) {
|
||||
// Only actually signals shutdown once the last clone (this resource
|
||||
// is never cloned in practice, but be defensive) is dropped.
|
||||
if Arc::strong_count(&self.shutdown) <= 1 {
|
||||
self.shutdown.store(true, Ordering::Relaxed);
|
||||
self.shutdown.store(true, Ordering::Release);
|
||||
|
||||
if let Some(poll_thread) = self.poll_thread.take() {
|
||||
if let Err(payload) = poll_thread.join() {
|
||||
error!(
|
||||
"GameCube Controller Adapter poll thread panicked during shutdown: {payload:?}"
|
||||
);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
const INITIAL_ERROR_BACKOFF: Duration = Duration::from_millis(1);
|
||||
const MAX_ERROR_BACKOFF: Duration = Duration::from_millis(100);
|
||||
|
||||
fn next_error_backoff(backoff: Duration) -> Duration {
|
||||
backoff.saturating_mul(2).min(MAX_ERROR_BACKOFF)
|
||||
}
|
||||
|
||||
/// Wait for a retry while still allowing the owner to shut the poll thread down promptly.
|
||||
fn wait_for_retry(shutdown: &AtomicBool, delay: Duration) -> bool {
|
||||
let deadline = Instant::now() + delay;
|
||||
while !shutdown.load(Ordering::Acquire) {
|
||||
let remaining = deadline.saturating_duration_since(Instant::now());
|
||||
if remaining.is_zero() {
|
||||
return true;
|
||||
}
|
||||
std::thread::sleep(remaining.min(Duration::from_millis(10)));
|
||||
}
|
||||
false
|
||||
}
|
||||
|
||||
/// Connects to the first GameCube adapter found on the USB bus and starts
|
||||
/// polling it on a dedicated thread. Returns `None` (after logging a
|
||||
@@ -94,7 +121,7 @@ pub fn spawn_poll_thread() -> Result<GcAdapterSnapshot, gc_adapter_neo::UsbError
|
||||
|
||||
let thread_ports = ports.clone();
|
||||
let thread_shutdown = shutdown.clone();
|
||||
std::thread::Builder::new()
|
||||
let poll_thread = std::thread::Builder::new()
|
||||
.name("gc-adapter-poll".into())
|
||||
.spawn(move || {
|
||||
// Flush whatever the adapter had buffered before we started
|
||||
@@ -107,17 +134,27 @@ pub fn spawn_poll_thread() -> Result<GcAdapterSnapshot, gc_adapter_neo::UsbError
|
||||
let mut rate_window_start = std::time::Instant::now();
|
||||
#[cfg(debug_assertions)]
|
||||
let mut rate_window_count: u32 = 0;
|
||||
let mut error_backoff = INITIAL_ERROR_BACKOFF;
|
||||
|
||||
while !thread_shutdown.load(Ordering::Relaxed) {
|
||||
while !thread_shutdown.load(Ordering::Acquire) {
|
||||
let result = panic::catch_unwind(AssertUnwindSafe(|| adapter.read_controllers()));
|
||||
|
||||
let controllers = match result {
|
||||
Ok(Ok(controllers)) => controllers,
|
||||
Ok(Ok(controllers)) => {
|
||||
error_backoff = INITIAL_ERROR_BACKOFF;
|
||||
controllers
|
||||
}
|
||||
// Ignore this, for some reason we get a bunch of these when we start reading
|
||||
Ok(Err(
|
||||
gc_adapter_neo::AdapterError::Parse(_)
|
||||
| gc_adapter_neo::AdapterError::ShortRead(_),
|
||||
)) => continue,
|
||||
)) => {
|
||||
if !wait_for_retry(&thread_shutdown, error_backoff) {
|
||||
break;
|
||||
}
|
||||
error_backoff = next_error_backoff(error_backoff);
|
||||
continue;
|
||||
}
|
||||
Ok(Err(gc_adapter_neo::AdapterError::Usb(err))) => {
|
||||
error!(
|
||||
"GameCube Controller Adapter USB read failed ({err:?}); stopping \
|
||||
@@ -160,5 +197,32 @@ pub fn spawn_poll_thread() -> Result<GcAdapterSnapshot, gc_adapter_neo::UsbError
|
||||
})
|
||||
.expect("failed to spawn gc-adapter poll thread");
|
||||
|
||||
Ok(GcAdapterSnapshot { ports, shutdown })
|
||||
Ok(GcAdapterSnapshot {
|
||||
ports,
|
||||
shutdown,
|
||||
poll_thread: Some(poll_thread),
|
||||
})
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
mod tests {
|
||||
use super::*;
|
||||
|
||||
#[test]
|
||||
fn error_backoff_is_capped() {
|
||||
let mut backoff = INITIAL_ERROR_BACKOFF;
|
||||
for _ in 0..16 {
|
||||
backoff = next_error_backoff(backoff);
|
||||
}
|
||||
|
||||
assert_eq!(backoff, MAX_ERROR_BACKOFF);
|
||||
assert_eq!(next_error_backoff(MAX_ERROR_BACKOFF), MAX_ERROR_BACKOFF);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn retry_wait_stops_when_shutdown_is_requested() {
|
||||
let shutdown = AtomicBool::new(true);
|
||||
|
||||
assert!(!wait_for_retry(&shutdown, Duration::from_secs(1)));
|
||||
}
|
||||
}
|
||||
|
||||
+12
-1
@@ -336,6 +336,15 @@ pub fn prepare_match(
|
||||
);
|
||||
return;
|
||||
}
|
||||
|
||||
let ecb_bone_indices = baked.bone_names.iter().enumerate().filter_map(|(idx, name)| {
|
||||
if manifest.ecb_bones.contains(name) {
|
||||
Some(idx)
|
||||
} else {
|
||||
None
|
||||
}
|
||||
}).collect::<Vec<_>>();
|
||||
|
||||
if let Err(error) = manifest.attributes.validate() {
|
||||
fail_match(
|
||||
&mut next_state,
|
||||
@@ -436,6 +445,7 @@ pub fn prepare_match(
|
||||
attack_scripts,
|
||||
manifest_handle,
|
||||
manifest.model_scale,
|
||||
ecb_bone_indices,
|
||||
));
|
||||
}
|
||||
|
||||
@@ -477,7 +487,7 @@ pub fn prepare_match(
|
||||
);
|
||||
|
||||
let mut fighter_roster = Vec::with_capacity(config.players.len());
|
||||
for (index, (player, (scene, animations, attack_scripts, manifest_handle, model_scale))) in
|
||||
for (index, (player, (scene, animations, attack_scripts, manifest_handle, model_scale, ecb_bone_indices))) in
|
||||
config.players.iter().zip(prepared).enumerate()
|
||||
{
|
||||
let spawn_x = (index as i32 * 2 + 1 - config.players.len() as i32) * 5;
|
||||
@@ -490,6 +500,7 @@ pub fn prepare_match(
|
||||
animations,
|
||||
attack_scripts,
|
||||
WorldAssetRoot(scene),
|
||||
ecb_bone_indices
|
||||
));
|
||||
}
|
||||
|
||||
|
||||
+10
-1
@@ -2,7 +2,7 @@ use bevy::math::Vec2;
|
||||
use bevy::prelude::*;
|
||||
use fixed::types::I32F32;
|
||||
use serde::{Deserialize, Serialize};
|
||||
use std::ops::{Add, AddAssign, Div, Mul, MulAssign, Sub};
|
||||
use std::ops::{Add, AddAssign, Div, Mul, MulAssign, Sub, SubAssign};
|
||||
|
||||
use super::int::{FGWide, FGi32};
|
||||
|
||||
@@ -227,6 +227,15 @@ impl AddAssign for FGVec2 {
|
||||
}
|
||||
}
|
||||
|
||||
impl SubAssign for FGVec2 {
|
||||
fn sub_assign(&mut self, rhs: Self) {
|
||||
*self = Self {
|
||||
x: self.x - rhs.x,
|
||||
y: self.y - rhs.y,
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
impl MulAssign for FGVec2 {
|
||||
fn mul_assign(&mut self, rhs: Self) {
|
||||
*self = Self {
|
||||
|
||||
@@ -1,19 +1,8 @@
|
||||
use bevy::{picking::pointer::PointerId, prelude::*};
|
||||
|
||||
use crate::{
|
||||
AppState,
|
||||
fighter::manifest::{FighterManifest, FighterManifestRegistry},
|
||||
game_settings::CommonAssets,
|
||||
input::{LocalInputAssignments, LocalInputSource},
|
||||
menus::{
|
||||
MenuMarker,
|
||||
button::FGUiButton,
|
||||
character_select::{character_box::CharacterBox, token::CharacterSelectToken},
|
||||
cursor::{FGMenuCursor, MenuCursorInputSource},
|
||||
errors::MenuErrors::FighterManifestNotFound,
|
||||
match_config::{MenuMatchConfig, MenuMatchPlayerSlot},
|
||||
scaling, spawn_menu,
|
||||
style::{FGUiButtonType, FGUiStyle},
|
||||
AppState, fighter::manifest::{FighterManifest, FighterManifestRegistry}, game_settings::CommonAssets, input::{LocalInputAssignments, LocalInputSource}, menus::{
|
||||
MenuCameraMarker, MenuMarker, button::FGUiButton, character_select::{character_box::CharacterBox, token::CharacterSelectToken}, cursor::{FGMenuCursor, MenuCursorInputSource}, errors::MenuErrors::FighterManifestNotFound, match_config::{MenuMatchConfig, MenuMatchPlayerSlot}, scaling, spawn_menu, style::{FGUiButtonType, FGUiStyle},
|
||||
},
|
||||
};
|
||||
|
||||
@@ -241,7 +230,7 @@ pub fn copy_cursor_transform_to_token(
|
||||
character_boxes: Query<(&CharacterBox, &ComputedNode, &UiGlobalTransform)>,
|
||||
match_config: Res<MenuMatchConfig>,
|
||||
cursors: Query<&UiGlobalTransform, With<FGMenuCursor>>,
|
||||
cam: Single<&Camera>,
|
||||
cam: Single<&Camera, With<MenuCameraMarker>>,
|
||||
ui_scale: Res<UiScale>,
|
||||
) -> Result {
|
||||
let camera = cam.into_inner();
|
||||
|
||||
+3
-6
@@ -9,11 +9,8 @@ use bevy::{
|
||||
};
|
||||
|
||||
use crate::{
|
||||
input::{LocalInputAssignments, LocalInputSource},
|
||||
menus::{
|
||||
input::{MenuInput, MenuInputState},
|
||||
scaling,
|
||||
style::FGUiStyle,
|
||||
input::{LocalInputAssignments, LocalInputSource}, menus::{
|
||||
MenuCameraMarker, input::{MenuInput, MenuInputState}, scaling, style::FGUiStyle,
|
||||
},
|
||||
};
|
||||
|
||||
@@ -181,7 +178,7 @@ pub fn cursor_input(
|
||||
}
|
||||
|
||||
pub fn update_cursor_transform(
|
||||
camera: Single<&Camera>,
|
||||
camera: Single<&Camera, With<MenuCameraMarker>>,
|
||||
query: Query<(&mut Node, &PointerLocation), With<FGMenuCursor>>,
|
||||
ui_scale: Res<UiScale>,
|
||||
) {
|
||||
|
||||
+1
-4
@@ -53,6 +53,7 @@ pub fn wrap_menu(menu: impl Scene) -> impl Scene {
|
||||
#MenuCamera
|
||||
Camera
|
||||
Camera2d
|
||||
MenuCameraMarker
|
||||
),
|
||||
(
|
||||
#MenuContainer
|
||||
@@ -73,7 +74,6 @@ pub fn wrap_menu(menu: impl Scene) -> impl Scene {
|
||||
|
||||
pub fn despawn_menu(
|
||||
existing_menu: Option<Single<Entity, With<MenuMarker>>>,
|
||||
existing_menu_camera: Option<Single<Entity, With<MenuCameraMarker>>>,
|
||||
mut commands: Commands,
|
||||
) {
|
||||
if let Some(entity) = existing_menu {
|
||||
@@ -82,9 +82,6 @@ pub fn despawn_menu(
|
||||
.despawn();
|
||||
}
|
||||
|
||||
if let Some(menu_cam) = existing_menu_camera {
|
||||
commands.entity(*menu_cam).despawn();
|
||||
}
|
||||
}
|
||||
|
||||
pub fn spawn_menu(
|
||||
|
||||
+3
-3
@@ -19,10 +19,10 @@ pub enum GameplaySet {
|
||||
StateUpdate,
|
||||
/// Integrate velocities into positions.
|
||||
Physics,
|
||||
/// Solve collision boxes
|
||||
Animation,
|
||||
/// Resolve the integrated positions against the stage.
|
||||
Collision,
|
||||
/// Solve collision boxes
|
||||
Animation,
|
||||
/// Resolve attacks
|
||||
Attacks,
|
||||
}
|
||||
@@ -40,8 +40,8 @@ impl Plugin for GameplaySchedulePlugin {
|
||||
GameplaySet::Interrupt,
|
||||
GameplaySet::StateUpdate,
|
||||
GameplaySet::Physics,
|
||||
GameplaySet::Collision,
|
||||
GameplaySet::Animation,
|
||||
GameplaySet::Collision,
|
||||
GameplaySet::Attacks,
|
||||
)
|
||||
.chain(),
|
||||
|
||||
Reference in New Issue
Block a user